staging: unisys: visorhba - style fix
PATCH v2 1/1 staging: unisys: visorhba - style fix
Fixed style of permissions to octal.
Found using checkpatch
V1 has vauge subject
--- drivers/staging/unisys/visorhba/visorhba_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/unisys/visorhba/visorhba_main.c +1 -1
@@ -1090,7 +1090,7 @@ static int visorhba_probe(struct visor_device *dev) goto err_scsi_remove_host; } devdata->debugfs_info = -debugfs_create_file ("info" ,S_IRUSR |S_IRGRP , +debugfs_create_file ("info" ,0440 , devdata->debugfs_dir, devdata, &info_debugfs_fops);if (!devdata->debugfs_info) {
Signature · 1 line
2.13.0
Quoted 13 lines
-----Original Message-----
From: Derek Robson [mailto:[email protected]]
Sent: Friday, June 16, 2017 11:13 PM
To: Kershner, David A <[email protected]>; [email protected]; Sell, Timothy C <[email protected]>; Binder, David Anthony <[email protected]>; Wadgaonkar, Sameer Laxmikant <[email protected]>; [email protected]; [email protected]
Cc: *S-Par-Maintainer <[email protected]>; [email protected]; [email protected]
Subject: [PATCH V2] staging: unisys: visorhba - style fix
Quoted 4 lines
Fixed style of permissions to octal.
Found using checkpatchSigned-off-by Derek Robson <[email protected]>
I applied it and tested it. Though when I applied it, the V1 comment was included in the patch commit.
Quoted 22 lines
V1 has vauge subject
--- drivers/staging/unisys/visorhba/visorhba_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/unisys/visorhba/visorhba_main.c +1
-2@@ -1090,7 +1090,7 @@ static int visorhba_probe(struct visor_device *dev) goto err_scsi_remove_host; } devdata->debugfs_info = -debugfs_create_file ("info" ,S_IRUSR |S_IRGRP , +debugfs_create_file ("info" ,0440 , devdata->debugfs_dir, devdata, &info_debugfs_fops);if (!devdata->debugfs_info) { --2.13.0
Quoted 13 lines · David A
Quoted 13 lines
-----Original Message-----
From: Derek Robson [mailto:[email protected]]
Sent: Friday, June 16, 2017 11:13 PM
To: Kershner, David A <[email protected]>; [email protected]; Sell, Timothy C <[email protected]>; Binder, David Anthony <[email protected]>; Wadgaonkar, Sameer Laxmikant <[email protected]>; [email protected]; [email protected]
Cc: *S-Par-Maintainer <[email protected]>; [email protected]; [email protected]
Subject: [PATCH V2] staging: unisys: visorhba - style fix
Quoted 6 lines
Quoted 4 lines
Fixed style of permissions to octal.
Found using checkpatchSigned-off-by Derek Robson <[email protected]>I applied it and tested it. Though when I applied it, the V1 comment was included in the patch commit.
Derek, for clarification what David means is that the version notes should go below the dotted line so as not to be included in the patch commit. You may also like to read Documentation/process/submitting-patches.rst for tips on writing your commit log (specifically section 2).
Quoted 5 lines
Quoted 5 lines
V1 has vauge subject
---
v1 -> v2
- fix vague subject
Quoted 16 lines
Quoted 16 lines
drivers/staging/unisys/visorhba/visorhba_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/unisys/visorhba/visorhba_main.c +1
-1@@ -1090,7 +1090,7 @@ static int visorhba_probe(struct visor_device *dev) goto err_scsi_remove_host; } devdata->debugfs_info = -debugfs_create_file ("info" ,S_IRUSR |S_IRGRP , +debugfs_create_file ("info" ,0440 , devdata->debugfs_dir, devdata, &info_debugfs_fops);
Quoted 8 lines
Quoted 3 lines
drivers/staging/unisys/visorhba/visorhba_main.c +0
-1if (!devdata->debugfs_info) { --2.13.0
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Good luck,
Tobin.