igt/pm_rps: Remove remaining assert on CUR <= MAX
PATCH 1/1 igt/pm_rps: Remove remaining assert on CUR <= MAX
From: Jeff McGee <[email protected]>
This completes the change started by:
commit 39cccab83b7c515a2b57abe679a8cb304c8933ef
Author: Chris Wilson <[email protected]> Date: Fri May 19 09:41:40 2017 +0100
igt/pm_rps: Allow CUR to be greater than MAX (overclocking)
--- tests/pm_rps.c | 1 - 1 file changed, 1 deletion(-)
tests/pm_rps.c +0 -1
@@ -145,7 +145,6 @@ static int do_writeval(FILE *filp, int val, int lerrno, bool readback_check)static void checkit (const int *freqs) {igt_assert_lte (freqs[MIN ], freqs[MAX ]); -igt_assert_lte (freqs[CUR ], freqs[MAX ]);igt_assert_lte (freqs[RPn], freqs[CUR ]);igt_assert_lte (freqs[RPn], freqs[MIN ]);igt_assert_lte (freqs[MAX ], freqs[RP0 ]);
Signature · 6 lines
2.11.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 4 lines · On Wed, 2017-06-14 at 12:44 -0700, [email protected] wrote:
From: Jeff McGee <[email protected]>
This completes the change started by:
Quoted 8 lines
commit
39cccab83b7c515a2b57abe679a8cb304c8933ef
Author: Chris Wilson <[email protected]>
Date: Fri May 19 09:41:40 2017 +0100igt/pm_rps: Allow CUR to be greater than MAX (overclocking)
Cc Chris Wilson <[email protected]>Signed-off-by Jeff McGee <[email protected]>
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 9 lines · Radoslaw
Quoted 8 lines · On Wed, 2017-06-14 at 12:44 -0700, [email protected] wrote:
From: Jeff McGee <[email protected]>
This completes the change started by:
commit
39cccab83b7c515a2b57abe679a8cb304c8933ef
Author: Chris Wilson <[email protected]>
Date: Fri May 19 09:41:40 2017 +0100
Quoted 5 lines
Quoted 4 lines
igt/pm_rps: Allow CUR to be greater than MAX (overclocking)
Cc Chris Wilson <[email protected]>Signed-off-by Jeff McGee <[email protected]>Reviewed-by Radoslaw Szwichtenberg <[email protected]>
Pushed. Thanks for the patch and the review.
Excerpt from CONTRIBUTING:
-----------------------------------------------------------------------------
Please use --subject-prefix="PATCH i-g-t" so that i-g-t patches are easily identified in the massive amount mails on intel-gfx. To ensure this is always done, autogen.sh will run:
git config format.subjectprefix "PATCH i-g-t"
on its first invocation.
-----------------------------------------------------------------------------
Lack of proper prefix breaks filtering / patchwork and makes changes harder to track, and effectilvely it takes longer to get the patch in.
The autogen.sh thing is a recent addition.
Signature · 6 lines
Cheers, Arek _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 26 lines · Arkadiusz Hiler
Quoted 9 lines · Radoslaw
Quoted 8 lines · On Wed, 2017-06-14 at 12:44 -0700, [email protected] wrote:
From: Jeff McGee <[email protected]>
This completes the change started by:
commit
39cccab83b7c515a2b57abe679a8cb304c8933ef
Author: Chris Wilson <[email protected]>
Date: Fri May 19 09:41:40 2017 +0100Quoted 5 lines
Quoted 4 lines
igt/pm_rps: Allow CUR to be greater than MAX (overclocking)
Cc Chris Wilson <[email protected]>Signed-off-by Jeff McGee <[email protected]>Reviewed-by Radoslaw Szwichtenberg <[email protected]>Pushed. Thanks for the patch and the review.
Excerpt from CONTRIBUTING:
-----------------------------------------------------------------------------
Please use --subject-prefix="PATCH i-g-t" so that i-g-t patches are easily identified in the massive amount mails on intel-gfx. To ensure this is always done,autogen.shwill run:git config format.subjectprefix "PATCH i-g-t"
Quoted 7 lines
on its first invocation.
-----------------------------------------------------------------------------Lack of proper prefix breaks filtering / patchwork and makes changes harder to track, and effectilvely it takes longer to get the patch in.
The
autogen.shthing is a recent addition.
Hey Jeff,
The change has been reverted.
At first the it looked like a sensible folloup to previous changes and it even got r-bed, but as pointed out by Michal, this constraint still should hold, as it's checked in a non-boost scenario.
It hides bug introduced into the kernel by the commit:
"drm/i915: Define a separate variable and control for RPS waitboost frequency"
for GuC submission path, as the check below always holds true as we have waiters all the time:
if (client_boost || any_waiters) max = hw_max;
What was the point of this change?
Were you aware of the fail in the guc_submission scenario?
Signature · 6 lines
Cheers, Arek _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 46 lines · Arkadiusz Hiler
Quoted 26 lines · Arkadiusz Hiler
Quoted 9 lines · Radoslaw
Quoted 8 lines · On Wed, 2017-06-14 at 12:44 -0700, [email protected] wrote:
From: Jeff McGee <[email protected]>
This completes the change started by:
commit
39cccab83b7c515a2b57abe679a8cb304c8933ef
Author: Chris Wilson <[email protected]>
Date: Fri May 19 09:41:40 2017 +0100Quoted 5 lines
Quoted 4 lines
igt/pm_rps: Allow CUR to be greater than MAX (overclocking)
Cc Chris Wilson <[email protected]>Signed-off-by Jeff McGee <[email protected]>Reviewed-by Radoslaw Szwichtenberg <[email protected]>Pushed. Thanks for the patch and the review.
Excerpt from CONTRIBUTING:
-----------------------------------------------------------------------------
Please use --subject-prefix="PATCH i-g-t" so that i-g-t patches are easily identified in the massive amount mails on intel-gfx. To ensure this is always done,autogen.shwill run:git config format.subjectprefix "PATCH i-g-t"
Quoted 7 lines
on its first invocation.
-----------------------------------------------------------------------------Lack of proper prefix breaks filtering / patchwork and makes changes harder to track, and effectilvely it takes longer to get the patch in.
The
autogen.shthing is a recent addition.Hey Jeff,
The change has been reverted.
At first the it looked like a sensible folloup to previous changes and it even got r-bed, but as pointed out by Michal, this constraint still should hold, as it's checked in a non-boost scenario.
It hides bug introduced into the kernel by the commit:
"drm/i915: Define a separate variable and control for RPS waitboost frequency"
Quoted 10 lines
for GuC submission path, as the check below always holds true as we have waiters all the time:
if (client_boost || any_waiters) max = hw_max;What was the point of this change?
Were you aware of the fail in theguc_submissionscenario?Signature · 2 lines
Cheers, Arek
Hi Arek. Yes, this was prompted by a regression of this subtest in Yocto which uses GuC submission. I root caused it to this same i915 commit from Chris but incorrectly thought that the new "policy" was that sysfs max freq could be ignored in pretty much any situation. I understand now that it should be ignored in only boost and real user wait situations (not those triggered by GuC). So I do agree with this revert.
Is there an i915 fix coming soon? Chris?
Jeff
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 58 lines · Jeff McGee
Quoted 46 lines · Arkadiusz Hiler
Quoted 26 lines · Arkadiusz Hiler
Quoted 9 lines · Radoslaw
Quoted 8 lines · On Wed, 2017-06-14 at 12:44 -0700, [email protected] wrote:
From: Jeff McGee <[email protected]>
This completes the change started by:
commit
39cccab83b7c515a2b57abe679a8cb304c8933ef
Author: Chris Wilson <[email protected]>
Date: Fri May 19 09:41:40 2017 +0100Quoted 5 lines
Quoted 4 lines
igt/pm_rps: Allow CUR to be greater than MAX (overclocking)
Cc Chris Wilson <[email protected]>Signed-off-by Jeff McGee <[email protected]>Reviewed-by Radoslaw Szwichtenberg <[email protected]>Pushed. Thanks for the patch and the review.
Excerpt from CONTRIBUTING:
-----------------------------------------------------------------------------
Please use --subject-prefix="PATCH i-g-t" so that i-g-t patches are easily identified in the massive amount mails on intel-gfx. To ensure this is always done,autogen.shwill run:git config format.subjectprefix "PATCH i-g-t"
Quoted 7 lines
on its first invocation.
-----------------------------------------------------------------------------Lack of proper prefix breaks filtering / patchwork and makes changes harder to track, and effectilvely it takes longer to get the patch in.
The
autogen.shthing is a recent addition.Hey Jeff,
The change has been reverted.
At first the it looked like a sensible folloup to previous changes and it even got r-bed, but as pointed out by Michal, this constraint still should hold, as it's checked in a non-boost scenario.
It hides bug introduced into the kernel by the commit:
"drm/i915: Define a separate variable and control for RPS waitboost frequency"Quoted 10 lines
for GuC submission path, as the check below always holds true as we have waiters all the time:
if (client_boost || any_waiters) max = hw_max;What was the point of this change?
Were you aware of the fail in theguc_submissionscenario?Signature · 2 lines
Cheers, Arek
Quoted 6 lines
Hi Arek. Yes, this was prompted by a regression of this subtest in Yocto which uses GuC submission. I root caused it to this same i915 commit from Chris but incorrectly thought that the new "policy" was that sysfs max freq could be ignored in pretty much any situation. I understand now that it should be ignored in only boost and real user wait situations (not those triggered by GuC). So I do agree with this revert.
Hey,
Thank you for the explanation. I see where to confusion issued from - the change seemed to make sense on it's own and to be just a simple follow up to the previous patch.
Quoted 1 line
Is there an i915 fix coming soon? Chris?
I think it's under the review on the ML already:
https://patchwork.freedesktop.org/patch/163146/
Signature · 7 lines
Cheers, Arek _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx