Skip to contentSkip to conversation

barebox: support multiple image files

PATCH New Marcin Niestroj 2 participants 2 messages Jun 21, 2017

lore
Share & tools
lore

Marcin Niestroj

author
#0 lore raw

PATCH v2 1/1 barebox: support multiple image files

Add support for specifying multiple image files in BR2_TARGET_BAREBOX_IMAGE_FILE config option.

This is usefull for boards with several RAM size variants.

Signed-off-by Marcin Niestroj <[email protected]>

---
Changes v1 -> v2:
* Improve Config.in description (suggested by Thomas)

 boot/barebox/barebox-aux/Config.in | 4 ++--
 boot/barebox/barebox.mk            | 2 +-
 boot/barebox/barebox/Config.in     | 4 ++--
 3 files changed, 5 insertions(+), 5 deletions(-)
boot/barebox/barebox-aux/Config.in +2 -2
index ec3b97cb8..d39d24f76 100644
@@ -30,9 +30,9 @@ config BR2_TARGET_BAREBOX_AUX_CONFIG_FRAGMENT_FILES
 	  that will be merged to the main Barebox configuration file.
 
 config BR2_TARGET_BAREBOX_AUX_IMAGE_FILE
-	string "Image filename"
+	string "Image file names"
 	help
-	  Name of the generated barebox image, which will be copied to
+	  Space-separated list of barebox images which will be copied to
 	  the images directory.
 
 	  If left empty, defaults to:
boot/barebox/barebox.mk +1 -1
index 1690e8fa5..8bc9594ff 100644
@@ -113,7 +113,7 @@ $(1)_IMAGE_FILE = $$(call qstrip,$$(BR2_TARGET_$(1)_IMAGE_FILE))
 
 define $(1)_INSTALL_IMAGES_CMDS
 	if test -n "$$($(1)_IMAGE_FILE)"; then \
-		cp -L $$(@D)/$$($(1)_IMAGE_FILE) $$(BINARIES_DIR) ; \
+		cp -L $$(foreach image,$$($(1)_IMAGE_FILE),$$(@D)/$$(image)) $$(BINARIES_DIR) ; \
 	elif test -h $$(@D)/barebox-flash-image ; then \
 		cp -L $$(@D)/barebox-flash-image $$(BINARIES_DIR)/barebox.bin ; \
 	else \
boot/barebox/barebox/Config.in +2 -2
index 3d8d01456..0be26adf9 100644
@@ -31,9 +31,9 @@ config BR2_TARGET_BAREBOX_CONFIG_FRAGMENT_FILES
 	  that will be merged to the main Barebox configuration file.
 
 config BR2_TARGET_BAREBOX_IMAGE_FILE
-	string "Image filename"
+	string "Image file names"
 	help
-	  Name of the generated barebox image, which will be copied to
+	  Space-separated list of barebox images which will be copied to
 	  the images directory.
 
 	  If left empty, defaults to:
Signature · 1 line
2.13.1
#1 lore raw

PATCH v2 1/1 barebox: support multiple image files

Hello,

Quoted 2 lines · Marcin Niestroj

define $(1)_INSTALL_IMAGES_CMDS
if test -n "$$($(1)_IMAGE_FILE)"; then \

I've renamed this variable to $(1)_IMAGE_FILES, because it now contains potentially multiple files.

Applied with this fixed.

BTW, it would be nice to provide a test case for this feature in our testing infrastructure, see support/testing/. I think in the long run we should require the addition of test cases when such features are added.

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com