Skip to contentSkip to conversation

package/dt-utils: new package

PATCH New Marcin Niestroj 2 participants 4 messages Jun 20, 2017 – Jun 23, 2017

lore
Share & tools
lore

Marcin Niestroj

author
#0 lore raw

PATCH 1/1 package/dt-utils: new package

Signed-off-by Marcin Niestroj <[email protected]>
---
 DEVELOPERS                   |  1 +
 package/Config.in            |  1 +
 package/dt-utils/Config.in   |  8 ++++++++
 package/dt-utils/dt-utils.mk | 15 +++++++++++++++
 4 files changed, 25 insertions(+)
 create mode 100644 package/dt-utils/Config.in
 create mode 100644 package/dt-utils/dt-utils.mk
DEVELOPERS +1 -0
index afc45962c..84f06be13 100644
@@ -1063,6 +1063,7 @@ N:	Marcin Niestroj <[email protected]>
 F:	board/grinn/
 F:	configs/grinn_*
 F:	package/argparse/
+F:	package/dt-utils/
 F:	package/easydbus/
 F:	package/luaossl/
 F:	package/rs485conf/
package/Config.in +1 -0
index 9df0b4247..4c04aa80d 100644
@@ -382,6 +382,7 @@ endmenu
 	source "package/devmem2/Config.in"
 	source "package/dmidecode/Config.in"
 	source "package/dmraid/Config.in"
+	source "package/dt-utils/Config.in"
 	source "package/dtv-scan-tables/Config.in"
 	source "package/dvb-apps/Config.in"
 	source "package/dvbsnoop/Config.in"
package/dt-utils/Config.in new file +8 -0
new file mode 100644
index 000000000..3cf4681d6
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_DT_UTILS
+	bool "dt-utils"
+	depends on BR2_PACKAGE_HAS_UDEV
+	help
+	  Tools for flattened device-tree dumping and barebox state
+	  manipulation.
+
+	  https://git.pengutronix.de/cgit/tools/dt-utils/
package/dt-utils/dt-utils.mk new file +15 -0
new file mode 100644
index 000000000..d7c053ac1
@@ -0,0 +1,15 @@
+################################################################################
+#
+# dt-utils
+#
+################################################################################
+
+DT_UTILS_VERSION = v2017.03.0
+DT_UTILS_SITE = https://git.pengutronix.de/git/tools/dt-utils
+DT_UTILS_SITE_METHOD = git
+DT_UTILS_LICENSE = GPLv2
+DT_UTILS_LICENSE_FILES = COPYING
+DT_UTILS_DEPENDENCIES = udev
+DT_UTILS_AUTORECONF = YES
+
+$(eval $(autotools-package))
Signature · 1 line
2.13.1
#1 lore raw

PATCH 1/1 package/dt-utils: new package

Hello,

Quoted 9 lines · Marcin Niestroj
Signed-off-by Marcin Niestroj <[email protected]>
---
 DEVELOPERS                   |  1 +
 package/Config.in            |  1 +
 package/dt-utils/Config.in   |  8 ++++++++
 package/dt-utils/dt-utils.mk | 15 +++++++++++++++
 4 files changed, 25 insertions(+)
 create mode 100644 package/dt-utils/Config.in
 create mode 100644 package/dt-utils/dt-utils.mk

This package doesn't build with the following defconfig:

BR2_arm=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_TOOLCHAIN_EXTERNAL_CUSTOM=y
BR2_TOOLCHAIN_EXTERNAL_DOWNLOAD=y BR2_TOOLCHAIN_EXTERNAL_URL="http://autobuild.buildroot.org/toolchains/tarballs/br-arm-full-2017.05-444-g6c704ba.tar.bz2" BR2_TOOLCHAIN_EXTERNAL_GCC_4_9=y
BR2_TOOLCHAIN_EXTERNAL_HEADERS_3_10=y
BR2_TOOLCHAIN_EXTERNAL_LOCALE=y
# BR2_TOOLCHAIN_EXTERNAL_HAS_THREADS_DEBUG is not set
BR2_TOOLCHAIN_EXTERNAL_CXX=y
BR2_INIT_NONE=y
BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_EUDEV=y
BR2_SYSTEM_BIN_SH_NONE=y
# BR2_PACKAGE_BUSYBOX is not set
BR2_PACKAGE_DT_UTILS=y
# BR2_TARGET_ROOTFS_TAR is not set

Quoted 6 lines
package/dt-utils/Config.in new file +0 -0
new file mode 100644
index 000000000..3cf4681d6

package/dt-utils/Config.in line 8

Quoted 8 lines
package/dt-utils/Config.in new file +8 -0
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_DT_UTILS
+	bool "dt-utils"
+	depends on BR2_PACKAGE_HAS_UDEV
+	help
+	  Tools for flattened device-tree dumping and barebox state
+	  manipulation.
+
+	  https://git.pengutronix.de/cgit/tools/dt-utils/

You need to add a Config.in comment here about the udev dependency. Grep around in the Buildroot tree to see the proper formatting for such dependencies.

package/dt-utils/Config.in

Quoted 4 lines
package/dt-utils/Config.in new file +4 -0
+DT_UTILS_VERSION = v2017.03.0
+DT_UTILS_SITE = https://git.pengutronix.de/git/tools/dt-utils
+DT_UTILS_SITE_METHOD = git
+DT_UTILS_LICENSE = GPLv2

Please use SPDX license codes, so GPL-2.0.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 package/dt-utils: new package

Hello,

Quoted 15 lines · Thomas Petazzoni

Hello,

Quoted 9 lines · Marcin Niestroj
Signed-off-by Marcin Niestroj <[email protected]>
---
 DEVELOPERS                   |  1 +
 package/Config.in            |  1 +
 package/dt-utils/Config.in   |  8 ++++++++
 package/dt-utils/dt-utils.mk | 15 +++++++++++++++
 4 files changed, 25 insertions(+)
 create mode 100644 package/dt-utils/Config.in
 create mode 100644 package/dt-utils/dt-utils.mk

This package doesn't build with the following defconfig:

Quoted 16 lines

BR2_arm=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_TOOLCHAIN_EXTERNAL_CUSTOM=y
BR2_TOOLCHAIN_EXTERNAL_DOWNLOAD=y BR2_TOOLCHAIN_EXTERNAL_URL="http://autobuild.buildroot.org/toolchains/tarballs/br-arm-full-2017.05-444-g6c704ba.tar.bz2" BR2_TOOLCHAIN_EXTERNAL_GCC_4_9=y
BR2_TOOLCHAIN_EXTERNAL_HEADERS_3_10=y
BR2_TOOLCHAIN_EXTERNAL_LOCALE=y
# BR2_TOOLCHAIN_EXTERNAL_HAS_THREADS_DEBUG is not set
BR2_TOOLCHAIN_EXTERNAL_CXX=y
BR2_INIT_NONE=y
BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_EUDEV=y
BR2_SYSTEM_BIN_SH_NONE=y
# BR2_PACKAGE_BUSYBOX is not set
BR2_PACKAGE_DT_UTILS=y
# BR2_TARGET_ROOTFS_TAR is not set

Sorry, forgot to give the error message:

CC src/fdtdump-fdtdump.o
GEN src/libdt-utils.pc
In file included from ./src/dt/list.h:4:0,

                 from ./src/dt/dt.h:5,
                 from src/dtblint-imx-pinmux.c:13:
./src/dt/common.h:181:22: error: static declaration of ?strlcpy? follows non-static declaration
 static inline size_t strlcpy(char *dest, const char *src, size_t size)
                      ^
In file included from ./src/dt/common.h:11:0,
                 from ./src/dt/list.h:4,
                 from ./src/dt/dt.h:5,
                 from src/dtblint-imx-pinmux.c:13:
/home/thomas/projets/buildroot/output/host/usr/arm-buildroot-linux-uclibcgnueabi/sysroot/usr/include/string.h:424:15: note: previous declaration of ?strlcpy? was here
 extern size_t strlcpy(char *__restrict dst, const char *__restrict src,
               ^

(several times)

Could you fix those issues, and send an updated version?

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
author
#3 lore raw

PATCH 1/1 package/dt-utils: new package

In reply to Thomas Petazzoni

Hi,

Quoted 13 lines · Thomas Petazzoni

Hello,

Quoted 9 lines · Marcin Niestroj
Signed-off-by Marcin Niestroj <[email protected]>
---
  DEVELOPERS                   |  1 +
  package/Config.in            |  1 +
  package/dt-utils/Config.in   |  8 ++++++++
  package/dt-utils/dt-utils.mk | 15 +++++++++++++++
  4 files changed, 25 insertions(+)

create mode 100644 package/dt-utils/Config.in
create mode 100644 package/dt-utils/dt-utils.mk

Quoted 1 line

This package doesn't build with the following defconfig:

Thanks for spotting that. I've only tested this package with glibc library. Looks like this package also didn't build with musl.

Quoted 18 lines

BR2_arm=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_TOOLCHAIN_EXTERNAL_CUSTOM=y
BR2_TOOLCHAIN_EXTERNAL_DOWNLOAD=y BR2_TOOLCHAIN_EXTERNAL_URL="http://autobuild.buildroot.org/toolchains/tarballs/br-arm-full-2017.05-444-g6c704ba.tar.bz2" BR2_TOOLCHAIN_EXTERNAL_GCC_4_9=y
BR2_TOOLCHAIN_EXTERNAL_HEADERS_3_10=y
BR2_TOOLCHAIN_EXTERNAL_LOCALE=y
# BR2_TOOLCHAIN_EXTERNAL_HAS_THREADS_DEBUG is not set
BR2_TOOLCHAIN_EXTERNAL_CXX=y
BR2_INIT_NONE=y
BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_EUDEV=y
BR2_SYSTEM_BIN_SH_NONE=y
# BR2_PACKAGE_BUSYBOX is not set
BR2_PACKAGE_DT_UTILS=y
# BR2_TARGET_ROOTFS_TAR is not set

Signature · 1 line
Marcin Niestroj