Skip to contentSkip to conversation

Only call drmmode_scanout_free for non-GPU screens in LeaveVT

PATCH In review Michel Dänzer 2 participants 2 messages Jun 22, 2017 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Only call drmmode_scanout_free for non-GPU screens in LeaveVT

From: Michel Dänzer <[email protected]>

Destroying the scanout buffers of GPU screens resulted in a crash when switching back to the Xorg VT.

---
 src/radeon_kms.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
src/radeon_kms.c +2 -1
index c4bdfcfac..5637e7f8a 100644
@@ -2478,7 +2478,8 @@ void RADEONLeaveVT_KMS(VT_FUNC_ARGS_DECL)
     radeon_drop_drm_master(pScrn);
 
     xf86RotateFreeShadow(pScrn);
-    drmmode_scanout_free(pScrn);
+    if (!pScrn->is_gpu)
+	drmmode_scanout_free(pScrn);
 
     xf86_hide_cursors (pScrn);
     info->accel_state->XInited3D = FALSE;
Signature · 6 lines
2.11.0

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 20170622034055.3024-1-michel-otUistvHUpPR7s880joybQ@public.gmane.org

Reviewed-by Alex Deucher
#2 lore raw
Quoted 8 lines

-----Original Message-----
From: amd-gfx [mailto:[email protected]] On Behalf Of Michel Dänzer
Sent: Wednesday, June 21, 2017 11:41 PM
To: [email protected]
Subject: [PATCH xf86-video-ati] Only call drmmode_scanout_free for non- GPU screens in LeaveVT

Quoted 6 lines

From: Michel Dänzer <[email protected]>

Destroying the scanout buffers of GPU screens resulted in a crash when switching back to the Xorg VT.

Quoted 19 lines
---
 src/radeon_kms.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
src/radeon_kms.c +2 -1
index c4bdfcfac..5637e7f8a 100644
@@ -2478,7 +2478,8 @@ void
 RADEONLeaveVT_KMS(VT_FUNC_ARGS_DECL)
     radeon_drop_drm_master(pScrn);
 
     xf86RotateFreeShadow(pScrn);
-    drmmode_scanout_free(pScrn);
+    if (!pScrn->is_gpu)
+	drmmode_scanout_free(pScrn);
 
     xf86_hide_cursors (pScrn);
     info->accel_state->XInited3D = FALSE;
Quoted 7 lines

--
2.11.0

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx