Skip to contentSkip to conversation

hwloc: add several PACKAGECONFIG items

PATCH Superseded Chen Qi 3 participants 4 messages Jun 22, 2017 – Jun 29, 2017

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Chen Qi

author
#0 lore raw

PATCH 1/1 hwloc: add several PACKAGECONFIG items

Add PACKAGECONFIG items to allow for more flexiblity.

---
 meta-oe/recipes-extended/hwloc/hwloc_1.11.5.bb | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)
meta-oe/recipes-extended/hwloc/hwloc_1.11.5.bb +8 -2
index e067f2799..16cd507e6 100644
@@ -13,10 +13,16 @@ SRC_URI[sha256sum] = "95d80286dfe658a3f79e2ac90698782bb36e5504f4bac1bba2394ba14d
 
 inherit autotools
 
-DEPENDS += "cairo ncurses udev libxml2 zlib libpciaccess"
-DEPENDS += "${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'virtual/libx11', '', d)}"
+DEPENDS += "ncurses udev zlib"
 DEPENDS += "${@bb.utils.contains('DISTRO_FEATURES', 'selinux', 'libselinux', '', d)}"
 
+PACKAGECONFIG ?= "numactl pci libxml2 ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11', '', d)}"
+
+PACKAGECONFIG[numactl] = "--enable-libnuma,--disable-libnuma,numactl,numactl"
+PACKAGECONFIG[libxml2] = "--enable-libxml2,--disable-libxml2,libxml2,libxml2"
+PACKAGECONFIG[x11] = "--with-x,--without-x,virtual/libx11 cairo,cairo"
+PACKAGECONFIG[pci] = "--enable-pci,--disable-pci,libpciaccess,libpciaccess"
+
 # Split hwloc library into separate subpackage
 PACKAGES_prepend = " lib${PN} "
 FILES_lib${PN} += "${libdir}/lib${PN}.so*"
Signature · 1 line
2.11.0
#1 lore raw

Should numactl be enabled by default?

numactl.bb currently marks it ARM incompatible:
# ARM does not currently support NUMA
COMPATIBLE_HOST = "^((?!arm).*)$"

and enabling the PACKAGECONFIG here by default would extend the same restriction to hwloc as well.

Quoted 47 lines · Chen Qi

Add PACKAGECONFIG items to allow for more flexiblity.

---
 meta-oe/recipes-extended/hwloc/hwloc_1.11.5.bb | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)
meta-oe/recipes-extended/hwloc/hwloc_1.11.5.bb +0 -0
index e067f2799..16cd507e6 100644
@@ -13,10 +13,16 @@ SRC_URI[sha256sum] = "95d80286dfe658a3f79e2ac9069878

2bb36e5504f4bac1bba2394ba14d

inherit autotools

meta-oe/recipes-extended/hwloc/hwloc_1.11.5.bb +0 -2
-DEPENDS += "cairo ncurses udev libxml2 zlib libpciaccess"
-DEPENDS += "${@bb.utils.contains('DISTRO_FEATURES', 'x11',

'virtual/libx11', '', d)}"
+DEPENDS += "ncurses udev zlib"
DEPENDS += "${@bb.utils.contains('DISTRO_FEATURES', 'selinux',
'libselinux', '', d)}"

+PACKAGECONFIG ?= "numactl pci libxml2 ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11', '', d)}"

meta-oe/recipes-extended/hwloc/hwloc_1.11.5.bb +2 -0
+
+PACKAGECONFIG[numactl] = "--enable-libnuma,--disable-

libnuma,numactl,numactl" +PACKAGECONFIG[libxml2] = "--enable-libxml2,--disable- libxml2,libxml2,libxml2"

meta-oe/recipes-extended/hwloc/hwloc_1.11.5.bb +2 -0
+PACKAGECONFIG[x11] = "--with-x,--without-x,virtual/libx11 cairo,cairo"
+PACKAGECONFIG[pci] = "--enable-pci,--disable-pci,

libpciaccess,libpciaccess"
+
# Split hwloc library into separate subpackage
PACKAGES_prepend = " lib${PN} "
FILES_lib${PN} += "${libdir}/lib${PN}.so*"
--
2.11.0

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#2 lore raw
Quoted 9 lines · Martin Jansa

Should numactl be enabled by default?

numactl.bb currently marks it ARM incompatible:
# ARM does not currently support NUMA
COMPATIBLE_HOST = "^((?!arm).*)$"

and enabling the PACKAGECONFIG here by default would extend the same restriction to hwloc as well.

This patch exposes another issue where pkgconfig comes into picture but is missing in rss

fix is here
http://lists.openembedded.org/pipermail/openembedded-devel/2017-June/113366.html

Quoted 55 lines · Chen Qi
Quoted 42 lines

Add PACKAGECONFIG items to allow for more flexiblity.

---
 meta-oe/recipes-extended/hwloc/hwloc_1.11.5.bb | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)
meta-oe/recipes-extended/hwloc/hwloc_1.11.5.bb +0 -0
index e067f2799..16cd507e6 100644
@@ -13,10 +13,16 @@ SRC_URI[sha256sum] = "95d80286dfe658a3f79e2ac9069878

2bb36e5504f4bac1bba2394ba14d

inherit autotools

meta-oe/recipes-extended/hwloc/hwloc_1.11.5.bb +0 -2
-DEPENDS += "cairo ncurses udev libxml2 zlib libpciaccess"
-DEPENDS += "${@bb.utils.contains('DISTRO_FEATURES', 'x11',

'virtual/libx11', '', d)}"
+DEPENDS += "ncurses udev zlib"
DEPENDS += "${@bb.utils.contains('DISTRO_FEATURES', 'selinux',
'libselinux', '', d)}"

+PACKAGECONFIG ?= "numactl pci libxml2 ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11', '', d)}"

meta-oe/recipes-extended/hwloc/hwloc_1.11.5.bb +2 -0
+
+PACKAGECONFIG[numactl] = "--enable-libnuma,--disable-

libnuma,numactl,numactl" +PACKAGECONFIG[libxml2] = "--enable-libxml2,--disable- libxml2,libxml2,libxml2"

meta-oe/recipes-extended/hwloc/hwloc_1.11.5.bb +2 -0
+PACKAGECONFIG[x11] = "--with-x,--without-x,virtual/libx11 cairo,cairo"
+PACKAGECONFIG[pci] = "--enable-pci,--disable-pci,

libpciaccess,libpciaccess"
+
# Split hwloc library into separate subpackage
PACKAGES_prepend = " lib${PN} "
FILES_lib${PN} += "${libdir}/lib${PN}.so*"
--
2.11.0

Quoted 6 lines

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

author
#3 lore raw
In reply to Martin Jansa
Quoted 9 lines · Martin Jansa

Should numactl be enabled by default?

numactl.bb <http://numactl.bb> currently marks it ARM incompatible:
# ARM does not currently support NUMA
COMPATIBLE_HOST = "^((?!arm).*)$"

and enabling the PACKAGECONFIG here by default would extend the same restriction to hwloc as well.

Thanks for pointing out the problem.
I'll send out V2.

Best Regards,
Chen Qi

Quoted 59 lines · On Thu, Jun 22, 2017 at 8:46 AM, Chen Qi <[email protected]…
    Add PACKAGECONFIG items to allow for more flexiblity.

    Signed-off-by: Chen Qi <[email protected]
    <mailto:[email protected]>>
    ---
     meta-oe/recipes-extended/hwloc/hwloc_1.11.5.bb
    <http://hwloc_1.11.5.bb> | 10 ++++++++--
     1 file changed, 8 insertions(+), 2 deletions(-)

    diff --git a/meta-oe/recipes-extended/hwloc/hwloc_1.11.5.bb
    <http://hwloc_1.11.5.bb>
    b/meta-oe/recipes-extended/hwloc/hwloc_1.11.5.bb
    <http://hwloc_1.11.5.bb>
    index e067f2799..16cd507e6 100644
    --- a/meta-oe/recipes-extended/hwloc/hwloc_1.11.5.bb
    <http://hwloc_1.11.5.bb>
    +++ b/meta-oe/recipes-extended/hwloc/hwloc_1.11.5.bb
    <http://hwloc_1.11.5.bb>
    @@ -13,10 +13,16 @@ SRC_URI[sha256sum] =
    "95d80286dfe658a3f79e2ac90698782bb36e5504f4bac1bba2394ba14d

     inherit autotools

    -DEPENDS += "cairo ncurses udev libxml2 zlib libpciaccess"
    -DEPENDS += "${@bb.utils.contains('DISTRO_FEATURES', 'x11',
    'virtual/libx11', '', d)}"
    +DEPENDS += "ncurses udev zlib"
     DEPENDS += "${@bb.utils.contains('DISTRO_FEATURES', 'selinux',
    'libselinux', '', d)}"

    +PACKAGECONFIG ?= "numactl pci libxml2
    ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11', '', d)}"
    +
    +PACKAGECONFIG[numactl] =
    "--enable-libnuma,--disable-libnuma,numactl,numactl"
    +PACKAGECONFIG[libxml2] =
    "--enable-libxml2,--disable-libxml2,libxml2,libxml2"
    +PACKAGECONFIG[x11] = "--with-x,--without-x,virtual/libx11
    cairo,cairo"
    +PACKAGECONFIG[pci] =
    "--enable-pci,--disable-pci,libpciaccess,libpciaccess"
    +
     # Split hwloc library into separate subpackage
     PACKAGES_prepend = " lib${PN} "
     FILES_lib${PN} += "${libdir}/lib${PN}.so*"
    --
    2.11.0

    --
    _______________________________________________
    Openembedded-devel mailing list
    [email protected]
    <mailto:[email protected]>
    http://lists.openembedded.org/mailman/listinfo/openembedded-devel
    <http://lists.openembedded.org/mailman/listinfo/openembedded-devel>