blk-mq: remove double set queue_num

PATCH In review weiping 2 participants 2 messages Jun 22, 2017 Block layer

lore

Share & tools

lore

weiping

author

2017-06-22 15:06 UTC #0 lore raw

PATCH 1/1 blk-mq: remove double set queue_num

hwctx's queue_num has been set prior call blk_mq_init_hctx, so no need set it again.

Signed-off-by weiping <[email protected]>

---
 block/blk-mq.c | 1 -
 1 file changed, 1 deletion(-)

block/blk-mq.c +0 -1

index bb66c96..adcb79c 100644
@@ -1900,7 +1900,6 @@ static int blk_mq_init_hctx(struct request_queue *q,
 	spin_lock_init(&hctx->lock);
 	INIT_LIST_HEAD(&hctx->dispatch);
 	hctx->queue = q;
-	hctx->queue_num = hctx_idx;
 	hctx->flags = set->flags & ~BLK_MQ_F_TAG_SHARED;
 
 	cpuhp_state_add_instance_nocalls(CPUHP_BLK_MQ_DEAD, &hctx->cpuhp_dead);

Signature · 1 line

1.8.3.1

Jens Axboe

maintainer

2017-06-22 15:19 UTC #1 lore raw

Quoted 4 lines · weiping

hwctx's queue_num has been set prior call blk_mq_init_hctx, so no need set it again.
Signed-off-by weiping <[email protected]>

I still prefer full names, but it's trivial enough, I've queued it up for 4.13. Thanks.

Signature · 1 line

Jens Axboe