Skip to contentSkip to conversation

nvme-cli: Get Feature support for Extended Host Id

PATCH RESEND New Schremmer, Steven 2 participants 2 messages Jun 23, 2017

Subsystems (2)
Documentation NVMe
lore
Share & tools
lore

Schremmer, Steven

author
#0 lore raw

PATCH RESEND 1/1 nvme-cli: Get Feature support for Extended Host Id

Enable Extended Host Identifier flag is specified in cdw11. Also added the feature string for kato.
---
Rebased to latest upstream.

 Documentation/nvme-get-feature.txt | 3 +--
 nvme-print.c                       | 1 +
 nvme.c                             | 3 +++
 3 files changed, 5 insertions(+), 2 deletions(-)
Documentation/nvme-get-feature.txt +1 -2
index 4be581f..cdf6eef 100644
@@ -63,8 +63,7 @@ OPTIONS
 	Range Type
 
 --cdw11=<cdw11>::
-	The value for command dword 11, if applicable. Only known feature
-	using this is the interrupt vector configuration feature.
+	The value for command dword 11, if applicable.
 
 -b::
 --raw-binary::
nvme-print.c +1 -0
index 2da5acd..c08f312 100644
@@ -919,6 +919,7 @@ char *nvme_feature_to_string(int feature)
 	case NVME_FEAT_ASYNC_EVENT:	return "Async Event Configuration";
 	case NVME_FEAT_AUTO_PST:	return "Autonomous Power State Transition";
 	case NVME_FEAT_HOST_MEM_BUF:	return "Host Memory Buffer";
+	case NVME_FEAT_KATO:		return "Keep Alive Timer";
 	case NVME_FEAT_SW_PROGRESS:	return "Software Progress";
 	case NVME_FEAT_HOST_ID:		return "Host Identifier";
 	case NVME_FEAT_RESV_MASK:	return "Reservation Notification Mask";
nvme.c +3 -0
index a4e1b71..515d135 100644
@@ -1118,6 +1118,9 @@ static int get_feature(int argc, char **argv, struct command *cmd, struct plugin
 		break;
 	case NVME_FEAT_HOST_ID:
 		cfg.data_len = 8;
+		/* check for Extended Host Identifier */
+		if (cfg.cdw11 & 0x1)
+			cfg.data_len = 16;
 		break;
 	}
Signature · 1 line
2.12.2
#1 lore raw

PATCH RESEND 1/1 nvme-cli: Get Feature support for Extended Host Id

Quoted 2 lines · Steven

Enable Extended Host Identifier flag is specified in cdw11. Also added the feature string for kato.

I applied this before noticing the missing Signed-off-by. Please make sure to add those for future patches.

Otherwise, thanks for the patch!