Patch "drm/i915: Plumb the correct acquire ctx into intel_crtc_disable_noatomic()" has been added to the 4.11-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
drm/i915: Plumb the correct acquire ctx into intel_crtc_disable_noatomic()
to the 4.11-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
drm-i915-plumb-the-correct-acquire-ctx-into-intel_crtc_disable_noatomic.patch
and it can be found in the queue-4.11 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
b7f5dd36e0c5cb9ca1070a5e0f22f666bcff07efMon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ville=20Syrj=C3=A4l=C3=A4?= <[email protected]>
Date: Thu, 1 Jun 2017 17:36:14 +0300
Subject: drm/i915: Plumb the correct acquire ctx into intel_crtc_disable_noatomic()
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
From: Ville Syrjälä <[email protected]>
commit b7f5dd36e0c5cb9ca1070a5e0f22f666bcff07ef upstream.
If intel_crtc_disable_noatomic() were to ever get called during resume we'd end up deadlocking since resume has its own acqcuire_ctx but intel_crtc_disable_noatomic() still tries to use the mode_config.acquire_ctx. Pass down the correct acquire ctx from the top.
--- drivers/gpu/drm/i915/intel_display.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/intel_display.c +5 -4
@@ -6850,7 +6850,8 @@ static void i9xx_crtc_disable(struct intintel_set_cpu_fifo_underrun_reporting (dev_priv, pipe, false); } -static void intel_crtc_disable_noatomic (struct drm_crtc *crtc) +static void intel_crtc_disable_noatomic (struct drm_crtc *crtc, +struct drm_modeset_acquire_ctx *ctx) {struct intel_encoder *encoder;struct intel_crtc *intel_crtc =to_intel_crtc (crtc);
@@ -6880,7 +6881,7 @@ static void intel_crtc_disable_noatomic(return ; } - state->acquire_ctx = crtc->dev->mode_config.acquire_ctx; + state->acquire_ctx = ctx;/* Everything's already locked, -EDEADLK can't happen. */ crtc_state =intel_atomic_get_crtc_state (state, intel_crtc);
@@ -16872,7 +16873,7 @@ static void intel_sanitize_crtc(struct i plane = crtc->plane; crtc->base.primary->state->visible = true; crtc->plane = !plane; -intel_crtc_disable_noatomic (&crtc->base); +intel_crtc_disable_noatomic (&crtc->base, ctx); crtc->plane = plane; }
@@ -16888,7 +16889,7 @@ static void intel_sanitize_crtc(struct i/* Adjust the state of the output pipe according to whether we * have active connectors/encoders. */ if (crtc->active && !intel_crtc_has_encoders (crtc)) -intel_crtc_disable_noatomic (&crtc->base); +intel_crtc_disable_noatomic (&crtc->base, ctx);if (crtc->active ||HAS_GMCH_DISPLAY (dev_priv)) {/*
Patches currently in stable-queue which might be from [email protected] are
queue-4.11/drm-i915-plumb-the-correct-acquire-ctx-into-intel_crtc_disable_noatomic.patch
Greg KH
maintainerQuoted 8 lines · On Mon, Jun 26, 2017 at 09:29:41AM +0200, [email protected] wrote:
This is a note to let you know that I've just added the patch titled
drm/i915: Plumb the correct acquire ctx into
intel_crtc_disable_noatomic()to the 4.11-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
Quoted 6 lines
The filename of the patch is:
drm-i915-plumb-the-correct-acquire-ctx-into-intel_crtc_disable_noatomic.patch
and it can be found in the queue-4.11 subdirectory.If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Oops, no, broke the build for 4.11 and 4.9. I've had to drop it now.
I don't know why I keep trying here...
greg k-h