Skip to contentSkip to conversation

ARM: dts: sun7i: Add A20 LCD0 RGB888 pins

PATCH Superseded Jonathan Liu 2 participants 3 messages Jun 26, 2017

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: sun7i: Add A20 LCD0 RGB888 pins

The LCD0 controller on the A20 can do RGB output up to 8 bits per channel. Add the pins for RGB888 output.

---
 arch/arm/boot/dts/sun7i-a20.dtsi | 11 +++++++++++
 1 file changed, 11 insertions(+)
arch/arm/boot/dts/sun7i-a20.dtsi +11 -0
index 96bee776e145..09a0e89bed11 100644
@@ -1183,6 +1183,17 @@
 				function = "ir1";
 			};
 
+			lcd0_rgb888_pins: lcd0_rgb888 at 0 {
+				allwinner,pins = "PD0", "PD1", "PD2", "PD3",
+						 "PD4", "PD5", "PD6", "PD7",
+						 "PD8", "PD9", "PD10", "PD11",
+						 "PD12", "PD13", "PD14", "PD15",
+						 "PD16", "PD17", "PD18", "PD19",
+						 "PD20", "PD21", "PD22", "PD23",
+						 "PD24", "PD25", "PD26", "PD27";
+				allwinner,function = "lcd0";
+			};
+
 			mmc0_pins_a: mmc0 at 0 {
 				pins = "PF0", "PF1", "PF2",
 				       "PF3", "PF4", "PF5";
Signature · 1 line
2.13.1
#1 lore raw
Quoted 17 lines · On Mon, 26 Jun 2017 22:42:49 +1000 Jonathan Liu <[email protected]> wrote:

The LCD0 controller on the A20 can do RGB output up to 8 bits per channel. Add the pins for RGB888 output.

---
 arch/arm/boot/dts/sun7i-a20.dtsi | 11 +++++++++++
 1 file changed, 11 insertions(+)
arch/arm/boot/dts/sun7i-a20.dtsi +1 -0
index 96bee776e145..09a0e89bed11 100644
@@ -1183,6 +1183,17 @@
 				function = "ir1";
 			};
 
+			lcd0_rgb888_pins: lcd0_rgb888 at 0 {

arch/arm/boot/dts/sun7i-a20.dtsi line 1196

Quoted 10 lines
arch/arm/boot/dts/sun7i-a20.dtsi +10 -0
+				allwinner,pins = "PD0", "PD1", "PD2", "PD3",
+						 "PD4", "PD5", "PD6", "PD7",
+						 "PD8", "PD9", "PD10", "PD11",
+						 "PD12", "PD13", "PD14", "PD15",
+						 "PD16", "PD17", "PD18", "PD19",
+						 "PD20", "PD21", "PD22", "PD23",
+						 "PD24", "PD25", "PD26", "PD27";
+				allwinner,function = "lcd0";
+			};
+

We switch to standard pinctrl bindings so you need to use 'pins' and
'function' (i.e. without the 'allwinner,' prefix).

Quoted 11 lines
arch/arm/boot/dts/sun7i-a20.dtsi +0 -0
 			mmc0_pins_a: mmc0 at 0 {
 				pins = "PF0", "PF1", "PF2",
 				       "PF3", "PF4", "PF5";
Signature · 7 lines
2.13.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Signature · 1 line
Emmanuel Vadot <[email protected]> <[email protected]>
#2 lore raw

Hi Emmanuel,

Quoted 19 lines · Emmanuel Vadot
Quoted 16 lines · On Mon, 26 Jun 2017 22:42:49 +1000 Jonathan Liu <[email protected]> wrote:

The LCD0 controller on the A20 can do RGB output up to 8 bits per channel. Add the pins for RGB888 output.

---
 arch/arm/boot/dts/sun7i-a20.dtsi | 11 +++++++++++
 1 file changed, 11 insertions(+)
arch/arm/boot/dts/sun7i-a20.dtsi +0 -0
index 96bee776e145..09a0e89bed11 100644
@@ -1183,6 +1183,17 @@
                              function = "ir1";
                      };
 
Quoted 15 lines

arch/arm/boot/dts/sun7i-a20.dtsi line 1196

Quoted 11 lines
arch/arm/boot/dts/sun7i-a20.dtsi +11 -0
+                     lcd0_rgb888_pins: lcd0_rgb888 at 0 {
+                             allwinner,pins = "PD0", "PD1", "PD2", "PD3",
+                                              "PD4", "PD5", "PD6", "PD7",
+                                              "PD8", "PD9", "PD10", "PD11",
+                                              "PD12", "PD13", "PD14", "PD15",
+                                              "PD16", "PD17", "PD18", "PD19",
+                                              "PD20", "PD21", "PD22", "PD23",
+                                              "PD24", "PD25", "PD26", "PD27";
+                             allwinner,function = "lcd0";
+                     };
+

We switch to standard pinctrl bindings so you need to use 'pins' and
'function' (i.e. without the 'allwinner,' prefix).

Thanks, I will change it for V2.

Quoted 7 lines
Quoted 7 lines
arch/arm/boot/dts/sun7i-a20.dtsi +0 -1
                      mmc0_pins_a: mmc0 at 0 {
                              pins = "PF0", "PF1", "PF2",
                                     "PF3", "PF4", "PF5";
--

2.13.1

Quoted 8 lines
Quoted 4 lines

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

--
Emmanuel Vadot <[email protected]> <[email protected]>

Regards,
Jonathan