Skip to contentSkip to conversation

staging: iio: ad7280a: add spaces around '-'

PATCH In review Reno Farnesi 2 participants 2 messages Jun 25, 2017 – Jun 26, 2017

Subsystems (4)
Staging IIO Analog Devices IIO drivers Staging - industrial io
lore
Share & tools
lore

Reno Farnesi

author
#0 lore raw

PATCH 1/1 staging: iio: ad7280a: add spaces around '-'

Fixes the following checkpatch check to improve readability.

CHECK: spaces preferred around that '-' (ctx:VxV)

Signed-off-by Reno Farnesi <[email protected]>
---
 drivers/staging/iio/adc/ad7280a.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
(quoted diff) +0 -0

b/drivers/staging/iio/adc/ad7280a.c
index d5ab83f0236d..d79e7746d351 100644

drivers/staging/iio/adc/ad7280a.c +0 -0
@@ -745,14 +745,14 @@ static irqreturn_t ad7280_event_handler(int irq,

void *private)
}

static IIO_DEVICE_ATTR_NAMED(in_thresh_low_value,
- in_voltage-voltage_thresh_low_value,
+ in_voltage - voltage_thresh_low_value,
0644, ad7280_read_channel_config, ad7280_write_channel_config, AD7280A_CELL_UNDERVOLTAGE);

static IIO_DEVICE_ATTR_NAMED(in_thresh_high_value,
- in_voltage-voltage_thresh_high_value,
+ in_voltage - voltage_thresh_high_value,
0644, ad7280_read_channel_config, ad7280_write_channel_config,

Signature · 1 line
2.13.1
maintainer
#1 lore raw
Quoted 5 lines · On Sun, 25 Jun 2017 15:15:47 -0400 Reno Farnesi <[email protected]> wrote:

Fixes the following checkpatch check to improve readability.

CHECK: spaces preferred around that '-' (ctx:VxV)

Signed-off-by Reno Farnesi <[email protected]>

False positive. Not everything is what it seems ;)

Check what the macro does with that parameter...

Jonathan

Quoted 27 lines
---
 drivers/staging/iio/adc/ad7280a.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/iio/adc/ad7280a.c +2 -2
index d5ab83f0236d..d79e7746d351 100644
@@ -745,14 +745,14 @@ static irqreturn_t ad7280_event_handler(int irq,
 void *private)
 }
 
 static IIO_DEVICE_ATTR_NAMED(in_thresh_low_value,
-		in_voltage-voltage_thresh_low_value,
+		in_voltage - voltage_thresh_low_value,
 		0644,
 		ad7280_read_channel_config,
 		ad7280_write_channel_config,
 		AD7280A_CELL_UNDERVOLTAGE);
 
 static IIO_DEVICE_ATTR_NAMED(in_thresh_high_value,
-		in_voltage-voltage_thresh_high_value,
+		in_voltage - voltage_thresh_high_value,
 		0644,
 		ad7280_read_channel_config,

ad7280_write_channel_config,