Skip to contentSkip to conversation

ath9k: remove useless variable assignment in ath_mci_intr()

PATCH In review Gustavo A. R. Silva 2 participants 2 messages Jun 26, 2017 – Jun 28, 2017

Subsystems (3)
Networking Network drivers Qualcomm Atheros ATH9K wireless driver
lore
Share & tools
lore

Gustavo A. R. Silva

author
#0 lore raw

PATCH 1/1 ath9k: remove useless variable assignment in ath_mci_intr()

Value assigned to variable offset at line 551 is overwritten at line 562, before it can be used. This makes such variable assignment useless.

Addresses-Coverity-ID: 1226941

Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 drivers/net/wireless/ath/ath9k/mci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/ath/ath9k/mci.c +1 -1
index 66596b9..cf23fd8 100644
@@ -548,7 +548,7 @@ void ath_mci_intr(struct ath_softc *sc)
 
 	if (mci_int_rxmsg & AR_MCI_INTERRUPT_RX_MSG_SCHD_INFO) {
 		mci_int_rxmsg &= ~AR_MCI_INTERRUPT_RX_MSG_SCHD_INFO;
-		offset = ar9003_mci_state(ah, MCI_STATE_LAST_SCHD_MSG_OFFSET);
+		ar9003_mci_state(ah, MCI_STATE_LAST_SCHD_MSG_OFFSET);
 	}
 
 	if (mci_int_rxmsg & AR_MCI_INTERRUPT_RX_MSG_GPM) {
Signature · 1 line
2.5.0
#1 lore raw
Quoted 6 lines · Gustavo A. R. Silva

Value assigned to variable offset at line 551 is overwritten at line 562, before it can be used. This makes such variable assignment useless.

Addresses-Coverity-ID: 1226941

Signed-off-by Gustavo A. R. Silva <garsilva-L1vi/[email protected]>
Signed-off-by Kalle Valo <[email protected]>

Patch applied to ath-next branch of ath.git, thanks.

6788a3832c70 ath9k: remove useless variable assignment in ath_mci_intr()

Signature · 3 lines
https://patchwork.kernel.org/patch/9810609/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches