Skip to contentSkip to conversation

usb: gadget: udc-xilinx: remove useless variable assignment in xudc_read_fifo()

PATCH In review Gustavo A. R. Silva 2 participants 2 messages Jun 27, 2017

Subsystems (2)
USB Arm/Zynq architecture
lore
Share & tools
lore

Gustavo A. R. Silva

author
#0 lore raw

PATCH 1/1 usb: gadget: udc-xilinx: remove useless variable assignment in xudc_read_fifo()

Value assigned to variable bufferspace at line 637 is overwritten at line 613, before it can be used. This makes such variable assignment useless.

Addresses-Coverity-ID: 1397677

Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 drivers/usb/gadget/udc/udc-xilinx.c | 1 -
 1 file changed, 1 deletion(-)
drivers/usb/gadget/udc/udc-xilinx.c +0 -1
index de207a9..7afdf8e 100644
@@ -634,7 +634,6 @@ static int xudc_read_fifo(struct xusb_ep *ep, struct xusb_req *req)
 		dev_dbg(udc->dev, "read %s, %d bytes%s req %p %d/%d\n",
 			ep->ep_usb.name, count, is_short ? "/S" : "", req,
 			req->usb_req.actual, req->usb_req.length);
-		bufferspace -= count;
 		/* Completion */
 		if ((req->usb_req.actual == req->usb_req.length) || is_short) {
 			if (udc->dma_enabled && req->usb_req.length)
Signature · 1 line
2.5.0