Skip to contentSkip to conversation

media: platform: rcar_imr: add IMR-LSX3 support

PATCH In review Sergei Shtylyov 3 participants 3 messages Jun 28, 2017 – Jun 30, 2017

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 media: platform: rcar_imr: add IMR-LSX3 support

Add support for the image renderer light SRAM extended 3 (IMR-LSX3) found only in the R-Car V2H (R8A7792) SoC. It differs from IMR-LX4 in that it supports only planar video formats but can use the video capture data for the textures.

---
This patch is against the 'media_tree.git' repo's 'master' branch plus the latest version of the Renesas IMR driver...

Changes in version 3:
- fixed compilation errors, resolved rejects, refreshed the patch atop of the IMR driver patch (version 6).

Changes in version 2:
- renamed *enum* 'imr_gen' to 'imr_type' and the *struct* field of this type from 'gen' to 'type';
- rename *struct* 'imr_type' to 'imr_info' and the fields/variables of this type from 'type' to 'info';
- added comments to IMR-LX4 only CMRCR2 bits;
- added IMR type check to the WTS instruction writing to CMRCCR2.

 Documentation/devicetree/bindings/media/rcar_imr.txt |   11 +-
 drivers/media/platform/rcar_imr.c                    |  101 +++++++++++++++----
 2 files changed, 92 insertions(+), 20 deletions(-)
Documentation/devicetree/bindings/media/rcar_imr.txt +8 -3
Index: media_tree/Documentation/devicetree/bindings/media/rcar_imr.txt
===================================================================
@@ -8,9 +8,14 @@ and drawing with respect to any shape th
 
 Required properties:
 
-- compatible: "renesas,<soctype>-imr-lx4", "renesas,imr-lx4" as a fallback for
-  the image renderer light extended 4 (IMR-LX4) found in the R-Car gen3 SoCs,
-  where the examples with <soctype> are:
+- compatible:
+  "renesas,<soctype>-imr-lsx3", "renesas,imr-lsx3" as a fallback for the image
+  renderer light SRAM extended 3 (IMR-LSX3) found in the R-Car gen2 SoCs, where
+  the examples with <soctype> are:
+  - "renesas,r8a7792-imr-lsx3" for R-Car V2H;
+  "renesas,<soctype>-imr-lx4", "renesas,imr-lx4" as a fallback for the image
+  renderer light extended 4 (IMR-LX4) found in the R-Car gen3 SoCs, where the
+  examples with <soctype> are:
   - "renesas,r8a7795-imr-lx4" for R-Car H3,
   - "renesas,r8a7796-imr-lx4" for R-Car M3-W.
 - reg: offset and length of the register block;
drivers/media/platform/rcar_imr.c +84 -17

224 lines not on this page · raw message

maintainer
#1 lore raw
Quoted 23 lines · Sergei Shtylyov

Add support for the image renderer light SRAM extended 3 (IMR-LSX3) found only in the R-Car V2H (R8A7792) SoC. It differs from IMR-LX4 in that it supports only planar video formats but can use the video capture data for the textures.

---
This patch is against the 'media_tree.git' repo's 'master' branch plus the latest version of the Renesas IMR driver...

Changes in version 3:
- fixed compilation errors, resolved rejects, refreshed the patch atop of the IMR driver patch (version 6).

Changes in version 2:
- renamed *enum* 'imr_gen' to 'imr_type' and the *struct* field of this type from 'gen' to 'type';
- rename *struct* 'imr_type' to 'imr_info' and the fields/variables of this type from 'type' to 'info';
- added comments to IMR-LX4 only CMRCR2 bits;
- added IMR type check to the WTS instruction writing to CMRCCR2.

Quoted 1 line
 Documentation/devicetree/bindings/media/rcar_imr.txt |   11 +-

You missed my ack on v2.

Quoted 2 lines
 drivers/media/platform/rcar_imr.c                    |  101 +++++++++++++++----
 2 files changed, 92 insertions(+), 20 deletions(-)
#2 lore raw
Quoted 23 lines · Rob Herring
Quoted 23 lines

Add support for the image renderer light SRAM extended 3 (IMR-LSX3) found only in the R-Car V2H (R8A7792) SoC. It differs from IMR-LX4 in that it supports only planar video formats but can use the video capture data for the textures.

---
This patch is against the 'media_tree.git' repo's 'master' branch plus the latest version of the Renesas IMR driver...

Changes in version 3:
- fixed compilation errors, resolved rejects, refreshed the patch atop of the IMR driver patch (version 6).

Changes in version 2:
- renamed *enum* 'imr_gen' to 'imr_type' and the *struct* field of this type from 'gen' to 'type';
- rename *struct* 'imr_type' to 'imr_info' and the fields/variables of this type from 'type' to 'info';
- added comments to IMR-LX4 only CMRCR2 bits;
- added IMR type check to the WTS instruction writing to CMRCCR2.

Quoted 3 lines
Quoted 1 line
 Documentation/devicetree/bindings/media/rcar_imr.txt |   11 +-

You missed my ack on v2.

Sorry again, realized that just after posting v3.

Quoted 2 lines
Quoted 2 lines
 drivers/media/platform/rcar_imr.c                    |  101 +++++++++++++++----
 2 files changed, 92 insertions(+), 20 deletions(-)

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html