drm/i915/cnl: Fix the CURSOR_COEFF_MASK used in DDI Vswing Programming
Subsystems (2)
PATCH 1/1 drm/i915/cnl: Fix the CURSOR_COEFF_MASK used in DDI Vswing Programming
The Cursor Coeff is lower 6 bits in the PORT_TX_DW4 register and hence the CURSOR_COEFF_MASK should be (0x3F << 0)
--- drivers/gpu/drm/i915/i915_reg.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_reg.h +1 -1
@@ -1802,7 +1802,7 @@ enum skl_disp_power_wells {#define POST_CURSOR_2 (x) ((x) << 6)#define POST_CURSOR_2_MASK (0x3F << 6)#define CURSOR_COEFF (x) ((x) << 0) -#define CURSOR_COEFF_MASK (0x3F << 6) +#define CURSOR_COEFF_MASK (0x3F << 0)#define _CNL_PORT_TX_DW5_GRP_AE 0x162354#define _CNL_PORT_TX_DW5_GRP_B 0x1623D4
Signature · 6 lines
2.1.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915/cnl: Fix the CURSOR_COEFF_MASK used in DDI Vswing Programming
== Series Details ==
== Series Details ==
Series: drm/i915/cnl: Fix the CURSOR_COEFF_MASK used in DDI Vswing Programming
URL : https://patchwork.freedesktop.org/series/26588/
State : success
== Summary ==
Series 26588v1 drm/i915/cnl: Fix the CURSOR_COEFF_MASK used in DDI Vswing Programming
https://patchwork.freedesktop.org/api/1.0/series/26588/revisions/1/mbox/
Test gem_exec_suspend:
Subgroup basic-s4-devices:
dmesg-warn -> PASS (fi-kbl-7560u) fdo#100125
Test kms_cursor_legacy:
Subgroup basic-busy-flip-before-cursor-legacy:
pass -> FAIL (fi-snb-2600) fdo#100215
Test kms_pipe_crc_basic:
Subgroup hang-read-crc-pipe-a:
pass -> DMESG-WARN (fi-pnv-d510) fdo#101597fdo#100125 https://bugs.freedesktop.org/show_bug.cgi?id=100125
fdo#100215 https://bugs.freedesktop.org/show_bug.cgi?id=100215
fdo#101597 https://bugs.freedesktop.org/show_bug.cgi?id=101597
fi-bdw-5557u total:279 pass:264 dwarn:4 dfail:0 fail:0 skip:11 time:441s fi-bdw-gvtdvm total:279 pass:257 dwarn:8 dfail:0 fail:0 skip:14 time:429s fi-blb-e6850 total:279 pass:224 dwarn:1 dfail:0 fail:0 skip:54 time:361s fi-bsw-n3050 total:279 pass:243 dwarn:0 dfail:0 fail:0 skip:36 time:525s fi-bxt-j4205 total:279 pass:260 dwarn:0 dfail:0 fail:0 skip:19 time:507s fi-byt-j1900 total:279 pass:254 dwarn:1 dfail:0 fail:0 skip:24 time:483s fi-glk-2a total:279 pass:260 dwarn:0 dfail:0 fail:0 skip:19 time:595s fi-hsw-4770 total:279 pass:259 dwarn:4 dfail:0 fail:0 skip:16 time:434s fi-hsw-4770r total:279 pass:259 dwarn:4 dfail:0 fail:0 skip:16 time:410s fi-ilk-650 total:279 pass:229 dwarn:0 dfail:0 fail:0 skip:50 time:412s fi-ivb-3520m total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:499s fi-ivb-3770 total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:472s fi-kbl-7500u total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:467s fi-kbl-7560u total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:566s fi-kbl-r total:279 pass:260 dwarn:1 dfail:0 fail:0 skip:18 time:586s fi-pnv-d510 total:279 pass:222 dwarn:2 dfail:0 fail:0 skip:55 time:557s fi-skl-6260u total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:454s fi-skl-6700hq total:279 pass:223 dwarn:1 dfail:0 fail:30 skip:24 time:342s fi-skl-6700k total:279 pass:257 dwarn:4 dfail:0 fail:0 skip:18 time:468s fi-skl-6770hq total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:474s fi-skl-gvtdvm total:279 pass:266 dwarn:0 dfail:0 fail:0 skip:13 time:437s fi-snb-2520m total:279 pass:251 dwarn:0 dfail:0 fail:0 skip:28 time:547s fi-snb-2600 total:279 pass:249 dwarn:0 dfail:0 fail:1 skip:29 time:402s
1da9a6d8d2402de8798b36d75bdd7d8b49728a5e drm-tip: 2017y-06m-29d-20h-16m-45s UTC integration manifest e7686b0 drm/i915/cnl: Fix the CURSOR_COEFF_MASK used in DDI Vswing Programming
== Logs ==
For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_5077/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
the patch that introduces this error didn't land yet....
so, could we squash to the original patch whenever that is reworked to be resent?
Quoted 29 lines · Manasi Navare
The Cursor Coeff is lower 6 bits in the
PORT_TX_DW4register and hence theCURSOR_COEFF_MASKshould be (0x3F<< 0)Signed-off-by Manasi Navare <[email protected]>Cc Rodrigo Vivi <[email protected]>--- drivers/gpu/drm/i915/i915_reg.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/i915/i915_reg.h +1
-2@@ -1802,7 +1802,7 @@ enum skl_disp_power_wells {#define POST_CURSOR_2 (x) ((x) << 6)#define POST_CURSOR_2_MASK (0x3F << 6)#define CURSOR_COEFF (x) ((x) << 0) -#define CURSOR_COEFF_MASK (0x3F << 6) +#define CURSOR_COEFF_MASK (0x3F << 0)#define _CNL_PORT_TX_DW5_GRP_AE 0x162354#define _CNL_PORT_TX_DW5_GRP_B 0x1623D4 --2.1.4
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 6 lines
Rodrigo Vivi Blog: http://blog.vivi.eng.br _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Rodrigo Vivi
Reviewed-byOh! nevermind, please fully ignore my last email!
swing sequences.")
Quoted 43 lines · Rodrigo Vivi
the patch that introduces this error didn't land yet....
so, could we squash to the original patch whenever that is reworked to be resent?
Quoted 25 lines · Manasi Navare
The Cursor Coeff is lower 6 bits in the
PORT_TX_DW4register and hence theCURSOR_COEFF_MASKshould be (0x3F<< 0)Signed-off-by Manasi Navare <[email protected]>Cc Rodrigo Vivi <[email protected]>--- drivers/gpu/drm/i915/i915_reg.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/i915/i915_reg.h +1
-2@@ -1802,7 +1802,7 @@ enum skl_disp_power_wells {#define POST_CURSOR_2 (x) ((x) << 6)#define POST_CURSOR_2_MASK (0x3F << 6)#define CURSOR_COEFF (x) ((x) << 0) -#define CURSOR_COEFF_MASK (0x3F << 6) +#define CURSOR_COEFF_MASK (0x3F << 0)#define _CNL_PORT_TX_DW5_GRP_AE 0x162354#define _CNL_PORT_TX_DW5_GRP_B 0x1623D4 --2.1.4
Quoted 4 lines
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx--
Rodrigo Vivi
Blog: http://blog.vivi.eng.br
Signature · 6 lines
Rodrigo Vivi Blog: http://blog.vivi.eng.br _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Vivi, Rodrigo
maintainerPatch merged to dinq.
With the proper "Fixes:".
Thanks,
Rodrigo.
Quoted 53 lines · Rodrigo Vivi
Oh! nevermind, please fully ignore my last email!
Fixes 04416108ccea ("drm/i915/cnl: Add registers related to voltageswing sequences.")
Reviewed-by Rodrigo Vivi <[email protected]>Quoted 43 lines · Rodrigo Vivi
the patch that introduces this error didn't land yet....
so, could we squash to the original patch whenever that is reworked to be resent?
Quoted 25 lines · Manasi Navare
The Cursor Coeff is lower 6 bits in the
PORT_TX_DW4register and hence theCURSOR_COEFF_MASKshould be (0x3F<< 0)Signed-off-by Manasi Navare <[email protected]>Cc Rodrigo Vivi <[email protected]>--- drivers/gpu/drm/i915/i915_reg.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/i915/i915_reg.h +1
-2@@ -1802,7 +1802,7 @@ enum skl_disp_power_wells {#define POST_CURSOR_2 (x) ((x) << 6)#define POST_CURSOR_2_MASK (0x3F << 6)#define CURSOR_COEFF (x) ((x) << 0) -#define CURSOR_COEFF_MASK (0x3F << 6) +#define CURSOR_COEFF_MASK (0x3F << 0)#define _CNL_PORT_TX_DW5_GRP_AE 0x162354#define _CNL_PORT_TX_DW5_GRP_B 0x1623D4 --2.1.4
Quoted 4 lines
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx--
Rodrigo Vivi
Blog: http://blog.vivi.eng.br
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx