Skip to contentSkip to conversation

crypto: ccp-platform: print error message on platform_get_irq failure

PATCH In review Gustavo A. R. Silva 3 participants 3 messages Jun 30, 2017 – Jul 18, 2017

Subsystems (2)
Crypto API AMD cryptographic coprocessor (CCP) driver
lore
Share & tools
lore

Gustavo A. R. Silva

author
#0 lore raw

PATCH 1/1 crypto: ccp-platform: print error message on platform_get_irq failure

Print error message on platform_get_irq failure before return.

Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 drivers/crypto/ccp/ccp-platform.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/crypto/ccp/ccp-platform.c +3 -1
index e26969e..6020c4a 100644
@@ -66,8 +66,10 @@ static int ccp_get_irq(struct ccp_device *ccp)
 	int ret;
 
 	ret = platform_get_irq(pdev, 0);
-	if (ret < 0)
+	if (ret < 0) {
+		dev_notice(dev, "unable to get IRQ (%d)\n", ret);
 		return ret;
+	}
 
 	ccp->irq = ret;
 	ret = request_irq(ccp->irq, ccp->vdata->perform->irqhandler, 0,
Signature · 1 line
2.5.0
#1 lore raw
Quoted 13 lines · Gustavo A. R. Silva

Print error message on platform_get_irq failure before return.

Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 drivers/crypto/ccp/ccp-platform.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/crypto/ccp/ccp-platform.c +0 -0
index e26969e..6020c4a 100644

drivers/crypto/ccp/ccp-platform.c static int ccp_get_irq(struct ccp_device *ccp) · line 72

Quoted 8 lines
drivers/crypto/ccp/ccp-platform.c +3 -1
@@ -66,8 +66,10 @@ static int ccp_get_irq(struct ccp_device *ccp)
         int ret;
 
         ret = platform_get_irq(pdev, 0);
-       if (ret < 0)
+       if (ret < 0) {
+               dev_notice(dev, "unable to get IRQ (%d)\n", ret);
                 return ret;
+       }

Good find.

I'm all for better and more messages, but I'd like to see more detail here, and in the later dev_notice(). Can we have the messages better reflect the failure points?

Quoted 6 lines
drivers/crypto/ccp/ccp-platform.c +0 -1
         ccp->irq = ret;
         ret = request_irq(ccp->irq, ccp->vdata->perform->irqhandler, 0,
--

2.5.0