Skip to contentSkip to conversation

dmaengine: zynqmp_dma: fix error return code in zynqmp_dma_chan_probe()

PATCH In review Gustavo A. R. Silva 2 participants 2 messages Jun 30, 2017

Subsystems (2)
Arm/Zynq architecture dmaengine
lore
Share & tools
lore

Gustavo A. R. Silva

author
#0 lore raw

PATCH 1/1 dmaengine: zynqmp_dma: fix error return code in zynqmp_dma_chan_probe()

Print error message and propagate the return value of platform_get_irq on failure.

Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 drivers/dma/xilinx/zynqmp_dma.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/dma/xilinx/zynqmp_dma.c +5 -2
index 6d221e5..5fa6d0d 100644
@@ -996,8 +996,11 @@ static int zynqmp_dma_chan_probe(struct zynqmp_dma_device *zdev,
 
 	zynqmp_dma_init(chan);
 	chan->irq = platform_get_irq(pdev, 0);
-	if (chan->irq < 0)
-		return -ENXIO;
+	if (chan->irq < 0) {
+		dev_err(&pdev->dev, "failed to get IRQ: %d\n", chan->irq);
+		return chan->irq;
+	}
+
 	err = devm_request_irq(&pdev->dev, chan->irq, zynqmp_dma_irq_handler, 0,
 			       "zynqmp-dma", chan);
 	if (err)
Signature · 1 line
2.5.0