Skip to contentSkip to conversation

ASoC: imx-ssi: add check on platform_get_irq return value

PATCH In review Gustavo A. R. Silva 3 participants 3 messages Jun 30, 2017 – Jul 7, 2017

Subsystems (4)
Sound Arm i.MX and Layerscape ASoC Freescale SoC sound drivers
lore
Share & tools
lore

Gustavo A. R. Silva

author
#0 lore raw

PATCH 1/1 ASoC: imx-ssi: add check on platform_get_irq return value

Check return value from call to platform_get_irq(), so in case of failure print error message and propagate the return value.

Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 sound/soc/fsl/imx-ssi.c | 4 ++++
 1 file changed, 4 insertions(+)
sound/soc/fsl/imx-ssi.c +4 -0
index b95132e..0679061 100644
@@ -527,6 +527,10 @@ static int imx_ssi_probe(struct platform_device *pdev)
 	}
 
 	ssi->irq = platform_get_irq(pdev, 0);
+	if (ssi->irq < 0) {
+		dev_err(&pdev->dev, "Failed to get IRQ: %d\n", ssi->irq);
+		return ssi->irq;
+	}
 
 	ssi->clk = devm_clk_get(&pdev->dev, NULL);
 	if (IS_ERR(ssi->clk)) {
Signature · 1 line
2.5.0
reviewer Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Gustavo A. R. Silva

Check return value from call to platform_get_irq(), so in case of failure print error message and propagate the return value.

Signed-off-by Gustavo A. R. Silva <[email protected]>
Acked-by Nicolin Chen <[email protected]>

Thanks

Quoted 22 lines
---
 sound/soc/fsl/imx-ssi.c | 4 ++++
 1 file changed, 4 insertions(+)
sound/soc/fsl/imx-ssi.c +4 -0
index b95132e..0679061 100644
@@ -527,6 +527,10 @@ static int imx_ssi_probe(struct platform_device *pdev)
 	}
 
 	ssi->irq = platform_get_irq(pdev, 0);
+	if (ssi->irq < 0) {
+		dev_err(&pdev->dev, "Failed to get IRQ: %d\n", ssi->irq);
+		return ssi->irq;
+	}
 
 	ssi->clk = devm_clk_get(&pdev->dev, NULL);
 	if (IS_ERR(ssi->clk)) {
Signature · 1 line
2.5.0
maintainer
#2 lore raw

Applied "ASoC: imx-ssi: add check on platform_get_irq return value" to the asoc tree

In reply to Gustavo A. R. Silva

The patch

ASoC: imx-ssi: add check on platform_get_irq return value

has been applied to the asoc tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From ae1fbdff6dbcdfee9daee69fa1e7d26d1f31d1c7 Mon Sep 17 00:00:00 2001

From: "Gustavo A. R. Silva" <[email protected]>
Date: Fri, 30 Jun 2017 17:17:35 -0500
Subject: [PATCH] ASoC: imx-ssi: add check on platform_get_irq return value

Check return value from call to platform_get_irq(), so in case of failure print error message and propagate the return value.

Signed-off-by Gustavo A. R. Silva <[email protected]>
Acked-by Nicolin Chen <[email protected]>
Signed-off-by Mark Brown <[email protected]>
---
 sound/soc/fsl/imx-ssi.c | 4 ++++
 1 file changed, 4 insertions(+)
sound/soc/fsl/imx-ssi.c +4 -0
index b95132e2f9dc..06790615e04e 100644
@@ -527,6 +527,10 @@ static int imx_ssi_probe(struct platform_device *pdev)
 	}
 
 	ssi->irq = platform_get_irq(pdev, 0);
+	if (ssi->irq < 0) {
+		dev_err(&pdev->dev, "Failed to get IRQ: %d\n", ssi->irq);
+		return ssi->irq;
+	}
 
 	ssi->clk = devm_clk_get(&pdev->dev, NULL);
 	if (IS_ERR(ssi->clk)) {
Signature · 1 line
2.13.2