ALSA: atmel: ac97c: fix error return code in atmel_ac97c_probe()
Subsystems (2)
PATCH 1/1 ALSA: atmel: ac97c: fix error return code in atmel_ac97c_probe()
platform_get_irq() returns an error code, but the ac97c driver ignores it and always returns -ENXIO. This is not correct, and prevents -EPROBE_DEFER from being propagated properly. Notice that platform_get_irq() no longer returns 0 on error.
Print and propagate the return value of platform_get_irq on failure.
Signed-off-by Gustavo A. R. Silva <[email protected]>
--- sound/atmel/ac97c.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
sound/atmel/ac97c.c +2 -2
@@ -774,8 +774,8 @@ static int atmel_ac97c_probe(struct platform_device *pdev) irq =platform_get_irq (pdev,0 );if (irq <0 ) { -dev_dbg (&pdev->dev,"could not get irq\n" ); -return -ENXIO ; +dev_dbg (&pdev->dev,"could not get irq: %d\n" , irq); +return irq; } pclk =clk_get (&pdev->dev,"ac97_clk" );
Signature · 1 line
2.5.0
Takashi Iwai
AppliedQuoted 9 lines · Gustavo A. R. Silva
platform_get_irq()returns an error code, but the ac97c driver ignores it and always returns-ENXIO. This is not correct, and prevents -EPROBE_DEFER from being propagated properly. Notice thatplatform_get_irq()no longer returns 0 on error.Print and propagate the return value of
platform_get_irqon failure.Signed-off-by Gustavo A. R. Silva <[email protected]>
Applied, thanks.
Takashi