Skip to contentSkip to conversation

Modified imx7d-sdb.dts file so that VLDO4 provides 2.8V for MIPI CSI/DSI

PATCH In review mindentropy 3 participants 5 messages Jun 28, 2017 – Jul 12, 2017

Subsystems (2)
Device tree bindings Arm i.MX and Layerscape
lore
Share & tools
lore

mindentropy

author
#0 lore raw

PATCH 1/1 Modified imx7d-sdb.dts file so that VLDO4 provides 2.8V for MIPI CSI/DSI

From: Gautam Bhat <[email protected]>

* According to mx7sabresd schematics the MIPI CSI/DSI voltage rails should be 2.8V but the voltage provided is a maximum of 3.3V and minimum of 1.8V. Providing such a higher voltage might damage the peripherals and violates the schematic settings.

Signed-off-by Gautam Bhat <[email protected]>
---
 arch/arm/boot/dts/imx7d-sdb.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/imx7d-sdb.dts +2 -2
index 5be01a1bf840..1da1f97ec342 100644
@@ -262,8 +262,8 @@
 			};
 
 			vgen6_reg: vldo4 {
-				regulator-min-microvolt = <1800000>;
-				regulator-max-microvolt = <3300000>;
+				regulator-min-microvolt = <2800000>;
+				regulator-max-microvolt = <2800000>;
 				regulator-always-on;
 			};
 		};
Signature · 1 line
2.11.0
reviewer
#1 lore raw

Hi Gautam,

Quoted 8 lines · mindentropy

From: Gautam Bhat <[email protected]>

* According to mx7sabresd schematics the MIPI CSI/DSI voltage rails should be 2.8V but the voltage provided is a maximum of 3.3V and minimum of 1.8V. Providing such a higher voltage might damage the peripherals and violates the schematic settings.

Signed-off-by Gautam Bhat <[email protected]>

Patch looks good, but the Subject could be improved to something like:

ARM: dts: imx7d-sdb: Set LDO4 to 2.8V

author
#2 lore raw

PATCH v2 1/1 ARM: dts: imx7d-sdb: Set VLDO4 outpt to 2.8V for MIPI CSI/DSI

From: Gautam Bhat <[email protected]>

* According to mx7sabresd schematics the MIPI CSI/DSI voltage rails should be 2.8V but the voltage provided is a maximum of 3.3V and minimum of 1.8V. Providing such a higher voltage might damage the peripherals and violates the schematic settings.

Signed-off-by Gautam Bhat <[email protected]>

---
Changes in v2:
- Added subject line according to convention

 arch/arm/boot/dts/imx7d-sdb.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/imx7d-sdb.dts +2 -2
index 5be01a1bf840..1da1f97ec342 100644
@@ -262,8 +262,8 @@
 			};
 
 			vgen6_reg: vldo4 {
-				regulator-min-microvolt = <1800000>;
-				regulator-max-microvolt = <3300000>;
+				regulator-min-microvolt = <2800000>;
+				regulator-max-microvolt = <2800000>;
 				regulator-always-on;
 			};
 		};
Signature · 1 line
2.11.0
reviewer Reviewed-by on v2 1/1
#3 lore raw

Re: [PATCH v2] ARM: dts: imx7d-sdb: Set VLDO4 outpt to 2.8V for MIPI CSI/DSI

Quoted 8 lines · mindentropy

From: Gautam Bhat <[email protected]>

* According to mx7sabresd schematics the MIPI CSI/DSI voltage rails should be 2.8V but the voltage provided is a maximum of 3.3V and minimum of 1.8V. Providing such a higher voltage might damage the peripherals and violates the schematic settings.

Signed-off-by Gautam Bhat <[email protected]>
Reviewed-by Fabio Estevam <[email protected]>
#4 lore raw

Re: [PATCH v2] ARM: dts: imx7d-sdb: Set VLDO4 outpt to 2.8V for MIPI CSI/DSI

In reply to mindentropy
Quoted 6 lines · mindentropy

From: Gautam Bhat <[email protected]>

* According to mx7sabresd schematics the MIPI CSI/DSI voltage rails should be 2.8V but the voltage provided is a maximum of 3.3V and minimum of 1.8V. Providing such a higher voltage might damage the peripherals and violates the schematic settings.

For such single paragraph commit log, the bullet and indentation are not really necessary. I edited it a bit and apply the patch. Thanks.

Shawn

Quoted 27 lines
Signed-off-by Gautam Bhat <[email protected]>

---
Changes in v2:
- Added subject line according to convention

 arch/arm/boot/dts/imx7d-sdb.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/imx7d-sdb.dts +2 -2
index 5be01a1bf840..1da1f97ec342 100644
@@ -262,8 +262,8 @@
 			};
 
 			vgen6_reg: vldo4 {
-				regulator-min-microvolt = <1800000>;
-				regulator-max-microvolt = <3300000>;
+				regulator-min-microvolt = <2800000>;
+				regulator-max-microvolt = <2800000>;
 				regulator-always-on;
 			};
 		};
Signature · 1 line
2.11.0