Skip to contentSkip to conversation

nodm: uClibc wordexp support is enabled by default

PATCH New Waldemar Brodkorb 3 participants 3 messages Jun 27, 2017 – Jul 2, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nodm: uClibc wordexp support is enabled by default

Build tested with Qemu X86 sample.

---
 package/nodm/Config.in | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
package/nodm/Config.in +2 -4
index 97ce8c3..38171e8 100644
@@ -4,7 +4,6 @@ config BR2_PACKAGE_NODM
 	depends on (BR2_ENABLE_LOCALE && BR2_USE_WCHAR) # linux-pam
 	depends on !BR2_STATIC_LIBS # linux-pam
 	depends on !BR2_TOOLCHAIN_USES_MUSL # linux-pam
-	depends on !BR2_TOOLCHAIN_USES_UCLIBC # needs wordexp.h
 	depends on BR2_USE_MMU # linux-pam
 	select BR2_PACKAGE_XLIB_LIBX11
 	select BR2_PACKAGE_LINUX_PAM
@@ -19,8 +18,7 @@ config BR2_PACKAGE_NODM
 
 	  https://github.com/spanezz/nodm/
 
-comment "nodm needs a glibc toolchain w/ wchar, locale, dynamic library"
+comment "nodm needs a glibc or uClibc toolchain w/ wchar, locale, dynamic library"
 	depends on BR2_PACKAGE_XORG7
 	depends on !(BR2_ENABLE_LOCALE && BR2_USE_WCHAR) \
-		|| BR2_STATIC_LIBS || BR2_TOOLCHAIN_USES_MUSL \
-		|| BR2_TOOLCHAIN_USES_UCLIBC
+		|| BR2_STATIC_LIBS || BR2_TOOLCHAIN_USES_MUSL
Signature · 1 line
2.1.4
#1 lore raw

PATCH 1/1 nodm: uClibc wordexp support is enabled by default

Hello,

Quoted 6 lines · Waldemar Brodkorb

Build tested with Qemu X86 sample.

---
 package/nodm/Config.in | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Applied to master, thanks. The minnowboard_max-graphical_defconfig was using glibc until now, I guess mainly because of the nodm package not being available with uClibc. Now that nodm is available with uClibc, perhaps the minnowboard_max-graphical_defconfig can be changed to use uClibc ?

Ezequiel ?

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 nodm: uClibc wordexp support is enabled by default

Quoted 10 lines · Thomas Petazzoni

Hello,

Quoted 6 lines · Waldemar Brodkorb

Build tested with Qemu X86 sample.

---
 package/nodm/Config.in | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
Quoted 8 lines

Applied to master, thanks. The minnowboard_max-graphical_defconfig was using glibc until now, I guess mainly because of the nodm package not being available with uClibc. Now that nodm is available with uClibc, perhaps the minnowboard_max-graphical_defconfig can be changed to use uClibc ?

Ezequiel ?

It's been a while. To be honest, I don't remember the reasons for glibc. It could be more than just because of nodm, methinks.

Will test and send a patch if we get lucky.

Signature · 2 lines
Ezequiel Garc?a, VanguardiaSur
www.vanguardiasur.com.ar