Skip to contentSkip to conversation

platform/x86: silead_dmi: Add touchscreen info for I.T.Works TW891 2-in-1

PATCH In review Hans de Goede 2 participants 3 messages Jul 1, 2017 – Jul 7, 2017 x86 platform drivers

lore
Share & tools
lore

Hans de Goede

author
#0 lore raw

PATCH 1/1 platform/x86: silead_dmi: Add touchscreen info for I.T.Works TW891 2-in-1

Add touchscreen info for I.T.Works TW891 2-in-1.

Signed-off-by Hans de Goede <[email protected]>
---
 drivers/platform/x86/silead_dmi.c | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
drivers/platform/x86/silead_dmi.c +22 -0
index 25cbea307a5e..6218deb22319 100644
@@ -122,6 +122,20 @@ static const struct silead_ts_dmi_data pipo_w2s_data = {
 	.properties	= pipo_w2s_props,
 };
 
+static const struct property_entry itworks_tw891_props[] = {
+	PROPERTY_ENTRY_U32("touchscreen-size-x", 1600),
+	PROPERTY_ENTRY_U32("touchscreen-size-y", 890),
+	PROPERTY_ENTRY_BOOL("touchscreen-inverted-y"),
+	PROPERTY_ENTRY_BOOL("touchscreen-swapped-x-y"),
+	PROPERTY_ENTRY_STRING("firmware-name", "gsl3670-itworks-tw891.fw"),
+	{ }
+};
+
+static const struct silead_ts_dmi_data itworks_tw891_data = {
+	.acpi_name	= "MSSL1680:00",
+	.properties	= itworks_tw891_props,
+};
+
 static const struct dmi_system_id silead_ts_dmi_table[] = {
 	{
 		/* CUBE iwork8 Air */

@@ -187,6 +201,14 @@ static const struct dmi_system_id silead_ts_dmi_table[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "W2S"),
 		},
 	},
+	{
+		/* I.T.Works TW891 */
+		.driver_data = (void *)&itworks_tw891_data,
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "To be filled by O.E.M."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "TW891"),
+		},
+	},
 	{ },
 };
Signature · 1 line
2.13.0
#1 lore raw
Quoted 2 lines · Hans de Goede

Add touchscreen info for I.T.Works TW891 2-in-1.

...

drivers/platform/x86/silead_dmi.c static const struct dmi_system_id silead_ts_dmi_table[] = { · line 208

Quoted 4 lines
drivers/platform/x86/silead_dmi.c +4 -0
+		/* I.T.Works TW891 */
+		.driver_data = (void *)&itworks_tw891_data,
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "To be filled by O.E.M."),

*groan* you're trolling me now right? ;-)

drivers/platform/x86/silead_dmi.c static const struct dmi_system_id silead_ts_dmi_table[] = { · line 209

Quoted 1 line
drivers/platform/x86/silead_dmi.c +1 -0
+			DMI_MATCH(DMI_PRODUCT_NAME, "TW891"),

I presume there are no other identifying strings?

Pushed to testing.

Signature · 2 lines
Darren Hart
VMware Open Source Technology Center
author
#2 lore raw

Hi,

Quoted 4 lines · Darren Hart
Quoted 2 lines · Hans de Goede

Add touchscreen info for I.T.Works TW891 2-in-1.

Quoted 8 lines

...

drivers/platform/x86/silead_dmi.c static const struct dmi_system_id silead_ts_dmi_table[] = { · line 208

Quoted 4 lines
drivers/platform/x86/silead_dmi.c +4 -0
+		/* I.T.Works TW891 */
+		.driver_data = (void *)&itworks_tw891_data,
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "To be filled by O.E.M."),

*groan* you're trolling me now right? ;-)

Nope, sorry, this seemed better then matching on a single string. FWIW I did an internet search for TW891 and there are no other devices named TW891.

Quoted 3 lines

drivers/platform/x86/silead_dmi.c static const struct dmi_system_id silead_ts_dmi_table[] = { · line 209

Quoted 1 line
drivers/platform/x86/silead_dmi.c +1 -0
+			DMI_MATCH(DMI_PRODUCT_NAME, "TW891"),

I presume there are no other identifying strings?

Correct if there was something better I would have used it.

Quoted 1 line

Pushed to testing.

Thank you.

Regards,

Hans