Skip to contentSkip to conversation

.gitlab-ci.yml: fix it again

PATCH New Arnout Vandecappelle (Essensium/Mind) 2 participants 2 messages Jul 1, 2017

lore
Share & tools
lore

Arnout Vandecappelle (Essensium/Mind)

author
#0 lore raw

PATCH 1/1 .gitlab-ci.yml: fix it again

It seems the ! is removed by the yaml parser, so it needs to be quoted. While we're at it, add some explanatory comment.

Signed-off-by Arnout Vandecappelle (Essensium/Mind) <[email protected]>
---
 .gitlab-ci.yml    | 5 ++++-
 .gitlab-ci.yml.in | 5 ++++-
 2 files changed, 8 insertions(+), 2 deletions(-)
.gitlab-ci.yml +4 -1
index 6bd983750d..eda8af4997 100644
@@ -35,8 +35,11 @@ check-gitlab-ci.yml:
         - diff -u .gitlab-ci.yml.orig .gitlab-ci.yml
 
 check-DEVELOPERS:
+    # get-developers should print just "No action specified"; if it prints
+    # anything else, it's a parse error.
+    # The initial ! is removed by YAML so we need to quote it.
     script:
-        - ! utils/get-developers | grep -v 'No action specified'
+        - "! utils/get-developers | grep -v 'No action specified'"
 
 .defconfig: &defconfig
     # Running the defconfigs for every push is too much, so limit to
.gitlab-ci.yml.in +4 -1
index 0855bffb79..24a1888c1e 100644
@@ -35,8 +35,11 @@ check-gitlab-ci.yml:
         - diff -u .gitlab-ci.yml.orig .gitlab-ci.yml
 
 check-DEVELOPERS:
+    # get-developers should print just "No action specified"; if it prints
+    # anything else, it's a parse error.
+    # The initial ! is removed by YAML so we need to quote it.
     script:
-        - ! utils/get-developers | grep -v 'No action specified'
+        - "! utils/get-developers | grep -v 'No action specified'"
 
 .defconfig: &defconfig
     # Running the defconfigs for every push is too much, so limit to
Signature · 1 line
2.13.1
Applied
#1 lore raw

PATCH 1/1 .gitlab-ci.yml: fix it again

Hello,

Quoted 8 lines · Arnout Vandecappelle (Essensium/Mind)

It seems the ! is removed by the yaml parser, so it needs to be quoted. While we're at it, add some explanatory comment.

Signed-off-by Arnout Vandecappelle (Essensium/Mind) <[email protected]>
---
 .gitlab-ci.yml    | 5 ++++-
 .gitlab-ci.yml.in | 5 ++++-
 2 files changed, 8 insertions(+), 2 deletions(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com