staging: sm750fb: fixed a assignment typo

PATCH Superseded Lynn Lei 2 participants 2 messages Jul 3, 2017

Subsystems (3)

Staging Framebuffer layer Staging - silicon motion SM750 frame buffer driver

lore

Share & tools

lore

Lynn Lei

author

2017-07-03 08:13 UTC #0 lore raw

PATCH v2 1/1 staging: sm750fb: fixed a assignment typo

fixed a typo issue in get_mxclk_freq().

the original code using PLL_CTRL_M_SHIFT for shifting to set N flag. which is not right, it should be PLL_CTRL_N_SHIFT.

both PLL_CTRL_M_SHIFT and PLL_CTRL_N_SHIFT
defined in drivers/staging/sm750fb/ddk750_reg.h

Signed-off-by Lynn Lei <[email protected]>

---
 drivers/staging/sm750fb/ddk750_chip.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/staging/sm750fb/ddk750_chip.c +1 -1

index 5e4bfb601cea..c51761221131 100644
@@ -40,7 +40,7 @@ static unsigned int get_mxclk_freq(void)
 
 	pll_reg = peek32(MXCLK_PLL_CTRL);
 	M = (pll_reg & PLL_CTRL_M_MASK) >> PLL_CTRL_M_SHIFT;
-	N = (pll_reg & PLL_CTRL_N_MASK) >> PLL_CTRL_M_SHIFT;
+	N = (pll_reg & PLL_CTRL_N_MASK) >> PLL_CTRL_N_SHIFT;
 	OD = (pll_reg & PLL_CTRL_OD_MASK) >> PLL_CTRL_OD_SHIFT;
 	POD = (pll_reg & PLL_CTRL_POD_MASK) >> PLL_CTRL_POD_SHIFT;

Signature · 1 line

2.13.2

Greg KH

maintainer

2017-07-03 08:30 UTC #1 lore raw

Quoted 5 lines · Lynn Lei

fixed a typo issue in get_mxclk_freq().
the original code using PLL_CTRL_M_SHIFT for shifting to set N flag. which is not right, it should be PLL_CTRL_N_SHIFT.

Quoted 7 lines

both PLL_CTRL_M_SHIFT and PLL_CTRL_N_SHIFT
defined in drivers/staging/sm750fb/ddk750_reg.h
Signed-off-by Lynn Lei <[email protected]>
---
 drivers/staging/sm750fb/ddk750_chip.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Always put what changed from the previous version here below the --- line, like the Documentation states to do.

v3 please?

thanks,

greg k-h