Skip to contentSkip to conversation

package: add qt5virtualkeyboard

PATCH Superseded Gaël PORTAY 2 participants 3 messages Apr 1, 2017 – Jul 4, 2017

lore
Share & tools
lore

Gaël PORTAY

author
#0 lore raw

PATCH v7 1/1 package: add qt5virtualkeyboard

This patch adds the Qt virtualkeyboard package.

Signed-off-by Ga?l PORTAY <[email protected]>
Reviewed-by Peter Seiderer <[email protected]>

---
Changes since v6:
- Add missing empty lines in Config.in.
- Reword note for all flag in help message.
- Remove mention of GPLv3 license in help message.
- Use filter text-function instead of strip+findstring to flag/install 3rd-parties.
- Fix useless call to strip when installing 3rd-parties.

Changes since v5:
- Fix LICENSE information.
- Fix missing QT5VIRTUALKEYBOARD_ prefix for QMAKEFLAGS.
- Set QT5VIRTUALKEYBOARD_3RDPARTY_PARTS to YES instead of appending a list of mudules.

Changes since v4:
- Prefix local variables to avoid potential naming collisions.

Changes since v3:
- Fix another build issue when installing to target in case of zh_TW (or other layout) is not set.
- Add licenses files when using 3rd-part modules.
- Add support for handwriting module.

Changes since v2:
- Fix build issue when installing libqtvirtualkeyboardplugin.so library in case of some other qt5 package installs something to plugins/platforminputcontexts.

Changes since v1:
- Add missing hash file
- Add license approval statement
- Add support for languages layouts
Note: Chinese, Japanese and Korean does not display properly (font?)
- Install sample if is compiled (BR2_PACKAGE_QT5BASE_EXAMPLES=y)
- Apply reviews from Peter:
Add version constraint: message and dependency (needs at least qt 5.8) Update help to mention GPLv3 license

 package/qt5/Config.in                              |  1 +
 package/qt5/qt5virtualkeyboard/Config.in           | 53 ++++++++++++++
 .../qt5/qt5virtualkeyboard/qt5virtualkeyboard.hash |  2 +
 .../qt5/qt5virtualkeyboard/qt5virtualkeyboard.mk   | 82 ++++++++++++++++++++++
 4 files changed, 138 insertions(+)
 create mode 100644 package/qt5/qt5virtualkeyboard/Config.in
 create mode 100644 package/qt5/qt5virtualkeyboard/qt5virtualkeyboard.hash
 create mode 100644 package/qt5/qt5virtualkeyboard/qt5virtualkeyboard.mk
package/qt5/Config.in +1 -0
index 4bcbc6ef5..a810503d3 100644
@@ -76,6 +76,7 @@ source "package/qt5/qt5serialbus/Config.in"
 source "package/qt5/qt5serialport/Config.in"
 source "package/qt5/qt5svg/Config.in"
 source "package/qt5/qt5tools/Config.in"
+source "package/qt5/qt5virtualkeyboard/Config.in"
 source "package/qt5/qt5webchannel/Config.in"
 source "package/qt5/qt5webkit/Config.in"
 source "package/qt5/qt5websockets/Config.in"
package/qt5/qt5virtualkeyboard/Config.in new file +53 -0

53 lines not on this page · raw message

package/qt5/qt5virtualkeyboard/qt5virtualkeyboard.hash new file +2 -0
new file mode 100644
index 000000000..ea30fdb7c
@@ -0,0 +1,2 @@
+# Hash from: http://download.qt.io/official_releases/qt/5.8/5.8.0/submodules/qtvirtualkeyboard-opensource-src-5.8.0.tar.xz
+sha256 35fdf5b39d930935b6299ac59f347bea89b983e16bd7961fee3f1b8e16f4e21c  qtvirtualkeyboard-opensource-src-5.8.0.tar.xz
package/qt5/qt5virtualkeyboard/qt5virtualkeyboard.mk new file +82 -0

82 lines not on this page · raw message

Signature · 1 line
2.12.1
#1 lore raw

PATCH v7 1/1 package: add qt5virtualkeyboard

Hello,

Quoted 4 lines · Ga?l PORTAY

This patch adds the Qt virtualkeyboard package.

Signed-off-by Ga?l PORTAY <[email protected]>
Reviewed-by Peter Seiderer <[email protected]>
Quoted 8 lines

---
Changes since v6:
- Add missing empty lines in Config.in.
- Reword note for all flag in help message.
- Remove mention of GPLv3 license in help message.
- Use filter text-function instead of strip+findstring to flag/install 3rd-parties.
- Fix useless call to strip when installing 3rd-parties.

I've applied to master, after fixing the following things:

[Thomas:
- use SDPX license codes
- add entry to DEVELOPERS file
- drop BR2_PACKAGE_QT5BASE_LICENSE_APPROVED logic, since we removed this option
- select BR2_PACKAGE_QT5DECLARATIVE and BR2_PACKAGE_QT5DECLARATIVE_QUICK instead of using a "depends on" and propagate the appropriate dependencies]

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#2 lore raw

PATCH v7 1/1 package: add qt5virtualkeyboard

Hi Thomas,

Quoted 26 lines · Thomas Petazzoni

Hello,

Quoted 4 lines · Ga?l PORTAY

This patch adds the Qt virtualkeyboard package.

Signed-off-by Ga?l PORTAY <[email protected]>
Reviewed-by Peter Seiderer <[email protected]>
Quoted 8 lines

---
Changes since v6:
- Add missing empty lines in Config.in.
- Reword note for all flag in help message.
- Remove mention of GPLv3 license in help message.
- Use filter text-function instead of strip+findstring to flag/install 3rd-parties.
- Fix useless call to strip when installing 3rd-parties.

I've applied to master, after fixing the following things:

[Thomas:
- use SDPX license codes
- add entry to DEVELOPERS file
- drop BR2_PACKAGE_QT5BASE_LICENSE_APPROVED logic, since we removed this option
- select BR2_PACKAGE_QT5DECLARATIVE and BR2_PACKAGE_QT5DECLARATIVE_QUICK instead of using a "depends on" and propagate the appropriate dependencies]

Quoted 7 lines

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Thanks!