Skip to contentSkip to conversation

drm/amdgpu: fix the build error if disable CONFIG_DEBUG_FS

PATCH In review Huang Rui 3 participants 4 messages Jul 2, 2017 – Jul 4, 2017 2 messages not in the archive

Subsystems (2)
lore
Share & tools
lore

Huang Rui

author
#0 lore raw

PATCH 1/1 drm/amdgpu: fix the build error if disable CONFIG_DEBUG_FS

This patch fixes the build error if CONFIG_DEBUG_FS is not enabled. Otherwise, below error will be triggered.

tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
master

head:   89a39f3c7086301342175c461c4db43c68d34cc7
commit: 4f0955fcc052b556446f6f041ad8c83d70c3b253 [6871/9973] drm/amdgpu: export

test ib debugfs interface
config: x86_64-randconfig-s1-06281413 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce:

        git checkout 4f0955fcc052b556446f6f041ad8c83d70c3b253
        # save the attached .config to linux build tree
        make ARCH=x86_64

All errors (new ones prefixed by >>):

Quoted 1 line
Quoted 1 line

ERROR: "amdgpu_debugfs_test_ib_ring_init" [drivers/gpu/drm/amd/amdgpu/

amdgpu.ko] undefined!

---
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +1 -1
index 9cf7cdf..97c98bd 100644
@@ -3899,7 +3899,7 @@ int amdgpu_debugfs_init(struct drm_minor *minor)
 	return 0;
 }
 #else
-static int amdgpu_debugfs_test_ib_init(struct amdgpu_device *adev)
+static int amdgpu_debugfs_test_ib_ring_init(struct amdgpu_device *adev)
 {
 	return 0;
 }
Signature · 6 lines
2.7.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 1498999972-3590-1-git-send-email-ray.huang-5C7GfCeVMHo@public.gmane.org

Reviewed-by
#2 lore raw

Am 02.07.2017 um 14:52 schrieb Huang Rui:

Quoted 15 lines

This patch fixes the build error if CONFIG_DEBUG_FS is not enabled. Otherwise, below error will be triggered.

tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
master

head:   89a39f3c7086301342175c461c4db43c68d34cc7
commit: 4f0955fcc052b556446f6f041ad8c83d70c3b253 [6871/9973] drm/amdgpu: export

test ib debugfs interface
config: x86_64-randconfig-s1-06281413 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce:

         git checkout 4f0955fcc052b556446f6f041ad8c83d70c3b253
         # save the attached .config to linux build tree
         make ARCH=x86_64
Quoted 7 lines

All errors (new ones prefixed by >>):

Quoted 1 line
Quoted 1 line

ERROR: "amdgpu_debugfs_test_ib_ring_init" [drivers/gpu/drm/amd/amdgpu/

amdgpu.ko] undefined!

Quoted 9 lines
---
  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +0 -0
index 9cf7cdf..97c98bd 100644

drivers/gpu/drm/amd/amdgpu/amdgpu_device.c int amdgpu_debugfs_init(struct drm_minor *minor) · line 3905

Quoted 8 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +1 -1
@@ -3899,7 +3899,7 @@ int amdgpu_debugfs_init(struct drm_minor *minor)
  	return 0;
  }
  #else
-static int amdgpu_debugfs_test_ib_init(struct amdgpu_device *adev)
+static int amdgpu_debugfs_test_ib_ring_init(struct amdgpu_device *adev)
  {
  	return 0;
  }

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

#3 lore raw
In reply to a message not in the archive
Quoted 24 lines

-----Original Message-----
From: Huang Rui [mailto:[email protected]]
Sent: Sunday, July 02, 2017 8:53 AM
To: [email protected]; Deucher, Alexander; Koenig, Christian
Cc: kbuild test robot; Huang, Ray
Subject: [PATCH] drm/amdgpu: fix the build error if disable CONFIG_DEBUG_FS

This patch fixes the build error if CONFIG_DEBUG_FS is not enabled. Otherwise, below error will be triggered.

tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
master
head: 89a39f3c7086301342175c461c4db43c68d34cc7
commit: 4f0955fcc052b556446f6f041ad8c83d70c3b253 [6871/9973] drm/amdgpu: export
test ib debugfs interface
config: x86_64-randconfig-s1-06281413 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce:

        git checkout 4f0955fcc052b556446f6f041ad8c83d70c3b253
        # save the attached .config to linux build tree
        make ARCH=x86_64
Quoted 8 lines

All errors (new ones prefixed by >>):

Quoted 1 line
Quoted 1 line

ERROR: "amdgpu_debugfs_test_ib_ring_init"

[drivers/gpu/drm/amd/amdgpu/
amdgpu.ko] undefined!

I already applied a patch from Arnd to fix this I think.

Alex

Quoted 18 lines
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +1 -1
index 9cf7cdf..97c98bd 100644
@@ -3899,7 +3899,7 @@ int amdgpu_debugfs_init(struct drm_minor
 *minor)
 	return 0;
 }
 #else
-static int amdgpu_debugfs_test_ib_init(struct amdgpu_device *adev)
+static int amdgpu_debugfs_test_ib_ring_init(struct amdgpu_device *adev)
 {
 	return 0;
Quoted 3 lines

}
--
2.7.4

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): BN6PR12MB1652B614C2EFB9C38FF8E949F7D60-/b2+HYfkarQqUD6E6FAiowdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org

author
#5 lore raw
Quoted 26 lines · Alexander
Quoted 26 lines

-----Original Message-----
From: Huang Rui [mailto:[email protected]]
Sent: Sunday, July 02, 2017 8:53 AM
To: [email protected]; Deucher, Alexander; Koenig, Christian
Cc: kbuild test robot; Huang, Ray
Subject: [PATCH] drm/amdgpu: fix the build error if disable CONFIG_DEBUG_FS

This patch fixes the build error if CONFIG_DEBUG_FS is not enabled. Otherwise, below error will be triggered.

tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
master
head: 89a39f3c7086301342175c461c4db43c68d34cc7
commit: 4f0955fcc052b556446f6f041ad8c83d70c3b253 [6871/9973] drm/amdgpu: export
test ib debugfs interface
config: x86_64-randconfig-s1-06281413 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce:

        git checkout 4f0955fcc052b556446f6f041ad8c83d70c3b253
        # save the attached .config to linux build tree
        make ARCH=x86_64

All errors (new ones prefixed by >>):

Quoted 9 lines
Quoted 6 lines
Quoted 1 line
Quoted 1 line

ERROR: "amdgpu_debugfs_test_ib_ring_init"

[drivers/gpu/drm/amd/amdgpu/
amdgpu.ko] undefined!

I already applied a patch from Arnd to fix this I think.

Yep, I see. So I didn't push it to staging.

Thanks,
Rui
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx