pixz: new package
PATCH 1/1 pixz: new package
From: Vincent Stehl? <[email protected]>
Add a package for pixz (pronounced pixie), a parallel, indexing version of xz.
See https://github.com/vasi/pixz
--- DEVELOPERS | 1 + package/Config.in | 1 + package/pixz/Config.in | 12 ++++++++++++ package/pixz/pixz.hash | 2 ++ package/pixz/pixz.mk | 18 ++++++++++++++++++ 5 files changed, 34 insertions(+) create mode 100644 package/pixz/Config.in create mode 100644 package/pixz/pixz.hash create mode 100644 package/pixz/pixz.mk
DEVELOPERS +1 -0
@@ -1715,6 +1715,7 @@ F: package/trinity/ N: Vincent Stehl? <[email protected]> F: package/i7z/ F: package/msr-tools/ +F: package/pixz/ F: package/uftrace/ N: Vinicius Tinti <[email protected]>
package/Config.in +1 -0
@@ -64,6 +64,7 @@ menu "Compressors and decompressors" source "package/lzip/Config.in" source "package/lzop/Config.in" source "package/p7zip/Config.in" + source "package/pixz/Config.in" source "package/unrar/Config.in" source "package/unzip/Config.in" source "package/xz/Config.in"
package/pixz/Config.in new file +12 -0
@@ -0,0 +1,12 @@ +config BR2_PACKAGE_PIXZ + bool "pixz" + depends on BR2_PACKAGE_LIBARCHIVE + depends on BR2_TOOLCHAIN_HAS_THREADS + select BR2_PACKAGE_XZ + help + Pixz (pronounced pixie) is a parallel, indexing version of xz. + + https://github.com/vasi/pixz + +comment "pixz needs a toolchain w/ threads, and libarchive" + depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_PACKAGE_LIBARCHIVE
package/pixz/pixz.hash new file +2 -0
@@ -0,0 +1,2 @@ +# Locally computed: +sha256 02c50746b134fa1b1aae41fcc314d7c6f1919b3d48bcdea01bf11769f83f72e8 pixz-1.0.6.tar.xz
package/pixz/pixz.mk new file +18 -0
@@ -0,0 +1,18 @@ +################################################################################ +# +# pixz +# +################################################################################ + +PIXZ_VERSION = 1.0.6 +PIXZ_SITE = https://github.com/vasi/pixz/releases/download/v$(PIXZ_VERSION) +PIXZ_SOURCE = pixz-$(PIXZ_VERSION).tar.xz +PIXZ_DEPENDENCIES = host-pkgconf libarchive xz +PIXZ_LICENSE = BSD-2-Clause +PIXZ_LICENSE_FILES = LICENSE + +# The configure script does not know how to test for the manpage presence when +# cross-compiling; help it a bit. +PIXZ_CONF_ENV = ac_cv_file_src_pixz_1=yes + +$(eval $(autotools-package))
Signature · 1 line
2.11.0
PATCH 1/1 pixz: new package
Hi Vincent,
Quoted 4 lines · Vincent Stehle
From: Vincent Stehl? <[email protected]>
Add a package for pixz (pronounced pixie), a parallel, indexing version of xz.
Would this package be able to replace host-xz on systems that need to build
host-xz?
Quoted 45 lines
See https://github.com/vasi/pixz
Signed-off-by Vincent Stehl? <[email protected]>--- DEVELOPERS | 1 + package/Config.in | 1 + package/pixz/Config.in | 12 ++++++++++++ package/pixz/pixz.hash | 2 ++ package/pixz/pixz.mk | 18 ++++++++++++++++++ 5 files changed, 34 insertions(+) create mode 100644 package/pixz/Config.in create mode 100644 package/pixz/pixz.hash create mode 100644 package/pixz/pixz.mkDEVELOPERS +1
-0@@ -1715,6 +1715,7 @@ F: package/trinity/ N: Vincent Stehl? <[email protected]> F: package/i7z/ F: package/msr-tools/ +F: package/pixz/ F: package/uftrace/ N: Vinicius Tinti <[email protected]>package/Config.in +1
-0@@ -64,6 +64,7 @@ menu "Compressors and decompressors" source "package/lzip/Config.in" source "package/lzop/Config.in" source "package/p7zip/Config.in" + source "package/pixz/Config.in" source "package/unrar/Config.in" source "package/unzip/Config.in" source "package/xz/Config.in"package/pixz/Config.in new file +0
-0
package/pixz/Config.in line 3
Quoted 3 lines
package/pixz/Config.in new file +3
-0@@ -0,0 +1,12 @@ +config BR2_PACKAGE_PIXZ + bool "pixz" + depends on BR2_PACKAGE_LIBARCHIVE
Why depends on and not select?
depends on BR2_TOOLCHAIN_HAS_THREADS
depends on BR2_USE_WCHAR # libarchive
select BR2_PACKAGE_LIBARCHIVE
Quoted 23 lines
package/pixz/Config.in new file +9
-0+ depends on BR2_TOOLCHAIN_HAS_THREADS + select BR2_PACKAGE_XZ + help + Pixz (pronounced pixie) is a parallel, indexing version of xz. + + https://github.com/vasi/pixz + +comment "pixz needs a toolchain w/ threads, and libarchive" + depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_PACKAGE_LIBARCHIVEpackage/pixz/pixz.hash new file +2
-0@@ -0,0 +1,2 @@ +# Locally computed: +sha256 02c50746b134fa1b1aae41fcc314d7c6f1919b3d48bcdea01bf11769f83f72e8 pixz-1.0.6.tar.xzpackage/pixz/pixz.mk new file +0
-0
package/pixz/pixz.mk line 10
Quoted 10 lines
package/pixz/pixz.mk new file +10
-0@@ -0,0 +1,18 @@ +################################################################################ +# +# pixz +# +################################################################################ + +PIXZ_VERSION = 1.0.6 +PIXZ_SITE = https://github.com/vasi/pixz/releases/download/v$(PIXZ_VERSION) +PIXZ_SOURCE = pixz-$(PIXZ_VERSION).tar.xz +PIXZ_DEPENDENCIES = host-pkgconf libarchive xz
Does it really depend on xz? Ah yes, for liblzma. Then you should also select it.
package/pixz/pixz.mk line 16
Quoted 6 lines
package/pixz/pixz.mk new file +6
-0+PIXZ_LICENSE = BSD-2-Clause +PIXZ_LICENSE_FILES = LICENSE + +# The configure script does not know how to test for the manpage presence when +# cross-compiling; help it a bit. +PIXZ_CONF_ENV = ac_cv_file_src_pixz_1=yes
The comment sounds like putting this to "yes" would actually build the manpage,
but the reverse is true... How about:
# pixz.1 is actually present, but AC_CHECK_FILE doesn't detect it when # cross-compiling, which causes configure to try to regenerate it. So # give it a hint to say that it actually is present.
Regards,
Arnout
Quoted 3 lines
package/pixz/pixz.mk new file +2
-0+ +$(eval $(autotools-package))
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
PATCH 1/1 pixz: new package
Quoted 10 lines · Arnout Vandecappelle
Hi Vincent,
Quoted 4 lines · Vincent Stehle
From: Vincent Stehl? <[email protected]>
Add a package for pixz (pronounced pixie), a parallel, indexing version of xz.
Would this package be able to replace host-xz on systems that need to build
host-xz?
Hi Arnout,
Thanks for the review!
Actually I use a version of this package just slightly modified to build host-pixz and it works fine. I guess you are right, this would be useful to offer it as an alternative to host-xz.
Although I suspect we cannot just replace xz by pixz by default, as I needed once in a while to reduce the number of threads manually, just to avoid using too much memory.
If we want to propose pixz as an alternative to xz, shall we go for a virtual package for host-xz?
Quoted 52 lines
Quoted 46 lines
See https://github.com/vasi/pixz
Signed-off-by Vincent Stehl? <[email protected]>--- DEVELOPERS | 1 + package/Config.in | 1 + package/pixz/Config.in | 12 ++++++++++++ package/pixz/pixz.hash | 2 ++ package/pixz/pixz.mk | 18 ++++++++++++++++++ 5 files changed, 34 insertions(+) create mode 100644 package/pixz/Config.in create mode 100644 package/pixz/pixz.hash create mode 100644 package/pixz/pixz.mkDEVELOPERS +1
-0@@ -1715,6 +1715,7 @@ F: package/trinity/ N: Vincent Stehl? <[email protected]> F: package/i7z/ F: package/msr-tools/ +F: package/pixz/ F: package/uftrace/ N: Vinicius Tinti <[email protected]>package/Config.in +1
-0@@ -64,6 +64,7 @@ menu "Compressors and decompressors" source "package/lzip/Config.in" source "package/lzop/Config.in" source "package/p7zip/Config.in" + source "package/pixz/Config.in" source "package/unrar/Config.in" source "package/unzip/Config.in" source "package/xz/Config.in"package/pixz/Config.in new file +0
-0package/pixz/Config.in line 3
Quoted 3 lines
package/pixz/Config.in new file +3
-0@@ -0,0 +1,12 @@ +config BR2_PACKAGE_PIXZ + bool "pixz" + depends on BR2_PACKAGE_LIBARCHIVEWhy depends on and not select?
Quoted 4 lines
depends on
BR2_TOOLCHAIN_HAS_THREADS
depends onBR2_USE_WCHAR# libarchive
selectBR2_PACKAGE_LIBARCHIVE
I hesitated for this one. As libarchive needs wchar and has sub-options, I thought we might let the user do the selection after all. But I like your solution of adding wchar at pixz level better, thanks.
Quoted 46 lines
Quoted 23 lines
package/pixz/Config.in new file +9
-0+ depends on BR2_TOOLCHAIN_HAS_THREADS + select BR2_PACKAGE_XZ + help + Pixz (pronounced pixie) is a parallel, indexing version of xz. + + https://github.com/vasi/pixz + +comment "pixz needs a toolchain w/ threads, and libarchive" + depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_PACKAGE_LIBARCHIVEpackage/pixz/pixz.hash new file +2
-0@@ -0,0 +1,2 @@ +# Locally computed: +sha256 02c50746b134fa1b1aae41fcc314d7c6f1919b3d48bcdea01bf11769f83f72e8 pixz-1.0.6.tar.xzpackage/pixz/pixz.mk new file +0
-0package/pixz/pixz.mk line 10
Quoted 10 lines
package/pixz/pixz.mk new file +10
-0@@ -0,0 +1,18 @@ +################################################################################ +# +# pixz +# +################################################################################ + +PIXZ_VERSION = 1.0.6 +PIXZ_SITE = https://github.com/vasi/pixz/releases/download/v$(PIXZ_VERSION) +PIXZ_SOURCE = pixz-$(PIXZ_VERSION).tar.xz +PIXZ_DEPENDENCIES = host-pkgconf libarchive xzDoes it really depend on xz? Ah yes, for liblzma. Then you should also select it.
package/pixz/pixz.mk line 16
Quoted 6 lines
package/pixz/pixz.mk new file +6
-0+PIXZ_LICENSE = BSD-2-Clause +PIXZ_LICENSE_FILES = LICENSE + +# The configure script does not know how to test for the manpage presence when +# cross-compiling; help it a bit. +PIXZ_CONF_ENV = ac_cv_file_src_pixz_1=yesThe comment sounds like putting this to "yes" would actually build the manpage,
but the reverse is true... How about:
Quoted 3 lines
# pixz.1 is actually present, but AC_CHECK_FILE doesn't detect it when # cross-compiling, which causes configure to try to regenerate it. So # give it a hint to say that it actually is present.
Sure, this is more explicit, thanks.
I'll resubmit a v2.
Best regards,
Vincent.
Quoted 8 lines
Regards,
ArnoutQuoted 3 lines
package/pixz/pixz.mk new file +2
-0+ +$(eval $(autotools-package))
PATCH v2 1/1 pixz: new package
In reply to Arnout VandecappelleFrom: Vincent Stehl? <[email protected]>
Add a package for pixz (pronounced pixie), a parallel, indexing version of xz.
See https://github.com/vasi/pixz
---
Changes since v1:
-----------------
- Select libarchive and depend on wchar, as suggested by Arnout
- Rework comment on conf_env, as suggested by Arnout
- Make pixz a host package, too. This to prepare making it a selectable alternative to host-xz, as suggested by Arnout
- Change my e-mail address in DEVELOPERS
DEVELOPERS | 3 ++- package/Config.in | 1 + package/pixz/Config.in | 13 +++++++++++++ package/pixz/pixz.hash | 2 ++ package/pixz/pixz.mk | 21 +++++++++++++++++++++ 5 files changed, 39 insertions(+), 1 deletion(-) create mode 100644 package/pixz/Config.in create mode 100644 package/pixz/pixz.hash create mode 100644 package/pixz/pixz.mk
DEVELOPERS +2 -1
@@ -1712,9 +1712,10 @@ F: package/openmpi/ F: package/pinentry/ F: package/trinity/ -N: Vincent Stehl? <[email protected]> +N: Vincent Stehl? <[email protected]> F: package/i7z/ F: package/msr-tools/ +F: package/pixz/ N: Vinicius Tinti <[email protected]> F: package/python-thrift/
package/Config.in +1 -0
@@ -64,6 +64,7 @@ menu "Compressors and decompressors" source "package/lzip/Config.in" source "package/lzop/Config.in" source "package/p7zip/Config.in" + source "package/pixz/Config.in" source "package/unrar/Config.in" source "package/unzip/Config.in" source "package/xz/Config.in"
package/pixz/Config.in new file +13 -0
@@ -0,0 +1,13 @@ +config BR2_PACKAGE_PIXZ + bool "pixz" + depends on BR2_TOOLCHAIN_HAS_THREADS + depends on BR2_USE_WCHAR # libarchive + select BR2_PACKAGE_LIBARCHIVE + select BR2_PACKAGE_XZ + help + Pixz (pronounced pixie) is a parallel, indexing version of xz. + + https://github.com/vasi/pixz + +comment "pixz needs a toolchain w/ threads, wchar" + depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR
package/pixz/pixz.hash new file +2 -0
@@ -0,0 +1,2 @@ +# Locally computed: +sha256 02c50746b134fa1b1aae41fcc314d7c6f1919b3d48bcdea01bf11769f83f72e8 pixz-1.0.6.tar.xz
package/pixz/pixz.mk new file +21 -0
@@ -0,0 +1,21 @@ +################################################################################ +# +# pixz +# +################################################################################ + +PIXZ_VERSION = 1.0.6 +PIXZ_SITE = https://github.com/vasi/pixz/releases/download/v$(PIXZ_VERSION) +PIXZ_SOURCE = pixz-$(PIXZ_VERSION).tar.xz +PIXZ_DEPENDENCIES = host-pkgconf libarchive xz +HOST_PIXZ_DEPENDENCIES = host-pkgconf host-libarchive host-xz +PIXZ_LICENSE = BSD-2-Clause +PIXZ_LICENSE_FILES = LICENSE + +# pixz.1 is actually present, but AC_CHECK_FILE doesn't detect it when +# cross-compiling, which causes configure to try to regenerate it. So give it a +# hint to say that it actually is present. +PIXZ_CONF_ENV = ac_cv_file_src_pixz_1=yes + +$(eval $(autotools-package)) +$(eval $(host-autotools-package))
Signature · 1 line
2.11.0
PATCH v2 1/1 pixz: new package
Hi Vincent,
Quoted 12 lines · Vincent Stehle
From: Vincent Stehl? <[email protected]>
Add a package for pixz (pronounced pixie), a parallel, indexing version of xz.
See https://github.com/vasi/pixz
Signed-off-by Vincent Stehl? <[email protected]>Cc Arnout Vandecappelle <[email protected]>---
Quoted 6 lines
Changes since v1:
-----------------
- Select libarchive and depend on wchar, as suggested by Arnout
- Rework comment onconf_env, as suggested by Arnout
- Make pixz a host package, too. This to prepare making it a selectable alternative to host-xz, as suggested by Arnout
Since pixz in fact uses xz, it seems like a bad idea to use it as a replacement
for host-xz. It's not as if the xz tarball extraction is such an important part of build time... So the host package can be removed I guess.
Sorry for changing my mind.
Otherwise the patch looks good, so after removing the two lines referring to
the host package you can add my
Regards,
Arnout
Quoted 13 lines
- Change my e-mail address in DEVELOPERS
DEVELOPERS | 3 ++- package/Config.in | 1 + package/pixz/Config.in | 13 +++++++++++++ package/pixz/pixz.hash | 2 ++ package/pixz/pixz.mk | 21 +++++++++++++++++++++ 5 files changed, 39 insertions(+), 1 deletion(-) create mode 100644 package/pixz/Config.in create mode 100644 package/pixz/pixz.hash create mode 100644 package/pixz/pixz.mk
[snip]
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
PATCH v3 1/1 pixz: new package
From: Vincent Stehl? <[email protected]>
Add a package for pixz (pronounced pixie), a parallel, indexing version of xz.
See https://github.com/vasi/pixz
---
Hi Arnout,
Here is the patch with the host package removal.
I agree that if we do not plan to use pixz as a host package right now it is cleaner not to add the host package lines. And I think this is no big deal anyway as this is straightforward to add later if needed.
Also I wanted to ask you if you are ok that I update the DEVELOPERS file in this same patch, please? Romain suggested for uftrace that I rather separate it. This is up to you really; do you want a v4 with the DEVELOPERS change moved out of the way?
Thank you for your review.
Best regards,
Vincent.
Changes since v2:
-----------------
- Remove the two lines of host package
Changes since v1:
-----------------
- Select libarchive and depend on wchar, as suggested by Arnout
- Rework comment on conf_env, as suggested by Arnout
- Make pixz a host package, too. This to prepare making it a selectable alternative to host-xz, as suggested by Arnout
- Change my e-mail address in DEVELOPERS
DEVELOPERS | 3 ++- package/Config.in | 1 + package/pixz/Config.in | 13 +++++++++++++ package/pixz/pixz.hash | 2 ++ package/pixz/pixz.mk | 19 +++++++++++++++++++ 5 files changed, 37 insertions(+), 1 deletion(-) create mode 100644 package/pixz/Config.in create mode 100644 package/pixz/pixz.hash create mode 100644 package/pixz/pixz.mk
DEVELOPERS +2 -1
@@ -1716,9 +1716,10 @@ F: package/openmpi/ F: package/pinentry/ F: package/trinity/ -N: Vincent Stehl? <[email protected]> +N: Vincent Stehl? <[email protected]> F: package/i7z/ F: package/msr-tools/ +F: package/pixz/ N: Vinicius Tinti <[email protected]> F: package/python-thrift/
package/Config.in +1 -0
@@ -64,6 +64,7 @@ menu "Compressors and decompressors" source "package/lzip/Config.in" source "package/lzop/Config.in" source "package/p7zip/Config.in" + source "package/pixz/Config.in" source "package/unrar/Config.in" source "package/unzip/Config.in" source "package/xz/Config.in"
package/pixz/Config.in new file +13 -0
@@ -0,0 +1,13 @@ +config BR2_PACKAGE_PIXZ + bool "pixz" + depends on BR2_TOOLCHAIN_HAS_THREADS + depends on BR2_USE_WCHAR # libarchive + select BR2_PACKAGE_LIBARCHIVE + select BR2_PACKAGE_XZ + help + Pixz (pronounced pixie) is a parallel, indexing version of xz. + + https://github.com/vasi/pixz + +comment "pixz needs a toolchain w/ threads, wchar" + depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR
package/pixz/pixz.hash new file +2 -0
@@ -0,0 +1,2 @@ +# Locally computed: +sha256 02c50746b134fa1b1aae41fcc314d7c6f1919b3d48bcdea01bf11769f83f72e8 pixz-1.0.6.tar.xz
package/pixz/pixz.mk new file +19 -0
@@ -0,0 +1,19 @@ +################################################################################ +# +# pixz +# +################################################################################ + +PIXZ_VERSION = 1.0.6 +PIXZ_SITE = https://github.com/vasi/pixz/releases/download/v$(PIXZ_VERSION) +PIXZ_SOURCE = pixz-$(PIXZ_VERSION).tar.xz +PIXZ_DEPENDENCIES = host-pkgconf libarchive xz +PIXZ_LICENSE = BSD-2-Clause +PIXZ_LICENSE_FILES = LICENSE + +# pixz.1 is actually present, but AC_CHECK_FILE doesn't detect it when +# cross-compiling, which causes configure to try to regenerate it. So give it a +# hint to say that it actually is present. +PIXZ_CONF_ENV = ac_cv_file_src_pixz_1=yes + +$(eval $(autotools-package))
Signature · 1 line
2.11.0
PATCH v3 1/1 pixz: new package
Quoted 4 lines · Vincent Stehle
Also I wanted to ask you if you are ok that I update the DEVELOPERS file in this same patch, please? Romain suggested for uftrace that I rather separate it. This is up to you really; do you want a v4 with the DEVELOPERS change moved out of the way?
Romain said that because now you have two patches (uftrace and this one) that
make the same change to the developer file, which will obviously create a conflict when applying...
This one is OK now since Peter will apply it right away I think.
Regards,
Arnout
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
Thomas Petazzoni
AppliedPATCH v3 1/1 pixz: new package
In reply to Vincent StehleHello,
Quoted 11 lines · Vincent Stehle
From: Vincent Stehl? <[email protected]>
Add a package for pixz (pronounced pixie), a parallel, indexing version of xz.
See https://github.com/vasi/pixz
Signed-off-by Vincent Stehl? <[email protected]>---
Applied to master, thanks.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com