Skip to contentSkip to conversation

manual: add documentation about DL_DIR

PATCH New Maxime Hadjinlian 2 participants 4 messages Jul 4, 2017

lore
Share & tools
lore

Maxime Hadjinlian

author
#0 lore raw

PATCH 1/3 manual: add documentation about DL_DIR

And at the same time don't encourage use of BR2_DL_DIR

Signed-off-by Maxime Hadjinlian <[email protected]>
Acked-by Yann E. MORIN <[email protected]>
---
 docs/manual/adding-packages-generic.txt | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
docs/manual/adding-packages-generic.txt +4 -1
index 71e27b672..12cf1605d 100644
@@ -263,7 +263,7 @@ information is (assuming the package name is +libfoo+) :
   the file using this URL. Otherwise, Buildroot will assume the file
   to be downloaded is located at +LIBFOO_SITE+. Buildroot will not do
   anything with those additional files, except download them: it will
-  be up to the package recipe to use them from +$(BR2_DL_DIR)+.
+  be up to the package recipe to use them from +$(DL_DIR)+.
 
 * +LIBFOO_SITE_METHOD+ determines the method used to fetch or copy the
   package source code. In many cases, Buildroot guesses the method

@@ -537,6 +537,9 @@ In the action definitions, you can use the following variables:
 * +$(@D)+, which contains the directory in which the package source
   code has been uncompressed.
 
+* +$(DL_DIR)+ contains the path to the directory where all the downloads made
+  by Buildroot are stored.
+
 * +$(TARGET_CC)+, +$(TARGET_LD)+, etc. to get the target
   cross-compilation utilities
Signature · 1 line
2.11.0
author
#1 lore raw

PATCH 2/3 kodi: s/BR2_DL_DIR/DL_DIR/

BR2_DL_DIR is not to be used by the package's Makefile.

Signed-off-by Maxime Hadjinlian <[email protected]>
Acked-by Yann E. MORIN <[email protected]>
---
 package/kodi/kodi.mk | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
package/kodi/kodi.mk +3 -3
index 2636a0b96..7a031b748 100644
@@ -66,9 +66,9 @@ KODI_CONF_OPTS += \
 	-DNATIVEPREFIX=$(HOST_DIR)/usr \
 	-DDEPENDS_PATH=$(@D) \
 	-DWITH_TEXTUREPACKER=$(HOST_DIR)/usr/bin/TexturePacker \
-	-DLIBDVDCSS_URL=$(BR2_DL_DIR)/$(KODI_LIBDVDCSS_VERSION).tar.gz \
-	-DLIBDVDNAV_URL=$(BR2_DL_DIR)/$(KODI_LIBDVDNAV_VERSION).tar.gz \
-	-DLIBDVDREAD_URL=$(BR2_DL_DIR)/$(KODI_LIBDVDREAD_VERSION).tar.gz
+	-DLIBDVDCSS_URL=$(DL_DIR)/$(KODI_LIBDVDCSS_VERSION).tar.gz \
+	-DLIBDVDNAV_URL=$(DL_DIR)/$(KODI_LIBDVDNAV_VERSION).tar.gz \
+	-DLIBDVDREAD_URL=$(DL_DIR)/$(KODI_LIBDVDREAD_VERSION).tar.gz
 
 ifeq ($(BR2_arm),y)
 KODI_CONF_OPTS += -DWITH_ARCH=arm -DWITH_CPU=arm
Signature · 1 line
2.11.0
author
#2 lore raw

PATCH 3/3 spidev-test: s/BR2_DL_DIR/DL_DIR/

In reply to Maxime Hadjinlian

BR2_DL_DIR is not to be used by the package's Makefile.

Signed-off-by Maxime Hadjinlian <[email protected]>
Acked-by Yann E. MORIN <[email protected]>
---
 package/spidev_test/spidev_test.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/spidev_test/spidev_test.mk +1 -1
index 1f34c6afd..1d657803b 100644
@@ -32,7 +32,7 @@ endef
 SPIDEV_TEST_POST_PATCH_HOOKS += SPIDEV_ADD_LINUX_IOCTL
 
 define SPIDEV_TEST_EXTRACT_CMDS
-	cp $(BR2_DL_DIR)/$(SPIDEV_TEST_SOURCE) $(@D)/spidev_test.c
+	cp $(DL_DIR)/$(SPIDEV_TEST_SOURCE) $(@D)/spidev_test.c
 endef
 
 define SPIDEV_TEST_BUILD_CMDS
Signature · 1 line
2.11.0
#3 lore raw

PATCH 1/3 manual: add documentation about DL_DIR

In reply to Maxime Hadjinlian

Hello,

Quoted 7 lines · Maxime Hadjinlian

And at the same time don't encourage use of BR2_DL_DIR

Signed-off-by Maxime Hadjinlian <[email protected]>
Acked-by Yann E. MORIN <[email protected]>
---
 docs/manual/adding-packages-generic.txt | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

All three patches applied. Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com