Skip to contentSkip to conversation

toolchain: CodeSourcery AMD64 affected by PR19615

PATCH New Romain Naour 3 participants 5 messages Jul 4, 2017 – Jul 19, 2017

lore
Share & tools
lore

Romain Naour

author
#0 lore raw

PATCH 1/2 toolchain: CodeSourcery AMD64 affected by PR19615

Signed-off-by Romain Naour <[email protected]>
---
 toolchain/toolchain-common.in                                        | 5 +++++
 .../toolchain-external-codesourcery-amd64/Config.in                  | 1 +
 2 files changed, 6 insertions(+)
toolchain/toolchain-common.in +5 -0
index ed993dd..74e0e06 100644
@@ -7,6 +7,11 @@ source "package/gdb/Config.in.host"
 
 comment "Toolchain Generic Options"
 
+# https://sourceware.org/bugzilla/show_bug.cgi?id=19615
+# Affect toolchains built with binutils 2.26 (fixed in binutils 2.26.1).
+config BR2_TOOLCHAIN_HAS_BINUTILS_BUG_19615
+	bool
+
 # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64735
 # exception_ptr, nested_exception, and future from libstdc++ are not
 # available for architectures not supporting always lock-free atomic
toolchain/toolchain-external/toolchain-external-codesourcery-amd64/Config.in +1 -0
index 32d79eb..101e227 100644
@@ -11,6 +11,7 @@ config BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_AMD64
 	select BR2_HOSTARCH_NEEDS_IA32_LIBS
 	select BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_7
 	select BR2_TOOLCHAIN_GCC_AT_LEAST_6
+	select BR2_TOOLCHAIN_HAS_BINUTILS_BUG_19615 # based-on binutils-2.26
 	help
 	  Sourcery CodeBench toolchain for the amd64 (x86_64)
 	  architectures, from Mentor Graphics. It uses gcc 6.2,
Signature · 1 line
2.9.4
author
#1 lore raw

PATCH 2/2 boot/syslinux: disable syslinux legacy-BIOS for toolchains affected by binutils bug 19615

Since [1] syslinux is build with the target toolchain in order to properly build with gnu-efi package.
But toolchains built with binutils 2.26 break the syslinux legacy-BIOS build as reported [2].

Thanks to Beno?t Allard for the investigation and the link to the binutils bug [3].

[1] 6e432d5ecb46959f3c27dbbca48e41512bb40a70
[2] http://lists.busybox.net/pipermail/buildroot/2017-July/196253.html
[3] https://sourceware.org/bugzilla/show_bug.cgi?id=19615

Signed-off-by Romain Naour <[email protected]>
Cc Beno?t Allard <[email protected]>
---
 boot/syslinux/Config.in | 1 +
 1 file changed, 1 insertion(+)
boot/syslinux/Config.in +1 -0
index 299a559..da03549 100644
@@ -35,6 +35,7 @@ config BR2_TARGET_SYSLINUX_PXELINUX
 
 config BR2_TARGET_SYSLINUX_MBR
 	bool "install mbr"
+	depends on !BR2_TOOLCHAIN_HAS_BINUTILS_BUG_19615
 	select BR2_TARGET_SYSLINUX_LEGACY_BIOS
 	help
 	  Install the legacy-BIOS 'mbr' image, to boot off a
Signature · 1 line
2.9.4
#2 lore raw

PATCH 2/2 boot/syslinux: disable syslinux legacy-BIOS for toolchains affected by binutils bug 19615

Quoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Romain" == Romain Naour <[email protected]> writes:

Since [1] syslinux is build with the target toolchain in order to properly build with gnu-efi package.
But toolchains built with binutils 2.26 break the syslinux legacy-BIOS build as reported [2].

Thanks to Beno?t Allard for the investigation and the link to the binutils bug [3].

Quoted 6 lines

[1] 6e432d5ecb46959f3c27dbbca48e41512bb40a70
[2] http://lists.busybox.net/pipermail/buildroot/2017-July/196253.html
[3] https://sourceware.org/bugzilla/show_bug.cgi?id=19615

Signed-off-by Romain Naour <[email protected]>
Cc Beno?t Allard <[email protected]>

Committed to 2017.05.x, thanks.

I take it that our internal 2.26.1 binutils isn't affected by this?

Signature · 1 line
Bye, Peter Korsgaard
#3 lore raw

PATCH 1/2 toolchain: CodeSourcery AMD64 affected by PR19615

In reply to Romain Naour

Hello,

Quoted 5 lines · Romain Naour
Signed-off-by Romain Naour <[email protected]>
---
 toolchain/toolchain-common.in                                        | 5 +++++
 .../toolchain-external-codesourcery-amd64/Config.in                  | 1 +
 2 files changed, 6 insertions(+)

Both applied, thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com