Skip to contentSkip to conversation

drivers/staging/media/atomisp/i2c/gc2235: fix sparse warning: missing static

PATCH New Guillermo O. Freschi 1 participant 1 message Jul 4, 2017

Subsystems (4)
Media (V4L/DVB) Staging Intel MID (Mobile Internet Device) platform Staging - atomisp driver
lore
Share & tools
lore

Guillermo O. Freschi

author
#0 lore raw

PATCH 1/1 drivers/staging/media/atomisp/i2c/gc2235: fix sparse warning: missing static

Several local use structs were missing declarations. Added static qualifier to clean up Sparse warning.

Signed-off-by Guillermo O. Freschi <[email protected]>
---
 drivers/staging/media/atomisp/i2c/gc2235.c | 2 +-
 drivers/staging/media/atomisp/i2c/gc2235.h | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)
drivers/staging/media/atomisp/i2c/gc2235.c +1 -1
index 50f431729b6c..04e69dd5fdb1 100644
@@ -480,7 +480,7 @@ static const struct v4l2_ctrl_ops ctrl_ops = {
 	.g_volatile_ctrl = gc2235_g_volatile_ctrl
 };
 
-struct v4l2_ctrl_config gc2235_controls[] = {
+static struct v4l2_ctrl_config gc2235_controls[] = {
 	{
 	 .ops = &ctrl_ops,
 	 .id = V4L2_CID_EXPOSURE_ABSOLUTE,
drivers/staging/media/atomisp/i2c/gc2235.h +3 -3
index ccbc757045a5..ae8f09dbe5c7 100644
@@ -530,7 +530,7 @@ static struct gc2235_reg const gc2235_1616_1216_30fps[] = {
 	{ GC2235_TOK_TERM, 0, 0 }
 };
 
-struct gc2235_resolution gc2235_res_preview[] = {
+static struct gc2235_resolution gc2235_res_preview[] = {
 
 	{
 		.desc = "gc2235_1600_900_30fps",

@@ -582,7 +582,7 @@ struct gc2235_resolution gc2235_res_preview[] = {
 };
 #define N_RES_PREVIEW (ARRAY_SIZE(gc2235_res_preview))
 
-struct gc2235_resolution gc2235_res_still[] = {
+static struct gc2235_resolution gc2235_res_still[] = {
 	{
 		.desc = "gc2235_1600_900_30fps",
 		.width = 1600,

@@ -632,7 +632,7 @@ struct gc2235_resolution gc2235_res_still[] = {
 };
 #define N_RES_STILL (ARRAY_SIZE(gc2235_res_still))
 
-struct gc2235_resolution gc2235_res_video[] = {
+static struct gc2235_resolution gc2235_res_video[] = {
 	{
 		.desc = "gc2235_1296_736_30fps",
 		.width = 1296,
Signature · 1 line
2.11.0