Skip to contentSkip to conversation

package/kvazaar: add host-pkgconf dependency

PATCH New Romain Naour 3 participants 7 messages Jul 4, 2017

lore
Share & tools
lore

Romain Naour

author
#0 lore raw

PATCH 1/3 package/kvazaar: add host-pkgconf dependency

The build system use PKG_CHECK_MODULES.

checking pkg-config is at least version 0.9.0... ./configure: line 16886: output/host/usr/bin/pkg-config: No such file or directory no

Signed-off-by Romain Naour <[email protected]>
---
 package/kvazaar/kvazaar.mk | 1 +
 1 file changed, 1 insertion(+)
package/kvazaar/kvazaar.mk +1 -0
index 30b8bda..f9149a7 100644
@@ -10,6 +10,7 @@ KVAZAAR_LICENSE = LGPL-2.1+
 KVAZAAR_LICENSE_FILES = COPYING
 KVAZAAR_AUTORECONF = YES
 KVAZAAR_INSTALL_STAGING = YES
+KVAZAAR_DEPENDENCIES = host-pkgconf
 KVAZAAR_CONF_OPTS = --without-cryptopp
 
 $(eval $(autotools-package))
Signature · 1 line
2.9.4
author
#1 lore raw

PATCH 2/3 package/kvazaar: needs C++ compiler

Even if there is only one CPP file src/extras/crypto.cpp which should be disabled by --without-cryptopp, kvazaar fail to build the shared library libkvazaar.so when no C++ compiler is available.

checking whether we are using the GNU C++ compiler... no

Fixes:
[microblazel] http://autobuild.buildroot.net/results/5d1/5d140ed95e292f73b6770a5e5be717df844e4830
[arm] http://autobuild.buildroot.net/results/c55/c55b973502b9b88643ae9fca11447b547148275d

Signed-off-by Romain Naour <[email protected]>
---
 package/kvazaar/Config.in | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
package/kvazaar/Config.in +3 -2
index 06ab9ac..de2c6c9 100644
@@ -1,10 +1,11 @@
 config BR2_PACKAGE_KVAZAAR
 	bool "kvazaar"
+	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	help
 	  An open-source HEVC encoder licensed under LGPLv2.1
 
 	  https://github.com/ultravideo/kvazaar
 
-comment "kvazaar needs a toolchain w/ threads"
-	depends on !BR2_TOOLCHAIN_HAS_THREADS
+comment "kvazaar needs a toolchain w/ C++, threads"
+	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS
Signature · 1 line
2.9.4
#2 lore raw

PATCH 2/3 package/kvazaar: needs C++ compiler

Quoted 11 lines · Romain Naour

Even if there is only one CPP file src/extras/crypto.cpp which should be disabled by --without-cryptopp, kvazaar fail to build the shared library libkvazaar.so when no C++ compiler is available.

checking whether we are using the GNU C++ compiler... no

Fixes:
[microblazel] http://autobuild.buildroot.net/results/5d1/5d140ed95e292f73b6770a5e5be717df844e4830
[arm] http://autobuild.buildroot.net/results/c55/c55b973502b9b88643ae9fca11447b547148275d

Signed-off-by Romain Naour <[email protected]>
Reviewed-by Arnout Vandecappelle (Essensium/Mind) <[email protected]>

Regards,
Arnout

Quoted 23 lines
---
 package/kvazaar/Config.in | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
package/kvazaar/Config.in +3 -2
index 06ab9ac..de2c6c9 100644
@@ -1,10 +1,11 @@
 config BR2_PACKAGE_KVAZAAR
 	bool "kvazaar"
+	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	help
 	  An open-source HEVC encoder licensed under LGPLv2.1
 
 	  https://github.com/ultravideo/kvazaar
 
-comment "kvazaar needs a toolchain w/ threads"
-	depends on !BR2_TOOLCHAIN_HAS_THREADS
+comment "kvazaar needs a toolchain w/ C++, threads"
+	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS
Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
author
#3 lore raw

PATCH 3/3 package/kvazaar: needs BR2_TOOLCHAIN_HAS_SYNC_4

In reply to Romain Naour

./.libs/libkvazaar.so: undefined reference to `__sync_add_and_fetch_4'

Fixes:
http://autobuild.buildroot.net/results/b39/b39a82a2e4106c5ec55c288415e73043a872a0b1

Signed-off-by Romain Naour <[email protected]>
---
 package/kvazaar/Config.in | 2 ++
 1 file changed, 2 insertions(+)
package/kvazaar/Config.in +2 -0
index de2c6c9..fb97369 100644
@@ -2,10 +2,12 @@ config BR2_PACKAGE_KVAZAAR
 	bool "kvazaar"
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_TOOLCHAIN_HAS_THREADS
+	depends on BR2_TOOLCHAIN_HAS_SYNC_4
 	help
 	  An open-source HEVC encoder licensed under LGPLv2.1
 
 	  https://github.com/ultravideo/kvazaar
 
 comment "kvazaar needs a toolchain w/ C++, threads"
+	depends on BR2_TOOLCHAIN_HAS_SYNC_4
 	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS
Signature · 1 line
2.9.4
#4 lore raw

PATCH 3/3 package/kvazaar: needs BR2_TOOLCHAIN_HAS_SYNC_4

Quoted 6 lines · Romain Naour

./.libs/libkvazaar.so: undefined reference to `__sync_add_and_fetch_4'

Fixes:
http://autobuild.buildroot.net/results/b39/b39a82a2e4106c5ec55c288415e73043a872a0b1

Signed-off-by Romain Naour <[email protected]>
Reviewed-by Arnout Vandecappelle (Essensium/Mind) <[email protected]>

Regards,
Arnout

Quoted 22 lines
---
 package/kvazaar/Config.in | 2 ++
 1 file changed, 2 insertions(+)
package/kvazaar/Config.in +2 -0
index de2c6c9..fb97369 100644
@@ -2,10 +2,12 @@ config BR2_PACKAGE_KVAZAAR
 	bool "kvazaar"
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_TOOLCHAIN_HAS_THREADS
+	depends on BR2_TOOLCHAIN_HAS_SYNC_4
 	help
 	  An open-source HEVC encoder licensed under LGPLv2.1
 
 	  https://github.com/ultravideo/kvazaar
 
 comment "kvazaar needs a toolchain w/ C++, threads"
+	depends on BR2_TOOLCHAIN_HAS_SYNC_4
 	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS
Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
#5 lore raw

PATCH 1/3 package/kvazaar: add host-pkgconf dependency

In reply to Romain Naour
Quoted 6 lines · Romain Naour

The build system use PKG_CHECK_MODULES.

checking pkg-config is at least version 0.9.0... ./configure: line 16886: output/host/usr/bin/pkg-config: No such file or directory no

Signed-off-by Romain Naour <[email protected]>
Reviewed-by Arnout Vandecappelle (Essensium/Mind) <[email protected]>

Regards,
Arnout

Quoted 17 lines
---
 package/kvazaar/kvazaar.mk | 1 +
 1 file changed, 1 insertion(+)
package/kvazaar/kvazaar.mk +1 -0
index 30b8bda..f9149a7 100644
@@ -10,6 +10,7 @@ KVAZAAR_LICENSE = LGPL-2.1+
 KVAZAAR_LICENSE_FILES = COPYING
 KVAZAAR_AUTORECONF = YES
 KVAZAAR_INSTALL_STAGING = YES
+KVAZAAR_DEPENDENCIES = host-pkgconf
 KVAZAAR_CONF_OPTS = --without-cryptopp
 
 $(eval $(autotools-package))
Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
#6 lore raw

PATCH 1/3 package/kvazaar: add host-pkgconf dependency

In reply to Romain Naour

Hello,

Quoted 9 lines · Romain Naour

The build system use PKG_CHECK_MODULES.

checking pkg-config is at least version 0.9.0... ./configure: line 16886: output/host/usr/bin/pkg-config: No such file or directory no

Signed-off-by Romain Naour <[email protected]>
---
 package/kvazaar/kvazaar.mk | 1 +
 1 file changed, 1 insertion(+)

All three patches applied to master. Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com