Skip to contentSkip to conversation

toolchain-external: drop reference to non-existing variable

PATCH New Baruch Siach 2 participants 2 messages Jul 6, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 toolchain-external: drop reference to non-existing variable

Commit 32bec8ee2fb0 (toolchain-external: copy ld*.so* for all C libraries) removed the definition of TOOLCHAIN_EXTERNAL_MUSL_LD_LINK. Remove also the reference to it.

Cc Thomas Petazzoni <[email protected]>

---
This addresses my comment on the patch.
http://lists.busybox.net/pipermail/buildroot/2017-July/195993.html

---
 toolchain/toolchain-external/pkg-toolchain-external.mk | 4 ----
 1 file changed, 4 deletions(-)
toolchain/toolchain-external/pkg-toolchain-external.mk +0 -4
index 33449d37a5ec..1c5a5790f0e1 100644
@@ -561,10 +561,6 @@ define $(2)_INSTALL_STAGING_CMDS
 	$$(TOOLCHAIN_EXTERNAL_INSTALL_GDBINIT)
 endef
 
-ifeq ($$(BR2_TOOLCHAIN_EXTERNAL_MUSL),y)
-$(2)_POST_INSTALL_STAGING_HOOKS += TOOLCHAIN_EXTERNAL_MUSL_LD_LINK
-endif
-
 # Even though we're installing things in both the staging, the host
 # and the target directory, we do everything within the
 # install-staging step, arbitrarily.
Signature · 1 line
2.13.2
#1 lore raw

PATCH 1/1 toolchain-external: drop reference to non-existing variable

Hello,

Quoted 9 lines · Baruch Siach

Commit 32bec8ee2fb0 (toolchain-external: copy ld*.so* for all C libraries) removed the definition of TOOLCHAIN_EXTERNAL_MUSL_LD_LINK. Remove also the reference to it.

Cc Thomas Petazzoni <[email protected]>

---
This addresses my comment on the patch.
http://lists.busybox.net/pipermail/buildroot/2017-July/195993.html

Sorry, I saw your comment, and it was definitely right. But we have been reviewing/merging so many patches, and discussing so many topics that I forgot to take into account your comment.

I've applied your patch now. Thanks for reviewing and fixing this mistake.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com