Skip to contentSkip to conversation

libtomcrypt: bump to version 1.18.0-rc1

PATCH New Francois Perrad 4 participants 5 messages Jul 6, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libtomcrypt: bump to version 1.18.0-rc1

---
 package/libtomcrypt/libtomcrypt.hash | 2 +-
 package/libtomcrypt/libtomcrypt.mk   | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)
package/libtomcrypt/libtomcrypt.hash +1 -1
index 562016d5..932052e8 100644
@@ -1,2 +1,2 @@
 # Locally computed
-sha256  e33b47d77a495091c8703175a25c8228aff043140b2554c08a3c3cd71f79d116  crypt-1.17.tar.bz2
+sha256  943af136e6c624371659dc6c98a2d749ea45912628717b72e4f8894339709b20  crypt-1.18.0-rc1.tar.xz
package/libtomcrypt/libtomcrypt.mk +3 -3
index 8cc02b28..ee0c68e8 100644
@@ -4,9 +4,9 @@
 #
 ################################################################################
 
-LIBTOMCRYPT_VERSION = 1.17
-LIBTOMCRYPT_SITE = https://github.com/libtom/libtomcrypt/releases/download/$(LIBTOMCRYPT_VERSION)
-LIBTOMCRYPT_SOURCE = crypt-$(LIBTOMCRYPT_VERSION).tar.bz2
+LIBTOMCRYPT_VERSION = 1.18.0-rc1
+LIBTOMCRYPT_SITE = https://github.com/libtom/libtomcrypt/releases/download/v$(LIBTOMCRYPT_VERSION)
+LIBTOMCRYPT_SOURCE = crypt-$(LIBTOMCRYPT_VERSION).tar.xz
 LIBTOMCRYPT_LICENSE = WTFPL
 LIBTOMCRYPT_LICENSE_FILES = LICENSE
 LIBTOMCRYPT_INSTALL_STAGING = YES
Signature · 1 line
2.11.0
#1 lore raw

PATCH 1/1 libtomcrypt: bump to version 1.18.0-rc1

Hello,

package/libtomcrypt/libtomcrypt.mk line 7

Quoted 4 lines · Francois Perrad
package/libtomcrypt/libtomcrypt.mk +1 -3
-LIBTOMCRYPT_VERSION = 1.17
-LIBTOMCRYPT_SITE = https://github.com/libtom/libtomcrypt/releases/download/$(LIBTOMCRYPT_VERSION)
-LIBTOMCRYPT_SOURCE = crypt-$(LIBTOMCRYPT_VERSION).tar.bz2
+LIBTOMCRYPT_VERSION = 1.18.0-rc1

Why would we upgrade to a release candidate version?

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 libtomcrypt: bump to version 1.18.0-rc1

2017-07-06 20:25 GMT+02:00 Thomas Petazzoni <
[email protected]>:

Quoted 4 lines

Hello,

On Thu, 6 Jul 2017 19:54:56 +0200, Francois Perrad wrote:

Quoted 9 lines

Review

Quoted 2 lines
(quoted diff) +0 -2
-LIBTOMCRYPT_VERSION = 1.17
-LIBTOMCRYPT_SITE = https://github.com/libtom/

libtomcrypt/releases/download/$(LIBTOMCRYPT_VERSION)

package/libtomcrypt/libtomcrypt.mk line 7

Quoted 2 lines
package/libtomcrypt/libtomcrypt.mk +1 -1
-LIBTOMCRYPT_SOURCE = crypt-$(LIBTOMCRYPT_VERSION).tar.bz2
+LIBTOMCRYPT_VERSION = 1.18.0-rc1

Why would we upgrade to a release candidate version?

It's a good way to test it (with autobuilder).
The dev of libtomcrypt is very slow, 1.17 was released on 25 Dec 2015.

Note: in BR, many packages use a Git hash commit as version/tag.

Fran?ois

Quoted 10 lines

Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20170706/f5dfee5c/attachment.html>

#3 lore raw

PATCH 1/1 libtomcrypt: bump to version 1.18.0-rc1

Hello,

Quoted 3 lines · Fran?ois Perrad
Quoted 2 lines

Why would we upgrade to a release candidate version?

It's a good way to test it (with autobuilder).

Buildroot is not really meant to test release candidates of upstream packages, especially when the final release is unlikely to be released before the next Buildroot release will be cut.

Quoted 1 line

Note: in BR, many packages use a Git hash commit as version/tag.

And every time because there's a good reason: no stable release at all, or the last stable release has some issue that cannot be fixed by just backporting a few patches.

Here there are no issues, and you propose to bump to a release candidate. I really don't think we want to do this.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
#4 lore raw

PATCH 1/1 libtomcrypt: bump to version 1.18.0-rc1

Quoted 7 lines · Thomas Petazzoni

Hello,

Quoted 3 lines · Fran?ois Perrad
Quoted 2 lines

Why would we upgrade to a release candidate version?

It's a good way to test it (with autobuilder).

If you want to invest is something like that, you can set up an autobuilder
instance and define some _OVERRIDE_SRCDIR in your local.mk. But don't push those build results to autobuild.buildroot.org!

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF