Skip to contentSkip to conversation

crypto: brcm: add NULL check on of_match_device() return value

PATCH In review Gustavo A. R. Silva 2 participants 2 messages Jul 7, 2017 – Jul 18, 2017 Crypto API

lore
Share & tools
lore

Gustavo A. R. Silva

author
#0 lore raw

PATCH 1/1 crypto: brcm: add NULL check on of_match_device() return value

Check return value from call to of_match_device()
in order to prevent a NULL pointer dereference.

In case of NULL print error message and return -ENODEV

Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 drivers/crypto/bcm/cipher.c | 5 +++++
 1 file changed, 5 insertions(+)
drivers/crypto/bcm/cipher.c +5 -0
index 9cfd36c..f1a826f 100644
@@ -4813,6 +4813,11 @@ static int spu_dt_read(struct platform_device *pdev)
 	int err;
 
 	match = of_match_device(of_match_ptr(bcm_spu_dt_ids), dev);
+	if (!match) {
+		dev_err(&pdev->dev, "Failed to match device\n");
+		return -ENODEV;
+	}
+
 	matched_spu_type = match->data;
 
 	if (iproc_priv.spu.num_spu > 1) {
Signature · 1 line
2.5.0
maintainer
#1 lore raw
Quoted 6 lines · Gustavo A. R. Silva

Check return value from call to of_match_device()
in order to prevent a NULL pointer dereference.

In case of NULL print error message and return -ENODEV

Signed-off-by Gustavo A. R. Silva <[email protected]>

Patch applied. Thanks.

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt