video/mbx: constify fb_fix_screeninfo and fb_var_screeninfo structures
PATCH 1/1 video/mbx: constify fb_fix_screeninfo and fb_var_screeninfo structures
These structures are only used to copy into other structures, so declare them as const.
This issue was detected using Coccinelle and the following semantic patch:
@r disable optional_qualifier@
identifier i;
position p;
@@
static struct fb_fix_screeninfo i@p = { ... };
@ok@
identifier r.i;
expression e;
position p;
@@
e = i@p
@bad@
position p != {r.p,ok.p};
identifier r.i;
struct fb_fix_screeninfo e;
@@
e@i@p
@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
struct fb_fix_screeninfo i = { ... };
The semantic patch for fb_var_screeninfo is analogous.
--- drivers/video/fbdev/mbx/mbxfb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/video/fbdev/mbx/mbxfb.c +2 -2
@@ -79,7 +79,7 @@ struct mbxfb_info { }; -static struct fb_var_screeninfo mbxfb_default = { +static const struct fb_var_screeninfo mbxfb_default = { .xres =640 , .yres =480 , .xres_virtual =640 ,
@@ -102,7 +102,7 @@ static struct fb_var_screeninfo mbxfb_default = { .sync = FB_SYNC_HOR_HIGH_ACT | FB_SYNC_VERT_HIGH_ACT, }; -static struct fb_fix_screeninfo mbxfb_fix = { +static const struct fb_fix_screeninfo mbxfb_fix = { .id ="MBX" , .type =FB_TYPE_PACKED_PIXELS , .visual =FB_VISUAL_TRUECOLOR ,
Signature · 1 line
2.5.0
Quoted 32 lines · Gustavo A. R. Silva
These structures are only used to copy into other structures, so declare them as const.
This issue was detected using Coccinelle and the following semantic patch:
@r disable optional_qualifier@
identifier i;
position p;
@@
static structfb_fix_screeninfoi@p = { ... };@ok@
identifier r.i;
expression e;
position p;
@@
e = i@p@bad@
position p != {r.p,ok.p};
identifier r.i;
structfb_fix_screeninfoe;
@@
e@i@p@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
structfb_fix_screeninfoi = { ... };
Quoted 3 lines
The semantic patch for
fb_var_screeninfois analogous.Signed-off-by Gustavo A. R. Silva <[email protected]>
Patch queued for 4.14, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics