manual: patches are not applied for SITE_METHOD = local
PATCH 1/1 manual: patches are not applied for SITE_METHOD = local
We had several remarks on the mailing list of users that were surprised that patches were not applied for packages whose SITE_METHOD is local. So document this.
Note that for OVERRIDE_SRCDIR itself it is already documented:
When Buildroot finds that for a given package, an <pkg>_OVERRIDE_SRCDIR has been defined, it will no longer attempt to download, extract and patch the package. Instead, it will directly use the source code available in in the specified directory.
--- docs/manual/adding-packages-generic.txt | 5 ++++- docs/manual/adding-packages-hooks.txt | 1 + 2 files changed, 5 insertions(+), 1 deletion(-)
docs/manual/adding-packages-generic.txt +4 -1
@@ -315,7 +315,10 @@ information is (assuming the package name is +libfoo+) : ** +local+ for a local source code directory. One should use this when +LIBFOO_SITE+ specifies a local directory path containing the package source code. Buildroot copies the contents of the - source directory into the package's build directory. + source directory into the package's build directory. Note that + for +local+ packages, no patches are applied. If you need to + still patch the source code, use +LIBFOO_POST_RSYNC_HOOKS+, see + xref:hooks-rsync[]. * +LIBFOO_GIT_SUBMODULES+ can be set to +YES+ to create an archive with the git submodules in the repository. This is only available
docs/manual/adding-packages-hooks.txt +1 -0
@@ -59,6 +59,7 @@ endef LIBFOO_POST_PATCH_HOOKS += LIBFOO_POST_PATCH_FIXUP ---------------------- +[[hooks-rsync]] ==== Using the +POST_RSYNC+ hook The +POST_RSYNC+ hook is run only for packages that use a local source, either through the +local+ site method or the +OVERRIDE_SRCDIR+
Signature · 1 line
2.13.2
Thomas Petazzoni
AppliedPATCH 1/1 manual: patches are not applied for SITE_METHOD = local
Hello,
Quoted 4 lines · Arnout Vandecappelle (Essensium/Mind)
We had several remarks on the mailing list of users that were surprised that patches were not applied for packages whose
SITE_METHODis local. So document this.
Quoted 8 lines
Note that for
OVERRIDE_SRCDIRitself it is already documented:When Buildroot finds that for a given package, an <pkg>_OVERRIDE_SRCDIR has been defined, it will no longer attempt to download, extract and patch the package. Instead, it will directly use the source code available in in the specified directory.
Applied, thanks!
docs/manual/adding-packages-generic.txt information is (assuming the package name is +libfoo+) : · line 321
Quoted 13 lines
docs/manual/adding-packages-generic.txt +4
-1@@ -315,7 +315,10 @@ information is (assuming the package name is +libfoo+) : ** +local+ for a local source code directory. One should use this when +LIBFOO_SITE+ specifies a local directory path containing the package source code. Buildroot copies the contents of the - source directory into the package's build directory. + source directory into the package's build directory. Note that + for +local+ packages, no patches are applied. If you need to + still patch the source code, use +LIBFOO_POST_RSYNC_HOOKS+, see + xref:hooks-rsync[].
The reason why "local" packages don't see their patches applied is because we assume that if the source code is available locally, you'd better have the patches applied to it directly. But OK, we can still point people to the rsynch hooks if they really think they need some patching.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
PATCH 1/1 manual: patches are not applied for SITE_METHOD = local
In reply to Arnout Vandecappelle (Essensium/Mind)Quoted 6 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Arnout" == Arnout Vandecappelle (Essensium/Mind) <[email protected]> writes:
We had several remarks on the mailing list of users that were surprised that patches were not applied for packages whose
SITE_METHODis local. So document this.
Quoted 8 lines
Note that for
OVERRIDE_SRCDIRitself it is already documented:When Buildroot finds that for a given package, an <pkg>_OVERRIDE_SRCDIR has been defined, it will no longer attempt to download, extract and patch the package. Instead, it will directly use the source code available in in the specified directory.
Committed to 2017.02.x and 2017.05.x, thanks.
Signature · 1 line
Bye, Peter Korsgaard