Skip to contentSkip to conversation

usb: gadget: legacy: dbgp: compress return logic into one line

PATCH New Gustavo A. R. Silva 1 participant 1 message Jul 10, 2017 USB

lore
Share & tools
lore

Gustavo A. R. Silva

author
#0 lore raw

PATCH 1/1 usb: gadget: legacy: dbgp: compress return logic into one line

Simplify return logic to avoid unnecessary variable declaration and assignment.

This issue was detected using Coccinelle and the following semantic patch:

@@
local idexpression ret;
expression e;
@@

-ret =
+return

     e;

-return ret;

Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 drivers/usb/gadget/legacy/dbgp.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/usb/gadget/legacy/dbgp.c +2 -3
index 99ca3da..f14a5d7 100644
@@ -165,10 +165,9 @@ static int dbgp_enable_ep_req(struct usb_ep *ep)
 
 static int __enable_ep(struct usb_ep *ep, struct usb_endpoint_descriptor *desc)
 {
-	int err;
 	ep->desc = desc;
-	err = usb_ep_enable(ep);
-	return err;
+
+	return usb_ep_enable(ep);
 }
 
 static int dbgp_enable_ep(void)
Signature · 1 line
2.5.0