usb: gadget: legacy: ncm: compress return logic into one line

PATCH New Gustavo A. R. Silva 1 participant 1 message Jul 10, 2017 USB

lore

Share & tools

lore

Gustavo A. R. Silva

author

2017-07-10 02:56 UTC #0 lore raw

PATCH 1/1 usb: gadget: legacy: ncm: compress return logic into one line

Simplify return logic to avoid unnecessary variable assignment.

This issue was detected using Coccinelle and the following semantic patch:

@@
local idexpression ret;
expression e;
@@

-ret =
+return

e;

-return ret;

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
 drivers/usb/gadget/legacy/ncm.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

drivers/usb/gadget/legacy/ncm.c +2 -4

index 0aba682..cb0d84f 100644
@@ -106,10 +106,8 @@ static int ncm_do_config(struct usb_configuration *c)
 	}
 
 	f_ncm = usb_get_function(f_ncm_inst);
-	if (IS_ERR(f_ncm)) {
-		status = PTR_ERR(f_ncm);
-		return status;
-	}
+	if (IS_ERR(f_ncm))
+		return PTR_ERR(f_ncm);
 
 	status = usb_add_function(c, f_ncm);
 	if (status < 0) {

Signature · 1 line

2.5.0