Skip to contentSkip to conversation

usb: gadget: udc-xilinx: compress return logic into one line

PATCH In review Gustavo A. R. Silva 2 participants 2 messages Jul 10, 2017

Subsystems (2)
USB Arm/Zynq architecture
lore
Share & tools
lore

Gustavo A. R. Silva

author
#0 lore raw

PATCH 1/1 usb: gadget: udc-xilinx: compress return logic into one line

Simplify return logic to avoid unnecessary variable assignment.

This issue was detected using Coccinelle and the following semantic patch:

@@
local idexpression ret;
expression e;
@@

-ret =
+return

     e;

-return ret;

Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 drivers/usb/gadget/udc/udc-xilinx.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/usb/gadget/udc/udc-xilinx.c +2 -3
index de207a9..552389d 100644
@@ -1217,14 +1217,13 @@ static const struct usb_ep_ops xusb_ep_ops = {
 static int xudc_get_frame(struct usb_gadget *gadget)
 {
 	struct xusb_udc *udc;
-	int frame;
 
 	if (!gadget)
 		return -ENODEV;
 
 	udc = to_udc(gadget);
-	frame = udc->read_fn(udc->addr + XUSB_FRAMENUM_OFFSET);
-	return frame;
+
+	return udc->read_fn(udc->addr + XUSB_FRAMENUM_OFFSET);
 }
 
 /**
Signature · 1 line
2.5.0
Acked-by on v1 1/1
#1 lore raw
Quoted 32 lines · Gustavo A. R. Silva

Simplify return logic to avoid unnecessary variable assignment.

This issue was detected using Coccinelle and the following semantic patch:

@@
local idexpression ret;
expression e;
@@

(quoted diff) +1 -2
-ret =
+return
     e;
-return ret;
Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 drivers/usb/gadget/udc/udc-xilinx.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/usb/gadget/udc/udc-xilinx.c +0 -1
index de207a9..552389d 100644
@@ -1217,14 +1217,13 @@ static const struct usb_ep_ops xusb_ep_ops = {
 static int xudc_get_frame(struct usb_gadget *gadget)
 {
 	struct xusb_udc *udc;
-	int frame;
 
 	if (!gadget)

drivers/usb/gadget/udc/udc-xilinx.c static const struct usb_ep_ops xusb_ep_ops = { · line 1229

Quoted 10 lines
drivers/usb/gadget/udc/udc-xilinx.c +2 -2
 		return -ENODEV;
 
 	udc = to_udc(gadget);
-	frame = udc->read_fn(udc->addr + XUSB_FRAMENUM_OFFSET);
-	return frame;
+
+	return udc->read_fn(udc->addr + XUSB_FRAMENUM_OFFSET);
 }
 
 /**
Acked-by Michal Simek <[email protected]>

Thanks,
Michal