Skip to contentSkip to conversation

nvmet: avoid unneeded assignment of submit_bio return value

PATCH New Max Gurtovoy 2 participants 2 messages Jul 10, 2017

Subsystems (2)
NVMe NVMe target
lore
Share & tools
lore

Max Gurtovoy

author
#0 lore raw

PATCH 1/1 nvmet: avoid unneeded assignment of submit_bio return value

We actually using the cookie returned from the last submit_bio call.

Signed-off-by Max Gurtovoy <maxg at mellanox.com>
---
 drivers/nvme/target/io-cmd.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/nvme/target/io-cmd.c +1 -1
index 4012879..3b4d47a 100644
@@ -85,7 +85,7 @@ static void nvmet_execute_rw(struct nvmet_req *req)
 			bio_set_op_attrs(bio, op, op_flags);
 
 			bio_chain(bio, prev);
-			cookie = submit_bio(prev);
+			submit_bio(prev);
 		}
 
 		sector += sg->length >> 9;
Signature · 1 line
1.7.1
maintainer
#1 lore raw

PATCH 1/1 nvmet: avoid unneeded assignment of submit_bio return value

Looks fine,

Reviewed-by Christoph Hellwig <hch at lst.de>