Skip to contentSkip to conversation

ARM: dts: imx: update snvs-poweroff mask

PATCH RESEND New Marcin Niestroj 3 participants 3 messages Jul 4, 2017 – Jul 13, 2017

Subsystems (2)
Device tree bindings Arm i.MX and Layerscape
lore
Share & tools
lore

Marcin Niestroj

author
#0 lore raw

PATCH RESEND 1/1 ARM: dts: imx: update snvs-poweroff mask

From: Guy Shapiro <[email protected]>

Make the syscon-poweroff driver change only the shutdown bits on the SNVS_LP control register.

This change fixes an issue with the RTC wakeup alarm, that was previously disabled during power off.

Signed-off-by Guy Shapiro <[email protected]>
Reviewed-by Marcin Niestroj <[email protected]>

---
Hi,

This is a resend of second patch from patch series [1]. First patch is already in v4.12, but this one was not applied.

Tested on imx6ul board. Without that patch RTC time is "frozen" during power-down state. With that patch RTC shows proper time after exiting from power-down.

[1] https://www.spinics.net/lists/arm-kernel/msg561152.html

 arch/arm/boot/dts/imx6qdl.dtsi | 1 +
 arch/arm/boot/dts/imx6sl.dtsi  | 1 +
 arch/arm/boot/dts/imx6sx.dtsi  | 1 +
 arch/arm/boot/dts/imx6ul.dtsi  | 1 +
 arch/arm/boot/dts/imx7s.dtsi   | 1 +
 5 files changed, 5 insertions(+)
arch/arm/boot/dts/imx6qdl.dtsi +1 -0
index e426faa9c243..f81f38700c88 100644
@@ -766,6 +766,7 @@
 					compatible = "syscon-poweroff";
 					regmap = <&snvs>;
 					offset = <0x38>;
+					value = <0x60>;
 					mask = <0x60>;
 					status = "disabled";
 				};
arch/arm/boot/dts/imx6sl.dtsi +1 -0
index cc9572ea2860..2c2a90f2c8fc 100644
@@ -652,6 +652,7 @@
 					compatible = "syscon-poweroff";
 					regmap = <&snvs>;
 					offset = <0x38>;
+					value = <0x60>;
 					mask = <0x60>;
 					status = "disabled";
 				};
arch/arm/boot/dts/imx6sx.dtsi +1 -0
index 3f1416be4c36..a7c6ca1638c6 100644
@@ -707,6 +707,7 @@
 					compatible = "syscon-poweroff";
 					regmap = <&snvs>;
 					offset = <0x38>;
+					value = <0x60>;
 					mask = <0x60>;
 					status = "disabled";
 				};
arch/arm/boot/dts/imx6ul.dtsi +1 -0
index b9d7d2d09402..d3431a796716 100644
@@ -613,6 +613,7 @@
 					compatible = "syscon-poweroff";
 					regmap = <&snvs>;
 					offset = <0x38>;
+					value = <0x60>;
 					mask = <0x60>;
 					status = "disabled";
 				};
arch/arm/boot/dts/imx7s.dtsi +1 -0
index c4f12fd2e044..216fbcb13bf5 100644
@@ -535,6 +535,7 @@
 					compatible = "syscon-poweroff";
 					regmap = <&snvs>;
 					offset = <0x38>;
+					value = <0x60>;
 					mask = <0x60>;
 				};
Signature · 1 line
2.13.2
reviewer
#1 lore raw

PATCH RESEND 1/1 ARM: dts: imx: update snvs-poweroff mask

Quoted 10 lines · Marcin Niestroj

From: Guy Shapiro <[email protected]>

Make the syscon-poweroff driver change only the shutdown bits on the SNVS_LP control register.

This change fixes an issue with the RTC wakeup alarm, that was previously disabled during power off.

Signed-off-by Guy Shapiro <[email protected]>
Reviewed-by Marcin Niestroj <[email protected]>
Reviewed-by Fabio Estevam <[email protected]>
Applied
#2 lore raw

PATCH RESEND 1/1 ARM: dts: imx: update snvs-poweroff mask

In reply to Marcin Niestroj
Quoted 10 lines · Marcin Niestroj

From: Guy Shapiro <[email protected]>

Make the syscon-poweroff driver change only the shutdown bits on the SNVS_LP control register.

This change fixes an issue with the RTC wakeup alarm, that was previously disabled during power off.

Signed-off-by Guy Shapiro <[email protected]>
Reviewed-by Marcin Niestroj <[email protected]>

Applied, thanks.