Skip to contentSkip to conversation

br toolchain: gcc5.4 bugfix libsanitizer powerpc

PATCH New Matt Weber 3 participants 6 messages Jul 13, 2017

lore
Share & tools
lore

Matt Weber

author
#0 lore raw

PATCH 1/1 br toolchain: gcc5.4 bugfix libsanitizer powerpc

Fixes a missing include of signal.h

This breaks when building gcc 5.4.0 with target_platform=powerpc-unknown-linux-gnu with glibc 2.25:

../../../../gcc-host/libsanitizer/asan/asan_linux.cc: In function 'bool __asan::AsanInterceptsSignal(int)':
../../../../gcc-host/libsanitizer/asan/asan_linux.cc:222:20: error: 'SIGSEGV' was not declared in this scope
return signum == SIGSEGV && common_flags()->handle_segv;

This applies only to gcc-5-branch, the code has been reworked for gcc 6.

Resolves Bug: https://bugs.busybox.net/show_bug.cgi?id=10061

Upstream: https://patchwork.ozlabs.org/patch/725596/

---
 .../942-asan-fix-missing-include-signal-h.patch    | 40 ++++++++++++++++++++++
 1 file changed, 40 insertions(+)
 create mode 100644 package/gcc/5.4.0/942-asan-fix-missing-include-signal-h.patch
package/gcc/5.4.0/942-asan-fix-missing-include-signal-h.patch new file +40 -0
new file mode 100644
index 0000000..2fbc497
@@ -0,0 +1,40 @@
+From patchwork Wed Feb  8 11:07:16 2017
+Content-Type: text/plain; charset="utf-8"
+MIME-Version: 1.0
+Content-Transfer-Encoding: 7bit
+Subject: asan: fix missing include of signal.h
+From: Rolf Eike Beer <[email protected]>
+X-Patchwork-Id: 725596
+Message-Id: <6824253.3U2boEivI2@devpool21>
+To: gcc-patches at gcc.gnu.org
+Date: Wed, 08 Feb 2017 12:07:16 +0100
+
+>From 205aa8e97bab553e5e6fe45896325e97962de704 Mon Sep 17 00:00:00 2001
+From: Rolf Eike Beer <[email protected]>
+Date: Wed, 8 Feb 2017 11:42:52 +0100
+Subject: [PATCH] asan: fix missing include of signal.h
+
+This breaks when building gcc 5.4.0 with 
+target_platform=powerpc-unknown-linux-gnu with glibc 2.25:
+
+../../../../gcc-host/libsanitizer/asan/asan_linux.cc: In function 'bool __asan::AsanInterceptsSignal(int)':
+../../../../gcc-host/libsanitizer/asan/asan_linux.cc:222:20: error: 'SIGSEGV' was not declared in this scope
+   return signum == SIGSEGV && common_flags()->handle_segv;
+
+This applies only to gcc-5-branch, the code has been reworked for gcc 6.
+---
+ libsanitizer/asan/asan_linux.cc | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/libsanitizer/asan/asan_linux.cc b/libsanitizer/asan/asan_linux.cc
+index c504168..59087b9 100644
+--- a/libsanitizer/asan/asan_linux.cc
++++ b/libsanitizer/asan/asan_linux.cc
+@@ -29,6 +29,7 @@
+ #include <dlfcn.h>
+ #include <fcntl.h>
+ #include <pthread.h>
++#include <signal.h>
+ #include <stdio.h>
+ #include <unistd.h>
+ #include <unwind.h>
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 br toolchain: gcc5.4 bugfix libsanitizer powerpc

Hi Matt,

Quoted 9 lines · Matt Weber

Fixes a missing include of signal.h

This breaks when building gcc 5.4.0 with target_platform=powerpc-unknown-linux-gnu with glibc 2.25:

../../../../gcc-host/libsanitizer/asan/asan_linux.cc: In function 'bool __asan::AsanInterceptsSignal(int)':
../../../../gcc-host/libsanitizer/asan/asan_linux.cc:222:20: error: 'SIGSEGV' was not declared in this scope
return signum == SIGSEGV && common_flags()->handle_segv;

Quoted 5 lines

This applies only to gcc-5-branch, the code has been reworked for gcc 6.

Resolves Bug: https://bugs.busybox.net/show_bug.cgi?id=10061

Upstream: https://patchwork.ozlabs.org/patch/725596/

Mentioning the Buildroot bugzilla issue that this patch fixes would be nice.

Quoted 27 lines
---
 .../942-asan-fix-missing-include-signal-h.patch    | 40 ++++++++++++++++++++++
 1 file changed, 40 insertions(+)
 create mode 100644 package/gcc/5.4.0/942-asan-fix-missing-include-signal-h.patch
package/gcc/5.4.0/942-asan-fix-missing-include-signal-h.patch new file +14 -0
new file mode 100644
index 0000000..2fbc497
@@ -0,0 +1,40 @@
+From patchwork Wed Feb  8 11:07:16 2017
+Content-Type: text/plain; charset="utf-8"
+MIME-Version: 1.0
+Content-Transfer-Encoding: 7bit
+Subject: asan: fix missing include of signal.h
+From: Rolf Eike Beer <[email protected]>
+X-Patchwork-Id: 725596
+Message-Id: <6824253.3U2boEivI2@devpool21>
+To: gcc-patches at gcc.gnu.org
+Date: Wed, 08 Feb 2017 12:07:16 +0100
+
+>From 205aa8e97bab553e5e6fe45896325e97962de704 Mon Sep 17 00:00:00 2001
+From: Rolf Eike Beer <[email protected]>
+Date: Wed, 8 Feb 2017 11:42:52 +0100

package/gcc/5.4.0/942-asan-fix-missing-include-signal-h.patch line 24

Quoted 10 lines
package/gcc/5.4.0/942-asan-fix-missing-include-signal-h.patch new file +10 -0
+Subject: [PATCH] asan: fix missing include of signal.h
+
+This breaks when building gcc 5.4.0 with 
+target_platform=powerpc-unknown-linux-gnu with glibc 2.25:
+
+../../../../gcc-host/libsanitizer/asan/asan_linux.cc: In function 'bool __asan::AsanInterceptsSignal(int)':
+../../../../gcc-host/libsanitizer/asan/asan_linux.cc:222:20: error: 'SIGSEGV' was not declared in this scope
+   return signum == SIGSEGV && common_flags()->handle_segv;
+
+This applies only to gcc-5-branch, the code has been reworked for gcc 6.

Your sign-off is missing.

Quoted 6 lines
package/gcc/5.4.0/942-asan-fix-missing-include-signal-h.patch new file +6 -0
+---
+ libsanitizer/asan/asan_linux.cc | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/libsanitizer/asan/asan_linux.cc b/libsanitizer/asan/asan_linux.cc
+index c504168..59087b9 100644

package/gcc/5.4.0/942-asan-fix-missing-include-signal-h.patch line 40

Quoted 10 lines
package/gcc/5.4.0/942-asan-fix-missing-include-signal-h.patch new file +10 -0
+--- a/libsanitizer/asan/asan_linux.cc
++++ b/libsanitizer/asan/asan_linux.cc
+@@ -29,6 +29,7 @@
+ #include <dlfcn.h>
+ #include <fcntl.h>
+ #include <pthread.h>
++#include <signal.h>
+ #include <stdio.h>
+ #include <unistd.h>
+ #include <unwind.h>

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
#2 lore raw

PATCH 1/1 br toolchain: gcc5.4 bugfix libsanitizer powerpc

Baruch,

Quoted 52 lines · Baruch Siach

Hi Matt,

Quoted 9 lines · Matt Weber

Fixes a missing include of signal.h

This breaks when building gcc 5.4.0 with target_platform=powerpc-unknown-linux-gnu with glibc 2.25:

../../../../gcc-host/libsanitizer/asan/asan_linux.cc: In function 'bool __asan::AsanInterceptsSignal(int)':
../../../../gcc-host/libsanitizer/asan/asan_linux.cc:222:20: error: 'SIGSEGV' was not declared in this scope
return signum == SIGSEGV && common_flags()->handle_segv;

Quoted 5 lines

This applies only to gcc-5-branch, the code has been reworked for gcc 6.

Resolves Bug: https://bugs.busybox.net/show_bug.cgi?id=10061

Upstream: https://patchwork.ozlabs.org/patch/725596/

Mentioning the Buildroot bugzilla issue that this patch fixes would be nice.

Quoted 31 lines
---
 .../942-asan-fix-missing-include-signal-h.patch    | 40 ++++++++++++++++++++++
 1 file changed, 40 insertions(+)
 create mode 100644 package/gcc/5.4.0/942-asan-fix-missing-include-signal-h.patch
package/gcc/5.4.0/942-asan-fix-missing-include-signal-h.patch new file +18 -0
new file mode 100644
index 0000000..2fbc497
@@ -0,0 +1,40 @@
+From patchwork Wed Feb  8 11:07:16 2017
+Content-Type: text/plain; charset="utf-8"
+MIME-Version: 1.0
+Content-Transfer-Encoding: 7bit
+Subject: asan: fix missing include of signal.h
+From: Rolf Eike Beer <[email protected]>
+X-Patchwork-Id: 725596
+Message-Id: <6824253.3U2boEivI2@devpool21>
+To: gcc-patches at gcc.gnu.org
+Date: Wed, 08 Feb 2017 12:07:16 +0100
+
+>From 205aa8e97bab553e5e6fe45896325e97962de704 Mon Sep 17 00:00:00 2001
+From: Rolf Eike Beer <[email protected]>
+Date: Wed, 8 Feb 2017 11:42:52 +0100
+Subject: [PATCH] asan: fix missing include of signal.h
+
+This breaks when building gcc 5.4.0 with
+target_platform=powerpc-unknown-linux-gnu with glibc 2.25:
Quoted 8 lines

package/gcc/5.4.0/942-asan-fix-missing-include-signal-h.patch line 24

Quoted 6 lines
package/gcc/5.4.0/942-asan-fix-missing-include-signal-h.patch new file +6 -0
+
+../../../../gcc-host/libsanitizer/asan/asan_linux.cc: In function 'bool __asan::AsanInterceptsSignal(int)':
+../../../../gcc-host/libsanitizer/asan/asan_linux.cc:222:20: error: 'SIGSEGV' was not declared in this scope
+   return signum == SIGSEGV && common_flags()->handle_segv;
+
+This applies only to gcc-5-branch, the code has been reworked for gcc 6.

Your sign-off is missing.

I had assumed if I used the patch as is I would leave it without mods. I can add the bug tracker url and my signed off.

Thanks!

Quoted 25 lines
Quoted 8 lines
package/gcc/5.4.0/942-asan-fix-missing-include-signal-h.patch new file +6 -0
+---
+ libsanitizer/asan/asan_linux.cc | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/libsanitizer/asan/asan_linux.cc b/libsanitizer/asan/asan_linux.cc
+index c504168..59087b9 100644

package/gcc/5.4.0/942-asan-fix-missing-include-signal-h.patch line 40

Quoted 10 lines
package/gcc/5.4.0/942-asan-fix-missing-include-signal-h.patch new file +10 -0
+--- a/libsanitizer/asan/asan_linux.cc
++++ b/libsanitizer/asan/asan_linux.cc
+@@ -29,6 +29,7 @@
+ #include <dlfcn.h>
+ #include <fcntl.h>
+ #include <pthread.h>
++#include <signal.h>
+ #include <stdio.h>
+ #include <unistd.h>
+ #include <unwind.h>

baruch

--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

Signature · 8 lines
Matthew L Weber / Pr Software Engineer
Airborne Information Systems / Security Systems and Software / Secure Platforms
MS 131-100, C Ave NE, Cedar Rapids, IA, 52498, USA
www.rockwellcollins.com

Note: Any Export License Required Information and License Restricted
Third Party Intellectual Property (TPIP) content must be encrypted and
sent to matthew.weber at corp.rockwellcollins.com.
#3 lore raw

PATCH 1/1 br toolchain: gcc5.4 bugfix libsanitizer powerpc

Hello,

Quoted 7 lines · Matthew Weber
Quoted 3 lines
Quoted 1 line

+This applies only to gcc-5-branch, the code has been reworked for gcc 6.

Your sign-off is missing.

I had assumed if I used the patch as is I would leave it without mods. I can add the bug tracker url and my signed off.

Please add your SoB and the bug tracker reference.

Also, does this issue applies to gcc 4.9 as well ?

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
#4 lore raw

PATCH 1/1 br toolchain: gcc5.4 bugfix libsanitizer powerpc

Thomas,

Quoted 9 lines · Thomas Petazzoni

Hello,

Quoted 5 lines · Matthew Weber
Quoted 3 lines
Quoted 1 line

+This applies only to gcc-5-branch, the code has been reworked for gcc 6.

Your sign-off is missing.

Quoted 7 lines
Quoted 2 lines

I had assumed if I used the patch as is I would leave it without mods. I can add the bug tracker url and my signed off.

Please add your SoB and the bug tracker reference.

Also, does this issue applies to gcc 4.9 as well ?

I'll check, we were using earlier versions of 5.4 and the bump broke us. I'll find the point it was introduced and add a comment.

Matt

#5 lore raw

PATCH 1/1 br toolchain: gcc5.4 bugfix libsanitizer powerpc

Thomas, Baruch,

Quoted 16 lines · Matthew Weber

Thomas,

Quoted 12 lines · Thomas Petazzoni

Hello,

Quoted 7 lines · Matthew Weber
Quoted 3 lines
Quoted 1 line

+This applies only to gcc-5-branch, the code has been reworked for gcc 6.

Your sign-off is missing.

I had assumed if I used the patch as is I would leave it without mods. I can add the bug tracker url and my signed off.

Quoted 7 lines
Quoted 4 lines

Please add your SoB and the bug tracker reference.

Also, does this issue applies to gcc 4.9 as well ?

I'll check, we were using earlier versions of 5.4 and the bump broke us. I'll find the point it was introduced and add a comment.

Superseded by:
https://patchwork.ozlabs.org/patch/787965/