Skip to contentSkip to conversation

f2fs: include seq_file.h for sysfs.c

PATCH In review Jaegeuk Kim 3 participants 4 messages Jul 14, 2017 – Jul 18, 2017

Subsystems (2)
VFS F2FS file system
lore
Share & tools
lore

Jaegeuk Kim

author maintainer
#0 lore raw

PATCH 1/1 f2fs: include seq_file.h for sysfs.c

This patch includes seq_file.h to avoid compile error.

Signed-off-by Eric Biggers <[email protected]>
Signed-off-by Jaegeuk Kim <[email protected]>
---
 fs/f2fs/sysfs.c | 1 +
 1 file changed, 1 insertion(+)
fs/f2fs/sysfs.c +1 -0
index 9adc202fcd6f..71191d89917d 100644
@@ -11,6 +11,7 @@
  */
 #include <linux/proc_fs.h>
 #include <linux/f2fs_fs.h>
+#include <linux/seq_file.h>
 
 #include "f2fs.h"
 #include "segment.h"
Signature · 1 line
2.13.0.rc1.294.g07d810a77f-goog
maintainer
#1 lore raw

Hi Jaegeuk,

Quoted 1 line · Jaegeuk Kim

This patch includes seq_file.h to avoid compile error.

I didn't hit the error, I guess that's because we have included f2fs_fs.h in sysfs.c, the inclusion relation is like this:
- sysfs.c
- f2fs_fs.h
- pagemap.h
- fs.h
- struct seq_file

Thanks,

Quoted 20 lines
Signed-off-by Eric Biggers <[email protected]>
Signed-off-by Jaegeuk Kim <[email protected]>
---
 fs/f2fs/sysfs.c | 1 +
 1 file changed, 1 insertion(+)
fs/f2fs/sysfs.c +1 -0
index 9adc202fcd6f..71191d89917d 100644
@@ -11,6 +11,7 @@
  */
 #include <linux/proc_fs.h>
 #include <linux/f2fs_fs.h>
+#include <linux/seq_file.h>
 
 #include "f2fs.h"
 #include "segment.h"
author maintainer
#2 lore raw
Quoted 5 lines · Chao Yu

Hi Jaegeuk,

Quoted 1 line · Jaegeuk Kim

This patch includes seq_file.h to avoid compile error.

Quoted 7 lines

I didn't hit the error, I guess that's because we have included f2fs_fs.h in sysfs.c, the inclusion relation is like this:
- sysfs.c
- f2fs_fs.h
- pagemap.h
- fs.h
- struct seq_file

What about seq ops such as seq_puts?

Thanks,

Quoted 23 lines

Thanks,

Quoted 20 lines
Signed-off-by Eric Biggers <[email protected]>
Signed-off-by Jaegeuk Kim <[email protected]>
---
 fs/f2fs/sysfs.c | 1 +
 1 file changed, 1 insertion(+)
fs/f2fs/sysfs.c +1 -0
index 9adc202fcd6f..71191d89917d 100644
@@ -11,6 +11,7 @@
  */
 #include <linux/proc_fs.h>
 #include <linux/f2fs_fs.h>
+#include <linux/seq_file.h>
 
 #include "f2fs.h"
 #include "segment.h"
Reviewed-by
#3 lore raw
Quoted 14 lines · Jaegeuk Kim
Quoted 5 lines · Chao Yu

Hi Jaegeuk,

Quoted 1 line · Jaegeuk Kim

This patch includes seq_file.h to avoid compile error.

Quoted 7 lines

I didn't hit the error, I guess that's because we have included f2fs_fs.h in sysfs.c, the inclusion relation is like this:
- sysfs.c
- f2fs_fs.h
- pagemap.h
- fs.h
- struct seq_file

Quoted 1 line

What about seq ops such as seq_puts?

- sysfs.c
- segment.h
- linux/backing-dev.h
- linux/writeback.h
#ifdef CONFIG_CGROUP_WRITEBACK
- linux/cgroup.h
- linux/seq_file.h
#endif

So it looks that there is no compiling error in my environment because of CONFIG_CGROUP_WRITEBACK was defined.

Anyway, please add:

Reviewed-by Chao Yu <[email protected]>

Thanks,

Quoted 29 lines

Thanks,

Quoted 20 lines

Thanks,

Quoted 17 lines
Signed-off-by Eric Biggers <[email protected]>
Signed-off-by Jaegeuk Kim <[email protected]>
---
 fs/f2fs/sysfs.c | 1 +
 1 file changed, 1 insertion(+)
fs/f2fs/sysfs.c +1 -0
index 9adc202fcd6f..71191d89917d 100644
@@ -11,6 +11,7 @@
  */
 #include <linux/proc_fs.h>
 #include <linux/f2fs_fs.h>
+#include <linux/seq_file.h>
Quoted 3 lines

fs/f2fs/sysfs.c line 17

Quoted 3 lines
fs/f2fs/sysfs.c +0 -0
 #include "f2fs.h"
 #include "segment.h"

.