Skip to contentSkip to conversation

pulseaudio: add bluez5_utils as dependency

PATCH New Calin Crisan 3 participants 3 messages Jul 14, 2017 – Jul 19, 2017

lore
Share & tools
lore

Calin Crisan

author
#0 lore raw

PATCH 1/1 pulseaudio: add bluez5_utils as dependency

The pulseaudio configure script autodetects the presence of bluez 4.x and 5.x packages on the system and will exclude the bluetooth-related modules in their absence.

This commit ensures that bluez5_utils, if selected, are installed before pulseaudio. The same already happens for bluez_utils (4.x).

Signed-off-by Calin Crisan <ccrisan@gmail dot com>
---
 package/pulseaudio/pulseaudio.mk | 1 +
 1 file changed, 1 insertion(+)
package/pulseaudio/pulseaudio.mk +1 -0
index ddd503a9f..2f2cfbbed 100644
@@ -32,6 +32,7 @@ PULSEAUDIO_DEPENDENCIES = \
 	$(if $(BR2_PACKAGE_AVAHI_DAEMON),avahi) \
 	$(if $(BR2_PACKAGE_DBUS),dbus) \
 	$(if $(BR2_PACKAGE_BLUEZ_UTILS),bluez_utils) \
+	$(if $(BR2_PACKAGE_BLUEZ5_UTILS),bluez5_utils) \
 	$(if $(BR2_PACKAGE_OPENSSL),openssl) \
 	$(if $(BR2_PACKAGE_FFTW),fftw) \
 	$(if $(BR2_PACKAGE_SYSTEMD),systemd)
Signature · 1 line
2.13.2
#1 lore raw

PATCH 1/1 pulseaudio: add bluez5_utils as dependency

Hello,

Quoted 8 lines · Calin Crisan

The pulseaudio configure script autodetects the presence of bluez 4.x and 5.x packages on the system and will exclude the bluetooth-related modules in their absence.

This commit ensures that bluez5_utils, if selected, are installed before pulseaudio. The same already happens for bluez_utils (4.x).

Signed-off-by Calin Crisan <ccrisan@gmail dot com>

Thanks, I've applied to master. However, I have a comment below.

Quoted 9 lines
---
 package/pulseaudio/pulseaudio.mk | 1 +
 1 file changed, 1 insertion(+)
package/pulseaudio/pulseaudio.mk +0 -0
index ddd503a9f..2f2cfbbed 100644

package/pulseaudio/pulseaudio.mk PULSEAUDIO_DEPENDENCIES = \ · line 38

Quoted 7 lines
package/pulseaudio/pulseaudio.mk +1 -0
@@ -32,6 +32,7 @@ PULSEAUDIO_DEPENDENCIES = \
 	$(if $(BR2_PACKAGE_AVAHI_DAEMON),avahi) \
 	$(if $(BR2_PACKAGE_DBUS),dbus) \
 	$(if $(BR2_PACKAGE_BLUEZ_UTILS),bluez_utils) \
+	$(if $(BR2_PACKAGE_BLUEZ5_UTILS),bluez5_utils) \
 	$(if $(BR2_PACKAGE_OPENSSL),openssl) \
 	$(if $(BR2_PACKAGE_FFTW),fftw) \
 	$(if $(BR2_PACKAGE_SYSTEMD),systemd)

I've applied because you've followed how it's already done for this package, but I'm not super happy with how it's done. Indeed, pulseaudio configure script has explicit enable/disable options such as --enable-bluez4, --enable-bluez5, --enable-openssl, etc.

And it would be a lot better to use them. One benefit is that if we pass --enable-bluez4, but there is a dependency missing, pulseaudio configure.ac script will bail out with an error, instead of silently ignoring and building without pulseaudio support.

Would you be interested in reworking the pulseaudio package to take advantage of those --enable/--disable options?

One example is that the bluez support (either 4 or 5) requires the sbc library... which is not expressed at all in the current pulseuadio.mk.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 pulseaudio: add bluez5_utils as dependency

In reply to Calin Crisan
Quoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Calin" == Calin Crisan <[email protected]> writes:

The pulseaudio configure script autodetects the presence of bluez 4.x and 5.x packages on the system and will exclude the bluetooth-related modules in their absence.

This commit ensures that bluez5_utils, if selected, are installed before pulseaudio. The same already happens for bluez_utils (4.x).

Signed-off-by Calin Crisan <ccrisan@gmail dot com>

Committed to 2017.02.x and 2017.05.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard