Skip to contentSkip to conversation

arch/mips: improve help text of NaN option

PATCH New Vicente Olivert Riera 2 participants 6 messages Jul 17, 2017 – Jul 19, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 arch/mips: improve help text of NaN option

---
 arch/Config.in.mips | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
arch/Config.in.mips +3 -1
index 7dd69659d..f2b352b0b 100644
@@ -169,7 +169,9 @@ choice
 	depends on BR2_mips_32r5 || BR2_mips_64r5
 	default BR2_MIPS_ENABLE_NAN_2008
 	help
-	  NaN encoding to be used
+	  MIPS supports two different NaN encodings, legacy and 2008.
+	  Information about MIPS NaN encodings can be found here:
+	  https://sourceware.org/binutils/docs/as/MIPS-NaN-Encodings.html
 
 config BR2_MIPS_ENABLE_NAN_LEGACY
 	bool "legacy"
Signature · 1 line
2.13.0
#1 lore raw

PATCH 2/2 arch/mips: improve help text of FP32 mode option

---
 arch/Config.in.mips | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
arch/Config.in.mips +4 -1
index f2b352b0b..de71110e0 100644
@@ -139,7 +139,10 @@ choice
 	depends on !BR2_ARCH_IS_64 && !BR2_MIPS_SOFT_FLOAT
 	default BR2_MIPS_FP32_MODE_XX
 	help
-	  FP mode to be used
+	  MIPS32 supports different FP modes (32,xx,64). Information about FP
+	  modes can be found here:
+	  https://sourceware.org/binutils/docs/as/MIPS-Options.html
+	  https://dmz-portal.imgtec.com/wiki/MIPS_O32_ABI_-_FR0_and_FR1_Interlinking#5._Generating_modeless_code
 
 config BR2_MIPS_FP32_MODE_32
 	bool "32"
Signature · 1 line
2.13.0
#2 lore raw

PATCH 1/2 arch/mips: improve help text of NaN option

In reply to Vicente Olivert Riera

Hello,

arch/Config.in.mips choice · line 174

Quoted 12 lines · Vicente Olivert Riera
arch/Config.in.mips +3 -1
index 7dd69659d..f2b352b0b 100644
@@ -169,7 +169,9 @@ choice
 	depends on BR2_mips_32r5 || BR2_mips_64r5
 	default BR2_MIPS_ENABLE_NAN_2008
 	help
-	  NaN encoding to be used
+	  MIPS supports two different NaN encodings, legacy and 2008.
+	  Information about MIPS NaN encodings can be found here:
+	  https://sourceware.org/binutils/docs/as/MIPS-NaN-Encodings.html

Is it useful (and correct?) to say that the Linux kernel, built for MIPS32r5, by default expect the 2008 NaN encoding?

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
#3 lore raw

PATCH 1/2 arch/mips: improve help text of NaN option

Hi Thomas,

Quoted 4 lines · Thomas Petazzoni

Hello,

On Mon, 17 Jul 2017 13:22:54 +0100, Vicente Olivert Riera wrote:

Quoted 15 lines

arch/Config.in.mips choice · line 174

Quoted 12 lines
arch/Config.in.mips +3 -1
index 7dd69659d..f2b352b0b 100644
@@ -169,7 +169,9 @@ choice
 	depends on BR2_mips_32r5 || BR2_mips_64r5
 	default BR2_MIPS_ENABLE_NAN_2008
 	help
-	  NaN encoding to be used
+	  MIPS supports two different NaN encodings, legacy and 2008.
+	  Information about MIPS NaN encodings can be found here:
+	  https://sourceware.org/binutils/docs/as/MIPS-NaN-Encodings.html

Is it useful (and correct?) to say that the Linux kernel, built for MIPS32r5, by default expect the 2008 NaN encoding?

It is correct, but since nan2008 is the default I think is not worth mentioning it. If you change the default value is because you know what you are doing, right?

Vincent

Quoted 3 lines

Thomas

#4 lore raw

PATCH 1/2 arch/mips: improve help text of NaN option

Hello,

Quoted 6 lines · Vicente Olivert Riera
Quoted 2 lines

Is it useful (and correct?) to say that the Linux kernel, built for MIPS32r5, by default expect the 2008 NaN encoding?

It is correct, but since nan2008 is the default I think is not worth mentioning it. If you change the default value is because you know what you are doing, right?

OK, makes sense. Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
#5 lore raw

PATCH 1/2 arch/mips: improve help text of NaN option

In reply to Vicente Olivert Riera

Hello,

Quoted 4 lines · Vicente Olivert Riera
---
 arch/Config.in.mips | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Both applied, thanks!

Have you had the chance to look at the -mnan issue with old gcc versions ? This is currently making the autobuilders quite noisy, which isn't nice.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com