drivers/fmc: remove unused variable
PATCH v3 1/5 drivers/fmc: remove unused variable
From: Federico Vaga <[email protected]>
---
V3 (Alessandro): fixed From line in patch, added alessandro's acked-by
V2 (Pat): added Tested-by and incorrect From line
V1 (Pat): picked from ohwr.org repo, where most fmc users pick from.
drivers/fmc/fru-parse.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/fmc/fru-parse.c +1 -2
@@ -31,12 +31,11 @@ static char *__fru_alloc_get_tl(struct fru_common_header *header, int nr) {struct fru_type_length *tl;char *res; -int len; tl =__fru_get_board_tl (header, nr);if (!tl)return NULL ; - len =fru_strlen (tl); + res =fru_alloc (fru_strlen (tl) +1 );if (!res)return NULL ;
Signature · 1 line
2.1.4
Quoted 6 lines · Alessandro Rubini
From: Federico Vaga <[email protected]>
Signed-off-by Federico Vaga <[email protected]>Tested-by Pat Riehecky <[email protected]>---
Again, I do not like to take patches without any changelog text at all :(
Quoted 2 lines
Again, I do not like to take patches without any changelog text at all :(
Sorry, I added this after the "---" line. I thought it was this one the missing item:
V3 (Alessandro): fixed From line in patch, added alessandro's acked-by
V2 (Pat): added Tested-by and incorrect From line
V1 (Pat): picked from ohwr.org repo, where most fmc users pick from.
thanks
/alessandro
Quoted 11 lines · Alessandro Rubini
Quoted 2 lines
Again, I do not like to take patches without any changelog text at all :(
Sorry, I added this after the "---" line. I thought it was this one the missing item:
V3 (Alessandro): fixed From line in patch, added alessandro's acked-by
V2 (Pat): added Tested-by and incorrect From line
V1 (Pat): picked from ohwr.org repo, where most fmc users pick from.
Ah, sorry, wrong "changelog". I meant the area that shows up in git about what this patch does. There's no description of it other than the Subject line. While this is a simple patch, it is always good to say something like "variable foo was set but never actually used, so it's safe to remove it as the function it called did not change the hardware state" or something like that.
thanks,
greg k-h
Quoted 3 lines
Ah, sorry, wrong "changelog". I meant the area that shows up in git about what this patch does. There's no description of it other than the Subject line.
Yes. Ok, I'll add a longer commit message for V4 of the whole set. Tomorrow (/me leaving now to a client).