drm/radeon: Set depth on low mem to 16 bpp instead of 8 bpp
Subsystems (2)
PATCH 1/1 drm/radeon: Set depth on low mem to 16 bpp instead of 8 bpp
From: Egbert Eich <[email protected]>
The radeon driver reduces the framebuffer resolution to 8bpp if a device with less than 32MB VRAM is found. This causes the framebuffer to run in 8 bit paletted mode. For a text console this is not an issue as 256 different colors is more than one gets on a VGA text console. However this leads to a poor 8bit pseudo-color visual when running X on fbdev, too, which is quite ugly.
In this patch, we try to give some moderate compromise: limit the framebuffer bpp to 8 only when VRAM is 8MB or less, and use 16 bpp otherwise for 32MB or less VRAM.
---
This has been included in SUSE kernel for quite some time, and I'm trying to upstream this. The 16bpp looks more reasonable nowadays, but I know this is a matter of taste, too. It'd be great if you guys can comment on this, at least, whether it's uttly non-sense or not.
thanks,
Takashi
drivers/gpu/drm/radeon/radeon_fb.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/gpu/drm/radeon/radeon_fb.c +5 -2
@@ -347,9 +347,12 @@ int radeon_fbdev_init(struct radeon_device *rdev)if (list_empty (&rdev->ddev->mode_config.connector_list))return 0 ; -/* select 8 bpp console on RN50 or 16MB cards */ -if (ASIC_IS_RN50 (rdev) || rdev->mc.real_vram_size <= (32 *1024 *1024 )) +/* select 8 bpp console on 8MB cards, or 16 bpp on RN50 or 32MB */ +if (rdev->mc.real_vram_size <= (8 *1024 *1024 )) bpp_sel =8 ; +else if (ASIC_IS_RN50 (rdev) || + rdev->mc.real_vram_size <= (32 *1024 *1024 )) + bpp_sel =16 ; rfbdev =kzalloc (sizeof (struct radeon_fbdev ),GFP_KERNEL );if (!rfbdev)
Signature · 6 lines
2.13.2 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Quoted 21 lines · Takashi Iwai
From: Egbert Eich <[email protected]>
The radeon driver reduces the framebuffer resolution to 8bpp if a device with less than 32MB VRAM is found. This causes the framebuffer to run in 8 bit paletted mode. For a text console this is not an issue as 256 different colors is more than one gets on a VGA text console. However this leads to a poor 8bit pseudo-color visual when running X on fbdev, too, which is quite ugly.
In this patch, we try to give some moderate compromise: limit the framebuffer bpp to 8 only when VRAM is 8MB or less, and use 16 bpp otherwise for 32MB or less VRAM.
Signed-off-by Egbert Eich <[email protected]>Signed-off-by Takashi Iwai <[email protected]>---
This has been included in SUSE kernel for quite some time, and I'm trying to upstream this. The 16bpp looks more reasonable nowadays, but I know this is a matter of taste, too. It'd be great if you guys can comment on this, at least, whether it's uttly non-sense or not.
[...]
Quoted 10 lines
drivers/gpu/drm/radeon/radeon_fb.c +0
-1@@ -347,9 +347,12 @@ int radeon_fbdev_init(struct radeon_device *rdev)if (list_empty (&rdev->ddev->mode_config.connector_list))return 0 ; -/* select 8 bpp console on RN50 or 16MB cards */
drivers/gpu/drm/radeon/radeon_fb.c int radeon_fbdev_init(struct radeon_device *rdev) · line 358
Quoted 10 lines
drivers/gpu/drm/radeon/radeon_fb.c +5
-1-if (ASIC_IS_RN50 (rdev) || rdev->mc.real_vram_size <= (32 *1024 *1024 )) +/* select 8 bpp console on 8MB cards, or 16 bpp on RN50 or 32MB */ +if (rdev->mc.real_vram_size <= (8 *1024 *1024 )) bpp_sel =8 ; +else if (ASIC_IS_RN50 (rdev) || + rdev->mc.real_vram_size <= (32 *1024 *1024 )) + bpp_sel =16 ; rfbdev =kzalloc (sizeof (struct radeon_fbdev ),GFP_KERNEL );if (!rfbdev)
Looks reasonable to me — if nothing else, at least the comment and code will match again! :)
My only potential doubt is whether there could be another reason than VRAM size why RN50 should use 8 bpp. Assuming not,
Signature · 6 lines
Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
A message that is not in the archive (sent off-list or not yet received): 7ad0c34d-0efe-c54e-28fb-fc5ba31f1700-otUistvHUpPR7s880joybQ@public.gmane.org
Quoted 48 lines · On Tue, 18 Jul 2017 22:53:48 +0200, Michel D4nzer wrote:
Quoted 21 lines · Takashi Iwai
From: Egbert Eich <[email protected]>
The radeon driver reduces the framebuffer resolution to 8bpp if a device with less than 32MB VRAM is found. This causes the framebuffer to run in 8 bit paletted mode. For a text console this is not an issue as 256 different colors is more than one gets on a VGA text console. However this leads to a poor 8bit pseudo-color visual when running X on fbdev, too, which is quite ugly.
In this patch, we try to give some moderate compromise: limit the framebuffer bpp to 8 only when VRAM is 8MB or less, and use 16 bpp otherwise for 32MB or less VRAM.
Signed-off-by Egbert Eich <[email protected]>Signed-off-by Takashi Iwai <[email protected]>---
This has been included in SUSE kernel for quite some time, and I'm trying to upstream this. The 16bpp looks more reasonable nowadays, but I know this is a matter of taste, too. It'd be great if you guys can comment on this, at least, whether it's uttly non-sense or not.
[...]
Quoted 8 lines
drivers/gpu/drm/radeon/radeon_fb.c +0
-0@@ -347,9 +347,12 @@ int radeon_fbdev_init(struct radeon_device *rdev)if (list_empty (&rdev->ddev->mode_config.connector_list))return 0 ; - /* select 8 bpp console on RN50 or 16MB cards */drivers/gpu/drm/radeon/radeon_fb.c int radeon_fbdev_init(struct radeon_device *rdev) · line 358
Quoted 10 lines
drivers/gpu/drm/radeon/radeon_fb.c +5
-1-if (ASIC_IS_RN50 (rdev) || rdev->mc.real_vram_size <= (32 *1024 *1024 )) +/* select 8 bpp console on 8MB cards, or 16 bpp on RN50 or 32MB */ +if (rdev->mc.real_vram_size <= (8 *1024 *1024 )) bpp_sel =8 ; +else if (ASIC_IS_RN50 (rdev) || + rdev->mc.real_vram_size <= (32 *1024 *1024 )) + bpp_sel =16 ; rfbdev =kzalloc (sizeof (struct radeon_fbdev ),GFP_KERNEL );if (!rfbdev)Looks reasonable to me — if nothing else, at least the comment and code will match again! :)
Quoted 2 lines
My only potential doubt is whether there could be another reason than VRAM size why RN50 should use 8 bpp. Assuming not,
We also hope there no such popular board :)
FWIW, at least we didn't get a relevant bug report, so far.
Quoted 1 line
Reviewed-by Michel Dänzer <[email protected]>
Thanks!
Takashi
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): [email protected]
Alex Deucher
AppliedQuoted 53 lines · Takashi Iwai
Quoted 48 lines · On Tue, 18 Jul 2017 22:53:48 +0200, Michel D4nzer wrote:
Quoted 21 lines · Takashi Iwai
From: Egbert Eich <[email protected]>
The radeon driver reduces the framebuffer resolution to 8bpp if a device with less than 32MB VRAM is found. This causes the framebuffer to run in 8 bit paletted mode. For a text console this is not an issue as 256 different colors is more than one gets on a VGA text console. However this leads to a poor 8bit pseudo-color visual when running X on fbdev, too, which is quite ugly.
In this patch, we try to give some moderate compromise: limit the framebuffer bpp to 8 only when VRAM is 8MB or less, and use 16 bpp otherwise for 32MB or less VRAM.
Signed-off-by Egbert Eich <[email protected]>Signed-off-by Takashi Iwai <[email protected]>---
This has been included in SUSE kernel for quite some time, and I'm trying to upstream this. The 16bpp looks more reasonable nowadays, but I know this is a matter of taste, too. It'd be great if you guys can comment on this, at least, whether it's uttly non-sense or not.
[...]
Quoted 8 lines
drivers/gpu/drm/radeon/radeon_fb.c +0
-0@@ -347,9 +347,12 @@ int radeon_fbdev_init(struct radeon_device *rdev)if (list_empty (&rdev->ddev->mode_config.connector_list))return 0 ; - /* select 8 bpp console on RN50 or 16MB cards */drivers/gpu/drm/radeon/radeon_fb.c int radeon_fbdev_init(struct radeon_device *rdev) · line 358
Quoted 10 lines
drivers/gpu/drm/radeon/radeon_fb.c +5
-1-if (ASIC_IS_RN50 (rdev) || rdev->mc.real_vram_size <= (32 *1024 *1024 )) +/* select 8 bpp console on 8MB cards, or 16 bpp on RN50 or 32MB */ +if (rdev->mc.real_vram_size <= (8 *1024 *1024 )) bpp_sel =8 ; +else if (ASIC_IS_RN50 (rdev) || + rdev->mc.real_vram_size <= (32 *1024 *1024 )) + bpp_sel =16 ; rfbdev =kzalloc (sizeof (struct radeon_fbdev ),GFP_KERNEL );if (!rfbdev)Looks reasonable to me — if nothing else, at least the comment and code will match again! :)
Quoted 2 lines
My only potential doubt is whether there could be another reason than VRAM size why RN50 should use 8 bpp. Assuming not,
Quoted 6 lines
We also hope there no such popular board :)
FWIW, at least we didn't get a relevant bug report, so far.Quoted 1 line
Reviewed-by Michel Dänzer <[email protected]>Thanks!
Applied. thanks!
Alex
Quoted 7 lines
Takashi
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx