perf report: Enable finding the kernel inline function
PATCH 1/1 perf report: Enable finding the kernel inline function
Currently perf has supported a mode to query inline stack. It works well for finding the user space inline function but it doesn't work for finding kernel inline function due to some unnecessary checking.
This patch removes these unnecessary checking. Now the kernel inline function can be reported.
For example,
perf report --inline -g func --stdio
|--46.19%--do_huge_pmd_anonymous_page | do_huge_pmd_anonymous_page (inline) | __do_huge_pmd_anonymous_page (inline) | __SetPageUptodate (inline) | __set_bit (inline)
The result is compared with the output of addr2line. They are match.
--- tools/perf/ui/browsers/hists.c | 3 --- tools/perf/ui/stdio/hist.c | 3 --- 2 files changed, 6 deletions(-)
tools/perf/ui/browsers/hists.c +0 -3
@@ -166,9 +166,6 @@ static struct inline_node *inline_node__create(struct map *map, u64 ip)if (dso ==NULL )return NULL ; -if (dso->kernel !=DSO_TYPE_USER ) -return NULL ; - node =dso__parse_addr_inlines (dso,map__rip_2objdump (map, ip));
tools/perf/ui/stdio/hist.c +0 -3
@@ -35,9 +35,6 @@ static size_t inline__fprintf(struct map *map, u64 ip, int left_margin,if (dso ==NULL )return 0 ; -if (dso->kernel !=DSO_TYPE_USER ) -return 0 ; - node =dso__parse_addr_inlines (dso,map__rip_2objdump (map, ip));if (node ==NULL )
Signature · 1 line
2.7.4
Em Wed, Jul 19, 2017 at 04:31:32AM +0800, Jin Yao escreveu:
Quoted 9 lines
Currently perf has supported a mode to query inline stack. It works well for finding the user space inline function but it doesn't work for finding kernel inline function due to some unnecessary checking.
This patch removes these unnecessary checking. Now the kernel inline function can be reported.
For example,
perf report --inline -g func --stdio
Thanks, applied.
- Arnaldo
tip-bot for Jin Yao
merge bot[tip:perf/core] perf report: Enable finding kernel inline functions
In reply to Jin Yaoperf report: Enable finding kernel inline functions
Commit-ID: 8b8ef2d74dec305b99dd43ec71d3ba2f502100b9 Gitweb: http://git.kernel.org/tip/8b8ef2d74dec305b99dd43ec71d3ba2f502100b9 Author: Jin Yao <[email protected]> AuthorDate: Wed, 19 Jul 2017 04:31:32 +0800 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitDate: Tue, 18 Jul 2017 23:14:27 -0300
perf report: Enable finding kernel inline functions
Currently perf supports a mode to query inline stack. It works well for finding user space inline functions but it doesn't work for kernel ones, due to some unnecessary check.
This patch removes these unnecessary checks. Now kernel inline functions can be reported.
For example:
perf report --inline -g func --stdio
|--46.19%--do_huge_pmd_anonymous_page | do_huge_pmd_anonymous_page (inline) | __do_huge_pmd_anonymous_page (inline) | __SetPageUptodate (inline) | __set_bit (inline)
The result is compared with the output of addr2line. They match.
--- tools/perf/ui/browsers/hists.c | 3 --- tools/perf/ui/stdio/hist.c | 3 --- 2 files changed, 6 deletions(-)
tools/perf/ui/browsers/hists.c +0 -3
@@ -166,9 +166,6 @@ static struct inline_node *inline_node__create(struct map *map, u64 ip)if (dso ==NULL )return NULL ; -if (dso->kernel !=DSO_TYPE_USER ) -return NULL ; - node =dso__parse_addr_inlines (dso,map__rip_2objdump (map, ip));
tools/perf/ui/stdio/hist.c +0 -3
@@ -35,9 +35,6 @@ static size_t inline__fprintf(struct map *map, u64 ip, int left_margin,if (dso ==NULL )return 0 ; -if (dso->kernel !=DSO_TYPE_USER ) -return 0 ; - node =dso__parse_addr_inlines (dso,map__rip_2objdump (map, ip));if (node ==NULL )