Skip to contentSkip to conversation

nvmet: use NVME_NSID_ALL

PATCH New Christoph Hellwig 3 participants 3 messages Jul 18, 2017 – Jul 19, 2017

Subsystems (2)
NVMe NVMe target
lore
Share & tools
lore

Christoph Hellwig

author maintainer
#0 lore raw

PATCH 1/1 nvmet: use NVME_NSID_ALL

Signed-off-by Christoph Hellwig <hch at lst.de>
---
 drivers/nvme/target/admin-cmd.c | 2 +-
 drivers/nvme/target/configfs.c  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/nvme/target/admin-cmd.c +1 -1
index 2d7a98ab53fb..1a34290831db 100644
@@ -100,7 +100,7 @@ static u16 nvmet_get_smart_log(struct nvmet_req *req,
 	u16 status;
 
 	WARN_ON(req == NULL || slog == NULL);
-	if (req->cmd->get_log_page.nsid == cpu_to_le32(0xFFFFFFFF))
+	if (req->cmd->get_log_page.nsid == cpu_to_le32(NVME_NSID_ALL))
 		status = nvmet_get_smart_log_all(req, slog);
 	else
 		status = nvmet_get_smart_log_nsid(req, slog);
drivers/nvme/target/configfs.c +1 -1
index 0a0067e771f5..b6aeb1d70951 100644
@@ -444,7 +444,7 @@ static struct config_group *nvmet_ns_make(struct config_group *group,
 		goto out;
 
 	ret = -EINVAL;
-	if (nsid == 0 || nsid == 0xffffffff)
+	if (nsid == 0 || nsid == NVME_NSID_ALL)
 		goto out;
 
 	ret = -ENOMEM;
Signature · 1 line
2.11.0
#1 lore raw

PATCH 1/1 nvmet: use NVME_NSID_ALL

Quoted 1 line · Christoph Hellwig
Signed-off-by Christoph Hellwig <hch at lst.de>

Looks good.

Reviewed-by Keith Busch <keith.busch at intel.com>
#2 lore raw

PATCH 1/1 nvmet: use NVME_NSID_ALL

In reply to Christoph Hellwig
Quoted 1 line · Christoph Hellwig
Signed-off-by Christoph Hellwig <hch at lst.de>

Looks good,

Reviewed-by Max Gurtovoy <maxg at mellanox.com>