ARM: Convert to using %pOF instead of full_name
Subsystems (9)
PATCH 1/1 ARM: Convert to using %pOF instead of full_name
Now that we have a custom printf format specifier, convert users of full_name to use %pOF instead. This is preparation to remove storing of the full path string for each node.
Signed-off-by Rob Herring <[email protected]>
Cc Russell King <[email protected]>
Cc Kukjin Kim <[email protected]>
Cc Krzysztof Kozlowski <[email protected]>
Cc Javier Martinez Canillas <[email protected]>
Cc Shawn Guo <[email protected]>
Cc Sascha Hauer <[email protected]>
Cc Fabio Estevam <[email protected]>
Cc Jason Cooper <[email protected]>
Cc Andrew Lunn <[email protected]>
Cc Gregory Clement <[email protected]>
Cc Sebastian Hesselbarth <[email protected]>
Cc Tony Lindgren <[email protected]>
Cc "Beno?t Cousson" <[email protected]>
Cc Paul Walmsley <[email protected]>
Cc Heiko Stuebner <[email protected]>
Cc Simon Horman <[email protected]>
Cc Magnus Damm <[email protected]>
Cc linux-arm-kernel at lists.infradead.org
Cc linux-samsung-soc at vger.kernel.org
Cc linux-omap at vger.kernel.org
Cc linux-rockchip at lists.infradead.org
Cc linux-renesas-soc at vger.kernel.org
--- arch/arm/kernel/cpuidle.c | 4 ++-- arch/arm/kernel/devtree.c | 6 +++--- arch/arm/kernel/topology.c | 4 ++-- arch/arm/mach-exynos/suspend.c | 8 ++++---- arch/arm/mach-imx/gpc.c | 4 ++-- arch/arm/mach-mvebu/kirkwood.c | 4 ++-- arch/arm/mach-omap2/omap-wakeupgen.c | 4 ++-- arch/arm/mach-omap2/omap_hwmod.c | 4 ++-- arch/arm/mach-rockchip/platsmp.c | 4 ++-- arch/arm/mach-shmobile/pm-rmobile.c | 8 ++++---- 10 files changed, 25 insertions(+), 25 deletions(-)
arch/arm/kernel/cpuidle.c +2 -2
@@ -101,8 +101,8 @@ static int __init arm_cpuidle_read_ops(struct device_node *dn, int cpu) ops =arm_cpuidle_get_ops (enable_method);if (!ops) { -pr_warn ("%s: unsupported enable-method property: %s\n" , - dn->full_name, enable_method); +pr_warn ("%pOF: unsupported enable-method property: %s\n" , + dn, enable_method);return -EOPNOTSUPP ; }
arch/arm/kernel/devtree.c +3 -3
@@ -95,7 +95,7 @@ void __init arm_dt_init_cpu_maps(void)if (of_node_cmp (cpu->type,"cpu" ))continue ; -pr_debug (" * %s...\n" , cpu->full_name); +pr_debug (" * %pOF...\n" , cpu);/* * A device tree containing CPU nodes with missing "reg" * properties is considered invalid to build the
@@ -103,8 +103,8 @@ void __init arm_dt_init_cpu_maps(void)*/ cell =of_get_property (cpu,"reg" , &prop_bytes);if (!cell || prop_bytes <sizeof (*cell)) { -pr_debug (" * %s missing reg property\n" , - cpu->full_name); +pr_debug (" * %pOF missing reg property\n" , + cpu);of_node_put (cpu);return ; }
arch/arm/kernel/topology.c +2 -2
@@ -127,8 +127,8 @@ static void __init parse_dt_topology(void) rate =of_get_property (cn,"clock-frequency" , &len);if (!rate || len !=4 ) { -pr_err ("%s missing clock-frequency property\n" , - cn->full_name); +pr_err ("%pOF missing clock-frequency property\n" , + cn);continue ; }
arch/arm/mach-exynos/suspend.c +4 -4
@@ -187,21 +187,21 @@ static int __init exynos_pmu_irq_init(struct device_node *node,struct irq_domain *parent_domain, *domain;if (!parent) { -pr_err ("%s: no parent, giving up\n" , node->full_name); +pr_err ("%pOF: no parent, giving up\n" , node);return -ENODEV ; } parent_domain =irq_find_host (parent);if (!parent_domain) { -pr_err ("%s: unable to obtain parent domain\n" , node->full_name); +pr_err ("%pOF: unable to obtain parent domain\n" , node);return -ENXIO ; } pmu_base_addr =of_iomap (node,0 );if (!pmu_base_addr) { -pr_err ("%s: failed to find exynos pmu register\n" , - node->full_name); +pr_err ("%pOF: failed to find exynos pmu register\n" , + node);return -ENOMEM ; }
arch/arm/mach-imx/gpc.c +2 -2
@@ -224,13 +224,13 @@ static int __init imx_gpc_init(struct device_node *node,int i;if (!parent) { -pr_err ("%s: no parent, giving up\n" , node->full_name); +pr_err ("%pOF: no parent, giving up\n" , node);return -ENODEV ; } parent_domain =irq_find_host (parent);if (!parent_domain) { -pr_err ("%s: unable to obtain parent domain\n" , node->full_name); +pr_err ("%pOF: unable to obtain parent domain\n" , node);return -ENXIO ; }
arch/arm/mach-mvebu/kirkwood.c +2 -2
@@ -107,8 +107,8 @@ static void __init kirkwood_dt_eth_fixup(void)clk_prepare_enable (clk);/* store MAC address register contents in local-mac-address */ -pr_err (FW_INFO "%s: local-mac-address is not set\n" , - np->full_name); +pr_err (FW_INFO "%pOF: local-mac-address is not set\n" , + np); pmac =kzalloc (sizeof (*pmac) +6 ,GFP_KERNEL );if (!pmac)
arch/arm/mach-omap2/omap-wakeupgen.c +2 -2
@@ -522,13 +522,13 @@ static int __init wakeupgen_init(struct device_node *node,u32 val;if (!parent) { -pr_err ("%s: no parent, giving up\n" , node->full_name); +pr_err ("%pOF: no parent, giving up\n" , node);return -ENODEV ; } parent_domain =irq_find_host (parent);if (!parent_domain) { -pr_err ("%s: unable to obtain parent domain\n" , node->full_name); +pr_err ("%pOF: unable to obtain parent domain\n" , node);return -ENXIO ; }/* Not supported on OMAP4 ES1.0 silicon */
arch/arm/mach-omap2/omap_hwmod.c +2 -2
@@ -2417,8 +2417,8 @@ static int __init _init_mpu_rt_base(struct omap_hwmod *oh, void *data,if (mem)pr_err ("omap_hwmod: %s: Could not ioremap\n" , oh->name);else -pr_err ("omap_hwmod: %s: Missing dt reg%i for %s\n" , - oh->name, index, np->full_name); +pr_err ("omap_hwmod: %s: Missing dt reg%i for %pOF\n" , + oh->name, index, np);return -ENXIO ; }
arch/arm/mach-rockchip/platsmp.c +2 -2
@@ -182,8 +182,8 @@ static int __init rockchip_smp_prepare_sram(struct device_node *node) ret =of_address_to_resource (node,0 , &res);if (ret <0 ) { -pr_err ("%s: could not get address for node %s\n" , - __func__, node->full_name); +pr_err ("%s: could not get address for node %pOF\n" , + __func__, node);return ret; }
arch/arm/mach-shmobile/pm-rmobile.c +4 -4
@@ -195,8 +195,8 @@ static void __init add_special_pd(struct device_node *np, enum pd_types type)return ; } -pr_debug ("Special PM domain %s type %d for %s\n" , pd->name, type, - np->full_name); +pr_debug ("Special PM domain %s type %d for %pOF\n" , pd->name, type, + np); special_pds[num_special_pds].pd = pd; special_pds[num_special_pds].type = type;
@@ -331,13 +331,13 @@ static int __init rmobile_init_pm_domains(void)for_each_compatible_node (np,NULL ,"renesas,sysc-rmobile" ) { base =of_iomap (np,0 );if (!base) { -pr_warn ("%s cannot map reg 0\n" , np->full_name); +pr_warn ("%pOF cannot map reg 0\n" , np);continue ; } pmd =of_get_child_by_name (np,"pm-domains" );if (!pmd) { -pr_warn ("%s lacks pm-domains node\n" , np->full_name); +pr_warn ("%pOF lacks pm-domains node\n" , np);continue ; }
--
2.11.0
Quoted 111 lines · Rob Herring
Now that we have a custom printf format specifier, convert users of
full_nameto use %pOF instead. This is preparation to remove storing of the full path string for each node.Signed-off-by Rob Herring <[email protected]>Cc Russell King <[email protected]>Cc Kukjin Kim <[email protected]>Cc Krzysztof Kozlowski <[email protected]>Cc Javier Martinez Canillas <[email protected]>Cc Shawn Guo <[email protected]>Cc Sascha Hauer <[email protected]>Cc Fabio Estevam <[email protected]>Cc Jason Cooper <[email protected]>Cc Andrew Lunn <[email protected]>Cc Gregory Clement <[email protected]>Cc Sebastian Hesselbarth <[email protected]>Cc Tony Lindgren <[email protected]>Cc "Beno?t Cousson" <[email protected]>Cc Paul Walmsley <[email protected]>Cc Heiko Stuebner <[email protected]>Cc Simon Horman <[email protected]>Cc Magnus Damm <[email protected]>Cc linux-arm-kernel at lists.infradead.orgCc linux-samsung-soc at vger.kernel.orgCc linux-omap at vger.kernel.orgCc linux-rockchip at lists.infradead.orgCc linux-renesas-soc at vger.kernel.org--- arch/arm/kernel/cpuidle.c | 4 ++-- arch/arm/kernel/devtree.c | 6 +++--- arch/arm/kernel/topology.c | 4 ++-- arch/arm/mach-exynos/suspend.c | 8 ++++---- arch/arm/mach-imx/gpc.c | 4 ++-- arch/arm/mach-mvebu/kirkwood.c | 4 ++-- arch/arm/mach-omap2/omap-wakeupgen.c | 4 ++-- arch/arm/mach-omap2/omap_hwmod.c | 4 ++-- arch/arm/mach-rockchip/platsmp.c | 4 ++-- arch/arm/mach-shmobile/pm-rmobile.c | 8 ++++---- 10 files changed, 25 insertions(+), 25 deletions(-)arch/arm/kernel/cpuidle.c +2
-2@@ -101,8 +101,8 @@ static int __init arm_cpuidle_read_ops(struct device_node *dn, int cpu) ops =arm_cpuidle_get_ops (enable_method);if (!ops) { -pr_warn ("%s: unsupported enable-method property: %s\n" , - dn->full_name, enable_method); +pr_warn ("%pOF: unsupported enable-method property: %s\n" , + dn, enable_method);return -EOPNOTSUPP ; }arch/arm/kernel/devtree.c +3
-3@@ -95,7 +95,7 @@ void __init arm_dt_init_cpu_maps(void)if (of_node_cmp (cpu->type,"cpu" ))continue ; -pr_debug (" * %s...\n" , cpu->full_name); +pr_debug (" * %pOF...\n" , cpu);/* * A device tree containing CPU nodes with missing "reg" * properties is considered invalid to build the @@ -103,8 +103,8 @@ void __init arm_dt_init_cpu_maps(void)*/ cell =of_get_property (cpu,"reg" , &prop_bytes);if (!cell || prop_bytes <sizeof (*cell)) { -pr_debug (" * %s missing reg property\n" , - cpu->full_name); +pr_debug (" * %pOF missing reg property\n" , + cpu);of_node_put (cpu);return ; }arch/arm/kernel/topology.c +2
-2@@ -127,8 +127,8 @@ static void __init parse_dt_topology(void) rate =of_get_property (cn,"clock-frequency" , &len);if (!rate || len !=4 ) { -pr_err ("%s missing clock-frequency property\n" , - cn->full_name); +pr_err ("%pOF missing clock-frequency property\n" , + cn);continue ; }arch/arm/mach-exynos/suspend.c +2
-2@@ -187,21 +187,21 @@ static int __init exynos_pmu_irq_init(struct device_node *node,struct irq_domain *parent_domain, *domain;if (!parent) { -pr_err ("%s: no parent, giving up\n" , node->full_name); +pr_err ("%pOF: no parent, giving up\n" , node);return -ENODEV ; } parent_domain =irq_find_host (parent);if (!parent_domain) { -pr_err ("%s: unable to obtain parent domain\n" , node->full_name); +pr_err ("%pOF: unable to obtain parent domain\n" , node);
arch/arm/mach-exynos/suspend.c static int __init exynos_pmu_irq_init(struct device_node *node, · line 204
Quoted 10 lines
arch/arm/mach-exynos/suspend.c +2
-2return -ENXIO ; } pmu_base_addr =of_iomap (node,0 );if (!pmu_base_addr) { -pr_err ("%s: failed to find exynos pmu register\n" , - node->full_name); +pr_err ("%pOF: failed to find exynos pmu register\n" , + node);
This could be one line now. Can you merge it?
Beside that, for Exynos:
Best regards,
Krzysztof
Quoted 2 lines · Rob Herring
Now that we have a custom printf format specifier, convert users of
full_nameto use %pOF instead. This is preparation to remove storing
Oh nice. If the commit adding %pOF is already set in stone, i'd suggest to mention the commit id here in the commit log.
Quoted 67 lines
of the full path string for each node.
Signed-off-by Rob Herring <[email protected]>Cc Russell King <[email protected]>Cc Kukjin Kim <[email protected]>Cc Krzysztof Kozlowski <[email protected]>Cc Javier Martinez Canillas <[email protected]>Cc Shawn Guo <[email protected]>Cc Sascha Hauer <[email protected]>Cc Fabio Estevam <[email protected]>Cc Jason Cooper <[email protected]>Cc Andrew Lunn <[email protected]>Cc Gregory Clement <[email protected]>Cc Sebastian Hesselbarth <[email protected]>Cc Tony Lindgren <[email protected]>Cc "Beno?t Cousson" <[email protected]>Cc Paul Walmsley <[email protected]>Cc Heiko Stuebner <[email protected]>Cc Simon Horman <[email protected]>Cc Magnus Damm <[email protected]>Cc linux-arm-kernel at lists.infradead.orgCc linux-samsung-soc at vger.kernel.orgCc linux-omap at vger.kernel.orgCc linux-rockchip at lists.infradead.orgCc linux-renesas-soc at vger.kernel.org--- arch/arm/kernel/cpuidle.c | 4 ++-- arch/arm/kernel/devtree.c | 6 +++--- arch/arm/kernel/topology.c | 4 ++-- arch/arm/mach-exynos/suspend.c | 8 ++++---- arch/arm/mach-imx/gpc.c | 4 ++-- arch/arm/mach-mvebu/kirkwood.c | 4 ++-- arch/arm/mach-omap2/omap-wakeupgen.c | 4 ++-- arch/arm/mach-omap2/omap_hwmod.c | 4 ++-- arch/arm/mach-rockchip/platsmp.c | 4 ++-- arch/arm/mach-shmobile/pm-rmobile.c | 8 ++++---- 10 files changed, 25 insertions(+), 25 deletions(-)arch/arm/kernel/cpuidle.c +2
-2@@ -101,8 +101,8 @@ static int __init arm_cpuidle_read_ops(struct device_node *dn, int cpu) ops =arm_cpuidle_get_ops (enable_method);if (!ops) { -pr_warn ("%s: unsupported enable-method property: %s\n" , - dn->full_name, enable_method); +pr_warn ("%pOF: unsupported enable-method property: %s\n" , + dn, enable_method);return -EOPNOTSUPP ; }arch/arm/kernel/devtree.c +1
-1@@ -95,7 +95,7 @@ void __init arm_dt_init_cpu_maps(void)if (of_node_cmp (cpu->type,"cpu" ))continue ; -pr_debug (" * %s...\n" , cpu->full_name); +pr_debug (" * %pOF...\n" , cpu);/* * A device tree containing CPU nodes with missing "reg" * properties is considered invalid to build the
arch/arm/kernel/devtree.c void __init arm_dt_init_cpu_maps(void) · line 107
Quoted 7 lines
arch/arm/kernel/devtree.c +2
-2@@ -103,8 +103,8 @@ void __init arm_dt_init_cpu_maps(void)*/ cell =of_get_property (cpu,"reg" , &prop_bytes);if (!cell || prop_bytes <sizeof (*cell)) { -pr_debug (" * %s missing reg property\n" , - cpu->full_name); +pr_debug (" * %pOF missing reg property\n" , + cpu);
You could join lines here and in the next hunk. And there are two more further down.
Quoted 8 lines
arch/arm/kernel/devtree.c +0
-0of_node_put (cpu);return ; }arch/arm/kernel/topology.c +0
-0
arch/arm/kernel/topology.c static void __init parse_dt_topology(void) · line 134
Quoted 10 lines
arch/arm/kernel/topology.c +2
-2@@ -127,8 +127,8 @@ static void __init parse_dt_topology(void) rate =of_get_property (cn,"clock-frequency" , &len);if (!rate || len !=4 ) { -pr_err ("%s missing clock-frequency property\n" , - cn->full_name); +pr_err ("%pOF missing clock-frequency property\n" , + cn);continue ; }
Best regards
Uwe
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ |
Quoted 6 lines · Uwe Kleine-K?nig
Quoted 2 lines · Rob Herring
Now that we have a custom printf format specifier, convert users of
full_nameto use %pOF instead. This is preparation to remove storingOh nice. If the commit adding %pOF is already set in stone, i'd suggest to mention the commit id here in the commit log.
It is in 4.13, but I'm not really eager to update all 60 patches and I'd prefer consistency in the commit msg as quite a few have already been applied.
Quoted 1 line
Quoted 1 line
of the full path string for each node.
[...]
Quoted 11 lines
arch/arm/kernel/devtree.c void __init arm_dt_init_cpu_maps(void) · line 107
Quoted 8 lines
arch/arm/kernel/devtree.c +2
-2@@ -103,8 +103,8 @@ void __init arm_dt_init_cpu_maps(void)*/ cell =of_get_property (cpu,"reg" , &prop_bytes);if (!cell || prop_bytes <sizeof (*cell)) { -pr_debug (" * %s missing reg property\n" , - cpu->full_name); +pr_debug (" * %pOF missing reg property\n" , + cpu);You could join lines here and in the next hunk. And there are two more further down.
Okay. I did that generally, but missed a few.
Rob
Am Dienstag, 18. Juli 2017, 16:42:41 CEST schrieb Rob Herring:
Quoted 5 lines
Now that we have a custom printf format specifier, convert users of
full_nameto use %pOF instead. This is preparation to remove storing of the full path string for each node.Signed-off-by Rob Herring <[email protected]>
for the Rockchip part
Acked-by Heiko Stuebner <[email protected]>
Quoted 15 lines
arch/arm/mach-rockchip/platsmp.c +2
-2@@ -182,8 +182,8 @@ static int __init rockchip_smp_prepare_sram(struct device_node *node) ret =of_address_to_resource (node,0 , &res);if (ret <0 ) { -pr_err ("%s: could not get address for node %s\n" , - __func__, node->full_name); +pr_err ("%s: could not get address for node %pOF\n" , + __func__, node);return ret; }
Quoted 5 lines · Rob Herring
Now that we have a custom printf format specifier, convert users of
full_nameto use %pOF instead. This is preparation to remove storing of the full path string for each node.Signed-off-by Rob Herring <[email protected]>
Reviewed-by Geert Uytterhoeven <[email protected]>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Hi Rob,
Quoted 27 lines · Rob Herring
Now that we have a custom printf format specifier, convert users of
full_nameto use %pOF instead. This is preparation to remove storing of the full path string for each node.Signed-off-by Rob Herring <[email protected]>Cc Russell King <[email protected]>Cc Kukjin Kim <[email protected]>Cc Krzysztof Kozlowski <[email protected]>Cc Javier Martinez Canillas <[email protected]>Cc Shawn Guo <[email protected]>Cc Sascha Hauer <[email protected]>Cc Fabio Estevam <[email protected]>Cc Jason Cooper <[email protected]>Cc Andrew Lunn <[email protected]>Cc Gregory Clement <[email protected]>Cc Sebastian Hesselbarth <[email protected]>Cc Tony Lindgren <[email protected]>Cc "Beno?t Cousson" <[email protected]>Cc Paul Walmsley <[email protected]>Cc Heiko Stuebner <[email protected]>Cc Simon Horman <[email protected]>Cc Magnus Damm <[email protected]>Cc linux-arm-kernel at lists.infradead.orgCc linux-samsung-soc at vger.kernel.orgCc linux-omap at vger.kernel.orgCc linux-rockchip at lists.infradead.orgCc linux-renesas-soc at vger.kernel.org
Quoted 7 lines
--- arch/arm/kernel/cpuidle.c | 4 ++-- arch/arm/kernel/devtree.c | 6 +++--- arch/arm/kernel/topology.c | 4 ++-- arch/arm/mach-exynos/suspend.c | 8 ++++---- arch/arm/mach-imx/gpc.c | 4 ++-- arch/arm/mach-mvebu/kirkwood.c | 4 ++--
For the krkwood part
Acked-by Gregory CLEMENT <[email protected]>
Thanks,
Gregory
Quoted 209 lines
arch/arm/mach-omap2/omap-wakeupgen.c | 4 ++-- arch/arm/mach-omap2/omap_hwmod.c | 4 ++-- arch/arm/mach-rockchip/platsmp.c | 4 ++-- arch/arm/mach-shmobile/pm-rmobile.c | 8 ++++---- 10 files changed, 25 insertions(+), 25 deletions(-)arch/arm/kernel/cpuidle.c +2
-2@@ -101,8 +101,8 @@ static int __init arm_cpuidle_read_ops(struct device_node *dn, int cpu) ops =arm_cpuidle_get_ops (enable_method);if (!ops) { -pr_warn ("%s: unsupported enable-method property: %s\n" , - dn->full_name, enable_method); +pr_warn ("%pOF: unsupported enable-method property: %s\n" , + dn, enable_method);return -EOPNOTSUPP ; }arch/arm/kernel/devtree.c +3
-3@@ -95,7 +95,7 @@ void __init arm_dt_init_cpu_maps(void)if (of_node_cmp (cpu->type,"cpu" ))continue ; -pr_debug (" * %s...\n" , cpu->full_name); +pr_debug (" * %pOF...\n" , cpu);/* * A device tree containing CPU nodes with missing "reg" * properties is considered invalid to build the @@ -103,8 +103,8 @@ void __init arm_dt_init_cpu_maps(void)*/ cell =of_get_property (cpu,"reg" , &prop_bytes);if (!cell || prop_bytes <sizeof (*cell)) { -pr_debug (" * %s missing reg property\n" , - cpu->full_name); +pr_debug (" * %pOF missing reg property\n" , + cpu);of_node_put (cpu);return ; }arch/arm/kernel/topology.c +2
-2@@ -127,8 +127,8 @@ static void __init parse_dt_topology(void) rate =of_get_property (cn,"clock-frequency" , &len);if (!rate || len !=4 ) { -pr_err ("%s missing clock-frequency property\n" , - cn->full_name); +pr_err ("%pOF missing clock-frequency property\n" , + cn);continue ; }arch/arm/mach-exynos/suspend.c +4
-4@@ -187,21 +187,21 @@ static int __init exynos_pmu_irq_init(struct device_node *node,struct irq_domain *parent_domain, *domain;if (!parent) { -pr_err ("%s: no parent, giving up\n" , node->full_name); +pr_err ("%pOF: no parent, giving up\n" , node);return -ENODEV ; } parent_domain =irq_find_host (parent);if (!parent_domain) { -pr_err ("%s: unable to obtain parent domain\n" , node->full_name); +pr_err ("%pOF: unable to obtain parent domain\n" , node);return -ENXIO ; } pmu_base_addr =of_iomap (node,0 );if (!pmu_base_addr) { -pr_err ("%s: failed to find exynos pmu register\n" , - node->full_name); +pr_err ("%pOF: failed to find exynos pmu register\n" , + node);return -ENOMEM ; }arch/arm/mach-imx/gpc.c +2
-2@@ -224,13 +224,13 @@ static int __init imx_gpc_init(struct device_node *node,int i;if (!parent) { -pr_err ("%s: no parent, giving up\n" , node->full_name); +pr_err ("%pOF: no parent, giving up\n" , node);return -ENODEV ; } parent_domain =irq_find_host (parent);if (!parent_domain) { -pr_err ("%s: unable to obtain parent domain\n" , node->full_name); +pr_err ("%pOF: unable to obtain parent domain\n" , node);return -ENXIO ; }arch/arm/mach-mvebu/kirkwood.c +2
-2@@ -107,8 +107,8 @@ static void __init kirkwood_dt_eth_fixup(void)clk_prepare_enable (clk);/* store MAC address register contents in local-mac-address */ -pr_err (FW_INFO "%s: local-mac-address is not set\n" , - np->full_name); +pr_err (FW_INFO "%pOF: local-mac-address is not set\n" , + np); pmac =kzalloc (sizeof (*pmac) +6 ,GFP_KERNEL );if (!pmac)arch/arm/mach-omap2/omap-wakeupgen.c +2
-2@@ -522,13 +522,13 @@ static int __init wakeupgen_init(struct device_node *node,u32 val;if (!parent) { -pr_err ("%s: no parent, giving up\n" , node->full_name); +pr_err ("%pOF: no parent, giving up\n" , node);return -ENODEV ; } parent_domain =irq_find_host (parent);if (!parent_domain) { -pr_err ("%s: unable to obtain parent domain\n" , node->full_name); +pr_err ("%pOF: unable to obtain parent domain\n" , node);return -ENXIO ; }/* Not supported on OMAP4 ES1.0 silicon */ arch/arm/mach-omap2/omap_hwmod.c +2
-2@@ -2417,8 +2417,8 @@ static int __init _init_mpu_rt_base(struct omap_hwmod *oh, void *data,if (mem)pr_err ("omap_hwmod: %s: Could not ioremap\n" , oh->name);else -pr_err ("omap_hwmod: %s: Missing dt reg%i for %s\n" , - oh->name, index, np->full_name); +pr_err ("omap_hwmod: %s: Missing dt reg%i for %pOF\n" , + oh->name, index, np);return -ENXIO ; }arch/arm/mach-rockchip/platsmp.c +2
-2@@ -182,8 +182,8 @@ static int __init rockchip_smp_prepare_sram(struct device_node *node) ret =of_address_to_resource (node,0 , &res);if (ret <0 ) { -pr_err ("%s: could not get address for node %s\n" , - __func__, node->full_name); +pr_err ("%s: could not get address for node %pOF\n" , + __func__, node);return ret; }arch/arm/mach-shmobile/pm-rmobile.c +4
-5@@ -195,8 +195,8 @@ static void __init add_special_pd(struct device_node *np, enum pd_types type)return ; } -pr_debug ("Special PM domain %s type %d for %s\n" , pd->name, type, - np->full_name); +pr_debug ("Special PM domain %s type %d for %pOF\n" , pd->name, type, + np); special_pds[num_special_pds].pd = pd; special_pds[num_special_pds].type = type;@@ -331,13 +331,13 @@ static int __init rmobile_init_pm_domains(void)for_each_compatible_node (np,NULL ,"renesas,sysc-rmobile" ) { base =of_iomap (np,0 );if (!base) { -pr_warn ("%s cannot map reg 0\n" , np->full_name); +pr_warn ("%pOF cannot map reg 0\n" , np);continue ; } pmd =of_get_child_by_name (np,"pm-domains" );if (!pmd) { -pr_warn ("%s lacks pm-domains node\n" , np->full_name); +pr_warn ("%pOF lacks pm-domains node\n" , np);continue ; } --2.11.0
Signature · 4 lines
Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
Quoted 3 lines · Rob Herring
Now that we have a custom printf format specifier, convert users of
full_nameto use %pOF instead. This is preparation to remove storing of the full path string for each node.
- Paul